Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadowserver documentation: if reports is "", things don't work #2521

Closed
aaronkaplan opened this issue Aug 14, 2024 · 1 comment · Fixed by #2523
Closed

shadowserver documentation: if reports is "", things don't work #2521

aaronkaplan opened this issue Aug 14, 2024 · 1 comment · Fixed by #2523
Assignees
Labels
component: bots documentation: feeds About intelmq/etc/feeds.yaml documentation Indicates a need for improvements or additions to documentation
Milestone

Comments

@aaronkaplan
Copy link
Member

It was confusing for a user to have "reports": "" in the config but then he would not get any reports.
Instead the reports key must not be present at all, to get all reports. That's confusing and might have to be better explained in the documentation.

@aaronkaplan aaronkaplan added documentation Indicates a need for improvements or additions to documentation component: bots documentation: feeds About intelmq/etc/feeds.yaml labels Aug 14, 2024
@aaronkaplan aaronkaplan added this to the 3.3.1 milestone Aug 14, 2024
@aaronkaplan aaronkaplan self-assigned this Aug 14, 2024
@sebix
Copy link
Member

sebix commented Aug 16, 2024

IMHO the bot should behave the same with

  • a parameter not set
  • a parameter set with an empty string (or any other suitabe type and an empty value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bots documentation: feeds About intelmq/etc/feeds.yaml documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants