CSV line recovery forces Windows line endings

[sinus-x]

The recover_line_csv() function is joining data with \r\n, redgardless of the source file newlines:

intelmq/intelmq/lib/bot.py

Line 1042 in a2d20df

tempdata = '\r\n'.join(self.tempdata) + '\r\n' if self.tempdata else ''

This means that bot test are failing even though the parsing succeeded, because the raw values do not match: there is a new CR byte. As a workaround, bot tests are replacing newlines in their test files to account for that, which is not ideal solution.

intelmq/intelmq/tests/bots/parsers/generic/test_parser_csv_data_type.py

Line 20 in f7a5c7a

"raw": utils.base64_encode(SAMPLE_FILE.replace('\n', '\r\n')),

[ghost]

Yes, ideally the use line ending is detected in ParserBot.parse_csv and ParserBot.parse_csv_dict and then saved in the class or somewhere else.