Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parser performance #472

Merged
merged 9 commits into from
Jan 10, 2024
Merged

feat: parser performance #472

merged 9 commits into from
Jan 10, 2024

Conversation

lukecotter
Copy link
Contributor

@lukecotter lukecotter commented Jan 8, 2024 •
edited by lcottercertinia
Loading

Description

  • Generally improves parser performance.
  • The main change is to remove recursion from the aggregate totals function
  • Add a fast path for getting commonly used event types
  • Add a fast path for splitting new lines when the line endings are all lf e.g \n

Total parse time: from 2.02s -> 1.95s
toTree: ~1022ms -> 1025 ms
parseLog: ~974-> 750 ms

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • ⚡ Performance Improvement
  • 📝 Documentation
  • 🔧 Chore
  • 💥 Breaking change

[optional] Any images / gifs / video

Related Tickets & Documents

Related Issue #475
fixes #
resolves #
closes #

Added tests?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

Added to documentation?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • [X ] 🙅 not needed

[optional] Are there any post-deployment tasks we need to perform?

@lukecotter
perf: improve aggregateTotals by removing recursion
624fc54
@lukecotter
perf: replace for each with reduce
160bffa
@lukecotter
Merge branch 'main' into feat-parser-performance
8dd2fdd
@lukecotter
perf: added fast path for splitting lines when EOL is \n
87e4ba0
@lukecotter
perf: make parseLineNumber + parseTimestamp functions of the LogLine
29f4b88 
Should reduce gc a little
@lukecotter
perf: add fast path to get log class type for most common types
fedfd9e 
 'METHOD_ENTRY' => MethodEntryLine;
 'METHOD_EXIT' => MethodExitLine;
 'CONSTRUCTOR_ENTRY' => ConstructorEntryLine;
 'CONSTRUCTOR_EXIT' => ConstructorExitLine;
@lukecotter
perf: only add parent node with children to depth map
a0c09f1 
This means that we have less to loop later on when aggregating values.
@lukecotter
perf: move the child duration aggregation to the aggregateTotals func…
6e95904 
…tion
@lukecotter
test: fix duration rollup test now that has moved
d2949e3
@lcottercertinia lcottercertinia merged commit 9691945 into certinia:main Jan 10, 2024
3 checks passed
@lukecotter lukecotter deleted the feat-parser-performance branch January 10, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcottercertinia lcottercertinia lcottercertinia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukecotter @lcottercertinia