Run tests with cert-manager 1.16.0 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
wallrj
changed the title
|
Looks like all the tests ran successfully |
Signed-off-by: Richard Wall <[email protected]>
wallrj
force-pushed
the
test-cert-manager-1.16
branch
from
9390f11
to
376a0a2
Compare
wallrj
changed the title
|
@ARichman555 PTAL A CI job failed, but I can't understand what went wrong: make: *** [Makefile:80: blog-test] Error 1
Error: Process completed with exit code 2. |
|
Hi, yea it looks like there's a problem with the test that's unrelated to this commit. We're actively looking into it and will get this merged once it's fixed |
ARichman555
approved these changes
Oct 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: ARichman555 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
merged commit c283d7d
into
cert-manager:main
39 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if you prefer to run the E2E tests against an older established version of cert-manager,
but with the release of cert-manager 1.16 yesterday, we have removed 1.14 from the supported versions page.
@ARichman555 Consider adding the supported cert-manager version to this page: