Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support disabling Kubernetes client side rate limiting #336

Conversation

hexalellogram
Copy link

This should theoretically resolve #334.

Note that I haven't had the chance to test this at all - I believe it works (and I based a good bit of my work on the changes in cert-manager/istio-csr#352 which does the same thing for istio-csr), but I haven't actually proven that out end-to-end by adding unit and integration tests because I don't really have a deep understanding of the test suite here.

This PR includes:

  • new value in Helm values, disableClientSideRateLimiting
  • corresponding new command line option
  • Using this new option to set config.QPS and config.Burst for the Kubernetes REST client

main.go Outdated
@@ -75,7 +78,16 @@ func main() {

ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
config = ctrl.GetConfigOrDie()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ARichman555
Copy link
Contributor

Hi, we're currently in the process of testing this PR to make sure everything works properly! We're currently not seeing any improvements by enabling this so looking into why that may be.

Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ARichman555 ARichman555 force-pushed the bt-support-disabling-client-side-rate-limiting branch from ec91cdd to 2f22d86 Compare September 20, 2024 17:56
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot merged commit 66583e0 into cert-manager:main Sep 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Option to disable kubernetes client side rate limiting
6 participants