Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

React-router hash links #29

Closed
1 of 4 tasks
Matt-Butler opened this issue Jun 20, 2017 · 2 comments
Closed
1 of 4 tasks

React-router hash links #29

Matt-Butler opened this issue Jun 20, 2017 · 2 comments
Labels
📦 terra-ui
Milestone
Backlog

Comments

@Matt-Butler
Copy link
Contributor

Issue Description

We want to be able to use hash-links with react router. This issue explains more about it: remix-run/react-router#394

We are using react-router 3.0.5.

Issue Type

  • New Feature
  • Enhancement
  • Bug
  • Other
@Matt-Butler Matt-Butler mentioned this issue Jun 20, 2017
Merged
@Matt-Butler
Copy link
Contributor Author

I tried using the hashLinkScroll provided here:
remix-run/react-router#394 (comment)
This fix did not work.

Hash links work for the react_on_rails tutorial site, but they are doing server-side rendering.
https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/config/initializers/react_on_rails.rb#L34

@bjankord bjankord added this to the Backlog milestone Sep 21, 2017
@bjankord
Copy link
Contributor

Hash links are working with the latest terra-dev-site. See getting started page for example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
📦 terra-ui
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bjankord @Matt-Butler