Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-core-docs] Fixed icon imports not rendering #3937

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Oct 13, 2023

Summary

The import code snippets for terra-icon were not rendering properly.

CleanShot 2023-10-13 at 11 03 05

This PR updates the examples to now have the correct import statement:

CleanShot 2023-10-13 at 11 02 38

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Oct 13, 2023
@sdadn sdadn requested a review from a team as a code owner October 13, 2023 16:05
Copy link
Contributor

@adoroshk adoroshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that Imports look like expected:
Screenshot 2023-10-13 at 12 16 33 PM

@github-actions github-actions bot temporarily deployed to preview-pr-3937 October 13, 2023 16:39 Destroyed
@sdadn sdadn merged commit c5833c8 into main Oct 13, 2023
21 checks passed
@sdadn sdadn deleted the fix_terra_icon_docs branch October 13, 2023 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants