Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop --eos-instance parameter #18

Open
robvalca opened this issue Mar 6, 2023 · 0 comments
Open

Drop --eos-instance parameter #18

robvalca opened this issue Mar 6, 2023 · 0 comments

Comments

@robvalca
Copy link
Collaborator

robvalca commented Mar 6, 2023 •
edited
Loading

This parameter is only used to populate an internal label called cluster. This functionality can be done anyways just adding a new label on the target definition in the prometheus server. We can drop this parameter completely as is also causing some confusion.
@robvalca robvalca changed the title Re-purpose --eos-instance parameter Drop --eos-instance parameter Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robvalca