Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile on node v9, which blocks upgrading on Arch Linux #426

Closed
maximbaz opened this issue Dec 4, 2017 · 9 comments · Fixed by #559
Closed

Unable to compile on node v9, which blocks upgrading on Arch Linux #426

maximbaz opened this issue Dec 4, 2017 · 9 comments · Fixed by #559

Comments

@maximbaz
Copy link
Contributor

maximbaz commented Dec 4, 2017

Arch Linux
yarn: 1.3.2
node: 9.2.0


Please follow exactly these steps (don't use repo that you had cloned before):

$ git clone https://github.com/KELiON/cerebro.git cerebro
$ cd cerebro
$ yarn
.....
$ cd app
$ yarn

Expected: both yarn runs succeed.
Actual: the second yarn fails.

❯ yarn
yarn install v1.3.2
[1/4] Resolving packages...
[2/4] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
[1/2] ⠄ ref:    ^~~~~~~~~~
[-/2] ⠄ waiting...
[-/2] ⠄ waiting...
[-/2] ⠄ waiting...
error /home/maximbaz/private/cerebro/app/node_modules/ref: Command failed.
Exit code: 1
..........
..........
..........
make: *** [binding.target.mk:95: Release/obj.target/binding/src/binding.o] Error 1
make: Leaving directory '/home/maximbaz/private/cerebro/app/node_modules/ref/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:159:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
gyp ERR! System Linux 4.13.12-1-ARCH
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/maximbaz/private/cerebro/app/node_modules/ref
@KELiON
Copy link
Collaborator

KELiON commented Dec 5, 2017

Can you double check that latest master doesn't work? I did small fix, maybe it is related. BTW, when I did a release everything was ok for me (using MacOS for that)

@maximbaz
Copy link
Contributor Author

maximbaz commented Dec 5, 2017

Just checked, exactly the same issue when cloning the repo from scratch. I'm hesitant to update AUR to 0.3.2 because everyone will start complaining because of this 🙂

@KELiON
Copy link
Collaborator

KELiON commented Dec 6, 2017

@maximbaz what version of node do you use? I could reproduce this issue on node 9.0.0, but everything is ok with v7.10.1. I

@maximbaz
Copy link
Contributor Author

maximbaz commented Dec 6, 2017

I have v9.2.0, Arch Linux ships the latest available version of all apps, so every Arch Linux user has node v9.2.0 and it's not something I can change... Let's fix Cerebro for node v9 🙂

@maximbaz maximbaz changed the title Unable to compile the current master if you clone repo from scratch Unable to compile on node v9, which blocks upgrading on Arch Linux Dec 6, 2017
@HoroTW
Copy link

HoroTW commented Jan 11, 2018

Any news? I would really like to get the new update ^^
(I can confirm it doesn't build on node 9)

@michaelwapp
Copy link

I can confirm that it doesn't build with arch and node 9, please update 👍

@FliiFe
Copy link
Contributor

FliiFe commented Mar 17, 2018

Any update ? #451 has a fix, why not implement it on the main repo ?

@mayankDhiman
Copy link

Any updates? It doesn't work with gnome & node 9. Also is there a simple workaround?

@AlanTheKnight
Copy link

Hey, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants