fix: avoid to stringify undefined query values as 'undefined' string

fix #23
cerebral · Mar 7, 2016 · 50ce97e · 50ce97e
1 parent c50b932
commit 50ce97e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -64,7 +64,7 @@ function compileRoute (route, options) {
               pathParams[key] = values[key]
           }
         } else {
-          queryParams[key] = values[key]
+          if (typeof values[key] !== 'undefined') queryParams[key] = values[key]
         }
       })
 

diff --git a/tests/test.js b/tests/test.js
@@ -339,6 +339,17 @@ module.exports = {
         test.done()
       },
 
+      'should not stringify undefined query params': function (test) {
+        var mapper = urlMapper({ query: true })
+
+        test.equal(mapper.stringify('/:foo', {
+          foo: 'bar',
+          bar: undefined
+        }), '/bar')
+
+        test.done()
+      },
+
       'should parse stringified object including params not defined in route': function (test) {
         var mapper = urlMapper({ query: true })
         var object = {