Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible compatibility issue with cerebral-module-devtools and this module #95

Closed
awei01 opened this issue Jun 18, 2016 · 1 comment · Fixed by #97
Closed

Possible compatibility issue with cerebral-module-devtools and this module #95

awei01 opened this issue Jun 18, 2016 · 1 comment · Fixed by #97

Comments

@awei01
Copy link

awei01 commented Jun 18, 2016

Example repo:
https://github.com/awei01/cerebral-devtools-router-test

Basic summary: When using the devtools and storing predefinedSignals, when refreshing the application, router parameters are not preserved in the URL.
@Guria
Copy link
Collaborator

Guria commented Jun 21, 2016

@awei01 great catch, thanks. it is not about devtools, but about changed way of passing signal info in [email protected]. Fix is on the way.

Guria added a commit that referenced this issue Jun 21, 2016
@Guria
fix: [email protected] event object support for predefined signals
810a66a 
fixes #95
@Guria Guria mentioned this issue Jun 21, 2016
Merged
Guria added a commit that referenced this issue Jun 21, 2016
@Guria
fix: [email protected] event object support for predefined signals
a69b327 
fixes #95
@Guria Guria closed this as completed in #97 Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Guria @awei01