EIP1559 #31
Merged
EIP1559 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ramilexe
changed the title
i-norden
reviewed
Nov 4, 2020
cmd/geth/misccmd.go
Outdated
| @@ -115,6 +115,7 @@ func version(ctx *cli.Context) error { | |||
| if gitDate != "" { | |||
| fmt.Println("Git Commit Date:", gitDate) | |||
| } | |||
| fmt.Println("EIP1559: 970c594cd3") | |||
There was a problem hiding this comment.
I think we should add this info to the version meta in addition to (or instead of) here
core/types/transaction.go
Outdated
| @@ -52,8 +53,8 @@ type txdata struct { | |||
| Payload []byte `json:"input" gencodec:"required"` | |||
|
|
|||
| // EIP1559 gas values | |||
| GasPremium *big.Int `json:"gasPremium" rlp:"nil"` // nil means legacy transaction | |||
| FeeCap *big.Int `json:"feeCap" rlp:"nil"` // nil means legacy transaction | |||
| MaxMinerBribePerGas *big.Int `json:"max_miner_bribe_per_gas" rlp:"nil"` | |||
There was a problem hiding this comment.
New JSON tags here and in other files should use camelCase
There was a problem hiding this comment.
max_miner_bribe_per_gas changed to maxMinerBribePerGas
fee_cap_per_gas changed to feeCapPerGas
n0cte
added a commit
that referenced
this pull request
Dec 4, 2020
* change transaction options, gasPremium to maxMinerBribePerGas * update fields for eth api * Update cost calculation for transaction * Change gasPremium to maxMinerBribePerGas * update baseFee calculation * fix gasprice calculation for StateTransition * fix fields for RPCTransaction * fix CalcBaseFee * fix transaction fields for test * add additional func computeBaseFee * fix baseFee values for TestCalcBaseFee * Fix transaction cost calculation * add infomation about eip version * use camelCase-style for json tags * remove eip info from "version"-command * update VesionMeta Co-authored-by: Ilnur Galiev <[email protected]>
n0cte
added a commit
that referenced
this pull request
Dec 11, 2020
* change transaction options, gasPremium to maxMinerBribePerGas * update fields for eth api * Update cost calculation for transaction * Change gasPremium to maxMinerBribePerGas * update baseFee calculation * fix gasprice calculation for StateTransition * fix fields for RPCTransaction * fix CalcBaseFee * fix transaction fields for test * add additional func computeBaseFee * fix baseFee values for TestCalcBaseFee * Fix transaction cost calculation * add infomation about eip version * use camelCase-style for json tags * remove eip info from "version"-command * update VesionMeta Co-authored-by: Ilnur Galiev <[email protected]>
n0cte
added a commit
that referenced
this pull request
Dec 11, 2020
* change transaction options, gasPremium to maxMinerBribePerGas * update fields for eth api * Update cost calculation for transaction * Change gasPremium to maxMinerBribePerGas * update baseFee calculation * fix gasprice calculation for StateTransition * fix fields for RPCTransaction * fix CalcBaseFee * fix transaction fields for test * add additional func computeBaseFee * fix baseFee values for TestCalcBaseFee * Fix transaction cost calculation * add infomation about eip version * use camelCase-style for json tags * remove eip info from "version"-command * update VesionMeta Co-authored-by: Ilnur Galiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.