Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'ceph-salt apply' looks strange with special characters if terminal is NOT in UTF-8 #369

Open
ricardoasmarques opened this issue Sep 4, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@ricardoasmarques
Copy link
Contributor

ricardoasmarques commented Sep 4, 2020

i.e. ISO-8859-1:1998 (Latin-1, West Europe):

image2020-7-29_15-27-57

@ricardoasmarques ricardoasmarques added the bug Something isn't working label Sep 4, 2020
@ricardoasmarques
Copy link
Contributor Author

ricardoasmarques commented Sep 4, 2020

I suggest to use "basic" chars:

  • / - | \ for animation, done, warn, and fail

Also, increase decrease the refresh rate to reduce "flickering".

@smithfarm
Copy link
Contributor

increase the refresh rate

Keep in mind that users may be running ceph-salt apply over an SSH connection.

@ricardoasmarques
Copy link
Contributor Author

increase the refresh rate

Keep in mind that users may be running ceph-salt apply over an SSH connection.

I wanted to say, "reduce the refresh rate"

@sebastian-philipp
Copy link
Contributor

do we really need to care about non utf-8 at this point? where did it appear?

@LenzGr
Copy link
Contributor

LenzGr commented Sep 9, 2020

Reducing priority. By now, most terminals should be using UTF-8 by default, but it would of course still be useful to gracefully fall back to less confusing characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants