Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum and not string for some GRPC fields #343

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

gbregman
Copy link
Contributor

Fixes #253

@gbregman gbregman force-pushed the devel branch 2 times, most recently from 1ea58f5 to bd1e76d Compare November 30, 2023 21:25
@gbregman gbregman requested a review from baum November 30, 2023 21:52
@gbregman gbregman self-assigned this Nov 30, 2023
control/cli.py Show resolved Hide resolved
control/cli.py Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
@gbregman gbregman requested review from barakda and removed request for baum December 3, 2023 09:26
@gbregman gbregman merged commit c6f6ce7 into ceph:devel Dec 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

String inputs in gRPC protos that require specific values should be enumerated instead
2 participants