Can we share VolumeLocks for NodeServer/ControllerServer?

[iPraveenParihar]

          lets discuss on this one and we need to see can what will happen when we try to do nodeserver operations like (expand/umount) etc when the fstrim is going on can it leads to corruption etc. based on that we can have central/shared locking. Is it allowed to expand or remove the image when the ControllerReclaimOperation is going on etc.

Originally posted by @Madhu-1 in #4641 (comment)

[nixpanic]

lets discuss on this one and we need to see can what will happen when we try to do nodeserver operations like (expand/umount) etc when the fstrim is going on can it leads to corruption etc. based on that we can have central/shared locking.

I do not think this can cause corruption. If so, it is a bug in the filesystem.

Is it allowed to expand or remove the image when the ControllerReclaimOperation is going on etc.

1. expanding should be allowed, but maybe RBD prevents running both operations at the same time?
2. while ControllerReclaim is running, the image is open, so deleting it may not be possible (and the CO should retry with backoff)

[Madhu-1]

lets discuss on this one and we need to see can what will happen when we try to do nodeserver operations like (expand/umount) etc when the fstrim is going on can it leads to corruption etc. based on that we can have central/shared locking.

I do not think this can cause corruption. If so, it is a bug in the filesystem.

Is it allowed to expand or remove the image when the ControllerReclaimOperation is going on etc.

1. expanding should be allowed, but maybe RBD prevents running both operations at the same time?
2. while ControllerReclaim is running, the image is open, so deleting it may not be possible (and the CO should retry with backoff)

@nixpanic yes once we test these things and decide letter on!

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

[iPraveenParihar]

decided to share locks #4641. closing this.