Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a cache of pool and FS information, for faster lookup, than calling Ceph commands each time #433

Closed
ShyamsundarR opened this issue Jun 14, 2019 · 3 comments
Labels
wontfix This will not be worked on

Comments

@ShyamsundarR
Copy link
Contributor

Currently in the code we fetch poolIDs, FscID each time it is required. This means calling into Ceph multiple times in the case of some requests (say create) or just fetching the same information repeatedly from Ceph across calls.

Instead, the enhancement proposed is to build a cache of pool names and IDs, and similarly for FSNames and it's IDs, for faster lookups.

This would help in quicker response times when creating/deleting PVs and also when mounting the same.

From an acceptance perspective, the solution should improve on existing creation/deletion/mount times of CephCSI across CephFS and RBD plugins.

One caveat to remember is that, as this is a cache, information can go stale. The risk is when a pool or a FSName is deleted and recreated with the same name, and hence its ID on Ceph changes, but this will not be detected by the cache. As a result this may need careful documentation and/or optionally be enabled for service time sensitive workloads.

@dillaman
Copy link

Note: this would be handled automatically as part of using native API calls since the MON maps are cached within the librados connection.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 4, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@stale stale bot closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants