From acc35b65777ace50e86bae55ab35176ea9c0839e Mon Sep 17 00:00:00 2001 From: Seena Fallah Date: Tue, 30 Jul 2024 22:11:55 +0200 Subject: [PATCH] devices: test devices before collecting on auto discovery In some scenarios with NVMe, a device might be identified by Ansible but could actually be a multipath device rather than an actual device. We need to exclude these as Ceph cannot create OSDs on them. Signed-off-by: Seena Fallah (cherry picked from commit be9b45852459434184b576d85ad80f505ee7ea3f) --- roles/ceph-facts/tasks/devices.yml | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/roles/ceph-facts/tasks/devices.yml b/roles/ceph-facts/tasks/devices.yml index ea20c252d5..95bd82a830 100644 --- a/roles/ceph-facts/tasks/devices.yml +++ b/roles/ceph-facts/tasks/devices.yml @@ -47,12 +47,13 @@ ansible.builtin.set_fact: bluestore_wal_devices: "{{ bluestore_wal_devices_prepare_canonicalize.results | map(attribute='stdout') | reject('search', '/dev/disk') | list | unique }}" -- name: Set_fact devices generate device list when osd_auto_discovery +- name: Collect existed devices vars: device: "{{ item.key | regex_replace('^', '/dev/') }}" - ansible.builtin.set_fact: - devices: "{{ devices | default([]) | union([device]) }}" - with_dict: "{{ ansible_facts['devices'] }}" + ansible.builtin.command: test -b {{ device }} + changed_when: false + ignore_errors: true + loop: "{{ ansible_facts['devices'] | dict2items }}" when: - osd_auto_discovery | default(False) | bool - ansible_facts['devices'] is defined @@ -65,3 +66,15 @@ - device not in dedicated_devices | default([]) - device not in bluestore_wal_devices | default([]) - device not in (lvm_volumes | default([]) | map(attribute='data') | list) + register: devices_check + +- name: Set_fact devices generate device list when osd_auto_discovery + vars: + device: "{{ item.item.key | regex_replace('^', '/dev/') }}" + ansible.builtin.set_fact: + devices: "{{ devices | default([]) | union([device]) }}" + loop: "{{ devices_check.results }}" + when: + - devices_check is defined + - not item.skipped | default(false) + - not item.failed | default(false)