From dc75923367de0c045284ecfbe6aad2862fa6a021 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Fri, 16 Feb 2024 01:16:55 +0100 Subject: [PATCH] drop iscsigw support This service is no longer maintained. Let's drop its support within ceph-ansible. Signed-off-by: Guillaume Abrioux --- CONTRIBUTING.md | 1 - Vagrantfile | 46 ----- contrib/vagrant_variables.yml.atomic | 1 - contrib/vagrant_variables.yml.linode | 1 - contrib/vagrant_variables.yml.openstack | 1 - dashboard.yml | 1 - docs/source/testing/scenarios.rst | 1 - generate_group_vars_sample.sh | 2 - group_vars/all.yml.sample | 74 -------- group_vars/iscsigws.yml.sample | 58 ------ group_vars/rhcs.yml.sample | 74 -------- infrastructure-playbooks/cephadm-adopt.yml | 70 +------- infrastructure-playbooks/cephadm.yml | 2 - infrastructure-playbooks/docker-to-podman.yml | 9 - infrastructure-playbooks/gather-ceph-logs.yml | 1 - infrastructure-playbooks/purge-cluster.yml | 4 - .../purge-iscsi-gateways.yml | 97 ---------- infrastructure-playbooks/rolling_update.yml | 58 ------ ...inerized-to-containerized-ceph-daemons.yml | 58 ------ .../take-over-existing-cluster.yml | 1 - library/igw_client.py | 135 -------------- library/igw_gateway.py | 145 --------------- library/igw_lun.py | 168 ------------------ library/igw_purge.py | 161 ----------------- plugins/callback/installer_checkpoint.py | 5 - rhcs_edits.txt | 1 - .../prerequisite_rhcs_cdn_install.yml | 1 - roles/ceph-config/tasks/main.yml | 1 - .../tasks/fetch_image.yml | 1 - .../tasks/configure_dashboard.yml | 32 ---- roles/ceph-defaults/defaults/main.yml | 74 -------- roles/ceph-facts/tasks/facts.yml | 5 - roles/ceph-handler/handlers/main.yml | 10 -- .../tasks/check_running_containers.yml | 24 --- .../tasks/check_socket_non_container.yml | 24 --- .../tasks/handler_rbd_target_api_gw.yml | 40 ----- .../tasks/handler_tcmu_runner.yml | 20 --- roles/ceph-infra/tasks/configure_firewall.yml | 45 ----- roles/ceph-infra/tasks/main.yml | 6 +- roles/ceph-infra/templates/logrotate.conf.j2 | 13 -- roles/ceph-iscsi-gw/LICENSE | 13 -- roles/ceph-iscsi-gw/README.md | 3 - roles/ceph-iscsi-gw/defaults/main.yml | 49 ----- roles/ceph-iscsi-gw/meta/main.yml | 14 -- roles/ceph-iscsi-gw/tasks/common.yml | 72 -------- roles/ceph-iscsi-gw/tasks/containerized.yml | 33 ---- roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml | 90 ---------- roles/ceph-iscsi-gw/tasks/main.yml | 28 --- .../tasks/non-container/configure_iscsi.yml | 33 ---- .../tasks/non-container/postrequisites.yml | 9 - .../tasks/non-container/prerequisites.yml | 90 ---------- roles/ceph-iscsi-gw/tasks/systemd.yml | 15 -- .../templates/iscsi-gateway.cfg.j2 | 30 ---- .../templates/rbd-target-api.service.j2 | 58 ------ .../templates/rbd-target-gw.service.j2 | 58 ------ .../templates/tcmu-runner.service.j2 | 58 ------ .../templates/prometheus.yml.j2 | 9 - roles/ceph-validate/tasks/check_iscsi.yml | 42 ----- roles/ceph-validate/tasks/main.yml | 4 - site-container.yml.sample | 41 ----- site.yml.sample | 40 ----- tests/conftest.py | 6 +- .../add-mdss/container/vagrant_variables.yml | 1 - .../functional/add-mdss/vagrant_variables.yml | 1 - .../add-mgrs/container/vagrant_variables.yml | 1 - .../functional/add-mgrs/vagrant_variables.yml | 1 - .../add-mons/container/vagrant_variables.yml | 1 - .../functional/add-mons/vagrant_variables.yml | 1 - .../add-osds/container/vagrant_variables.yml | 1 - .../functional/add-osds/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../add-rbdmirrors/vagrant_variables.yml | 1 - .../add-rgws/container/vagrant_variables.yml | 1 - .../functional/add-rgws/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../all-in-one/vagrant_variables.yml | 1 - tests/functional/all_daemons/container/hosts | 3 - .../container/vagrant_variables.yml | 1 - tests/functional/all_daemons/hosts | 3 - .../all_daemons/vagrant_variables.yml | 1 - .../all_daemons_ipv6/container/hosts | 3 - .../container/vagrant_variables.yml | 1 - tests/functional/all_daemons_ipv6/hosts | 3 - .../all_daemons_ipv6/vagrant_variables.yml | 1 - tests/functional/cephadm/hosts | 3 - .../functional/cephadm/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../collocation/vagrant_variables.yml | 1 - .../docker2podman/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../external_clients/vagrant_variables.yml | 1 - .../infra_lv_create/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../lvm-auto-discovery/vagrant_variables.yml | 1 - .../lvm-batch/container/vagrant_variables.yml | 1 - .../lvm-batch/vagrant_variables.yml | 1 - .../lvm-osds/container/vagrant_variables.yml | 1 - .../functional/lvm-osds/vagrant_variables.yml | 1 - .../vagrant_variables.yml | 1 - .../ooo-collocation/vagrant_variables.yml | 1 - tests/functional/podman/hosts | 3 - tests/functional/podman/vagrant_variables.yml | 1 - .../container/secondary/vagrant_variables.yml | 1 - .../rbdmirror/container/vagrant_variables.yml | 1 - .../rbdmirror/secondary/vagrant_variables.yml | 1 - .../rbdmirror/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../shrink_mds/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../shrink_mgr/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../shrink_mon/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../shrink_osd/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../shrink_rbdmirror/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../shrink_rgw/vagrant_variables.yml | 1 - .../container/vagrant_variables.yml | 1 - .../subset_update/vagrant_variables.yml | 1 - tests/functional/tests/iscsi/__init__.py | 0 tests/functional/tests/iscsi/test_iscsi.py | 23 --- tests/pytest.ini | 1 - vagrant_variables.yml.sample | 1 - 124 files changed, 5 insertions(+), 2356 deletions(-) delete mode 100644 group_vars/iscsigws.yml.sample delete mode 100644 infrastructure-playbooks/purge-iscsi-gateways.yml delete mode 100644 library/igw_client.py delete mode 100644 library/igw_gateway.py delete mode 100644 library/igw_lun.py delete mode 100644 library/igw_purge.py delete mode 100644 roles/ceph-handler/tasks/handler_rbd_target_api_gw.yml delete mode 100644 roles/ceph-handler/tasks/handler_tcmu_runner.yml delete mode 100644 roles/ceph-iscsi-gw/LICENSE delete mode 100644 roles/ceph-iscsi-gw/README.md delete mode 100644 roles/ceph-iscsi-gw/defaults/main.yml delete mode 100644 roles/ceph-iscsi-gw/meta/main.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/common.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/containerized.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/main.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/non-container/configure_iscsi.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/non-container/postrequisites.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml delete mode 100644 roles/ceph-iscsi-gw/tasks/systemd.yml delete mode 100644 roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2 delete mode 100644 roles/ceph-iscsi-gw/templates/rbd-target-api.service.j2 delete mode 100644 roles/ceph-iscsi-gw/templates/rbd-target-gw.service.j2 delete mode 100644 roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2 delete mode 100644 roles/ceph-validate/tasks/check_iscsi.yml delete mode 100644 tests/functional/tests/iscsi/__init__.py delete mode 100644 tests/functional/tests/iscsi/test_iscsi.py diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 81f7ee46f3..dda72f50a5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -66,7 +66,6 @@ It means if you are pushing a patch modifying one of these files: - `./roles/ceph-nfs/defaults/main.yml` - `./roles/ceph-client/defaults/main.yml` - `./roles/ceph-common/defaults/main.yml` -- `./roles/ceph-iscsi-gw/defaults/main.yml` - `./roles/ceph-mon/defaults/main.yml` - `./roles/ceph-rgw/defaults/main.yml` - `./roles/ceph-container-common/defaults/main.yml` diff --git a/Vagrantfile b/Vagrantfile index 17f24a18c8..dde4b30893 100644 --- a/Vagrantfile +++ b/Vagrantfile @@ -24,7 +24,6 @@ NNFSS = settings['nfs_vms'] GRAFANA = settings['grafana_server_vms'] NRBD_MIRRORS = settings['rbd_mirror_vms'] CLIENTS = settings['client_vms'] -NISCSI_GWS = settings['iscsi_gw_vms'] MGRS = settings['mgr_vms'] PUBLIC_SUBNET = settings['public_subnet'] CLUSTER_SUBNET = settings['cluster_subnet'] @@ -67,7 +66,6 @@ ansible_provision = proc do |ansible| 'nfss' => (0..NNFSS - 1).map { |j| "#{LABEL_PREFIX}nfs#{j}" }, 'rbd_mirrors' => (0..NRBD_MIRRORS - 1).map { |j| "#{LABEL_PREFIX}rbd_mirror#{j}" }, 'clients' => (0..CLIENTS - 1).map { |j| "#{LABEL_PREFIX}client#{j}" }, - 'iscsigws' => (0..NISCSI_GWS - 1).map { |j| "#{LABEL_PREFIX}iscsi_gw#{j}" }, 'mgrs' => (0..MGRS - 1).map { |j| "#{LABEL_PREFIX}mgr#{j}" }, 'monitoring' => (0..GRAFANA - 1).map { |j| "#{LABEL_PREFIX}grafana#{j}" } } @@ -560,50 +558,6 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| end end - (0..NISCSI_GWS - 1).each do |i| - config.vm.define "#{LABEL_PREFIX}iscsi-gw#{i}" do |iscsi_gw| - iscsi_gw.vm.hostname = "#{LABEL_PREFIX}iscsi-gw#{i}" - if ASSIGN_STATIC_IP && !IPV6 - iscsi_gw.vm.network :private_network, - :ip => "#{PUBLIC_SUBNET}.#{$last_ip_pub_digit+=1}" - end - # Virtualbox - iscsi_gw.vm.provider :virtualbox do |vb| - vb.customize ['modifyvm', :id, '--memory', "#{MEMORY}"] - end - - # VMware - iscsi_gw.vm.provider :vmware_fusion do |v| - v.vmx['memsize'] = "#{MEMORY}" - end - - # Libvirt - iscsi_gw.vm.provider :libvirt do |lv,override| - lv.memory = MEMORY - lv.random_hostname = true - if IPV6 then - override.vm.network :private_network, - :libvirt__ipv6_address => "#{PUBLIC_SUBNET}", - :libvirt__ipv6_prefix => "64", - :libvirt__dhcp_enabled => false, - :libvirt__forward_mode => "veryisolated", - :libvirt__network_name => "ipv6-public-network", - :ip => "#{PUBLIC_SUBNET}#{$last_ip_pub_digit+=1}", - :netmask => "64" - end - end - # Parallels - iscsi_gw.vm.provider "parallels" do |prl| - prl.name = "iscsi-gw#{i}" - prl.memory = "#{MEMORY}" - end - - iscsi_gw.vm.provider :linode do |provider| - provider.label = iscsi_gw.vm.hostname - end - end - end - (0..NOSDS - 1).each do |i| config.vm.define "#{LABEL_PREFIX}osd#{i}" do |osd| osd.vm.hostname = "#{LABEL_PREFIX}osd#{i}" diff --git a/contrib/vagrant_variables.yml.atomic b/contrib/vagrant_variables.yml.atomic index ef4803233b..3adff7a882 100644 --- a/contrib/vagrant_variables.yml.atomic +++ b/contrib/vagrant_variables.yml.atomic @@ -10,7 +10,6 @@ rgw_vms: 0 nfs_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/contrib/vagrant_variables.yml.linode b/contrib/vagrant_variables.yml.linode index 54197c9949..e62a3bffee 100644 --- a/contrib/vagrant_variables.yml.linode +++ b/contrib/vagrant_variables.yml.linode @@ -27,7 +27,6 @@ rgw_vms: 0 nfs_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 # The sync directory changes based on vagrant box # Set to /home/vagrant/sync for Centos/7, /home/{ user }/vagrant for openstack and defaults to /vagrant diff --git a/contrib/vagrant_variables.yml.openstack b/contrib/vagrant_variables.yml.openstack index 922e7c44d1..420c09c98d 100644 --- a/contrib/vagrant_variables.yml.openstack +++ b/contrib/vagrant_variables.yml.openstack @@ -11,7 +11,6 @@ rgw_vms: 0 nfs_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 # SUBNET TO USE FOR THE VMS # Use whatever private subnet your Openstack VMs are given diff --git a/dashboard.yml b/dashboard.yml index e022fa81d9..e998e1e539 100644 --- a/dashboard.yml +++ b/dashboard.yml @@ -8,7 +8,6 @@ - "{{ mgr_group_name|default('mgrs') }}" - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" gather_facts: false become: true diff --git a/docs/source/testing/scenarios.rst b/docs/source/testing/scenarios.rst index 4037e18792..185f994633 100644 --- a/docs/source/testing/scenarios.rst +++ b/docs/source/testing/scenarios.rst @@ -50,7 +50,6 @@ to follow (most of them are 1 line settings). nfs_vms: 0 rbd_mirror_vms: 0 client_vms: 0 - iscsi_gw_vms: 0 mgr_vms: 0 For a deployment that needs 1 MON and 1 OSD, the list would look like: diff --git a/generate_group_vars_sample.sh b/generate_group_vars_sample.sh index eda9b339b5..af5cc0554b 100755 --- a/generate_group_vars_sample.sh +++ b/generate_group_vars_sample.sh @@ -66,8 +66,6 @@ for role in "$basedir"/roles/ceph-*; do output="ceph-fetch-keys.yml.sample" elif [[ $rolename == "ceph-rbd-mirror" ]]; then output="rbdmirrors.yml.sample" - elif [[ $rolename == "ceph-iscsi-gw" ]]; then - output="iscsigws.yml.sample" elif [[ $rolename == "ceph-rgw-loadbalancer" ]]; then output="rgwloadbalancers.yml.sample" else diff --git a/group_vars/all.yml.sample b/group_vars/all.yml.sample index 22ba3fe6db..bb91df2104 100644 --- a/group_vars/all.yml.sample +++ b/group_vars/all.yml.sample @@ -54,7 +54,6 @@ dummy: #nfs_group_name: nfss #rbdmirror_group_name: rbdmirrors #client_group_name: clients -#iscsi_gw_group_name: iscsigws #mgr_group_name: mgrs #rgwloadbalancer_group_name: rgwloadbalancers #monitoring_group_name: monitoring @@ -66,7 +65,6 @@ dummy: # - "{{ nfs_group_name }}" # - "{{ rbdmirror_group_name }}" # - "{{ client_group_name }}" -# - "{{ iscsi_gw_group_name }}" # - "{{ mgr_group_name }}" # - "{{ rgwloadbalancer_group_name }}" # - "{{ monitoring_group_name }}" @@ -84,7 +82,6 @@ dummy: #ceph_mds_firewall_zone: public #ceph_nfs_firewall_zone: public #ceph_rbdmirror_firewall_zone: public -#ceph_iscsi_firewall_zone: public #ceph_dashboard_firewall_zone: public #ceph_rgwloadbalancer_firewall_zone: public @@ -218,8 +215,6 @@ dummy: # flavors so far include: ceph_main, ceph_jewel, ceph_kraken, ceph_luminous #nfs_ganesha_flavor: "ceph_main" -#ceph_iscsi_config_dev: true # special repo for deploying iSCSI gateways - # REPOSITORY: CUSTOM # @@ -703,75 +698,6 @@ dummy: #alertmanager_cluster_port: 9094 #alertmanager_conf_overrides: {} #alertmanager_dashboard_api_no_ssl_verify: "{{ true if dashboard_protocol == 'https' and not dashboard_crt and not dashboard_key else false }}" -# igw -# -# `igw_network` variable is intended for allowing dashboard deployment with iSCSI node not residing in the same subnet than what is defined in `public_network`. -# For example: -# If the ceph public network is 2a00:8a60:1:c301::/64 and the iSCSI Gateway resides -# at a dedicated gateway network (2a00:8a60:1:c300::/64) (With routing between those networks). -# It means "{{ hostvars[item]['ansible_facts']['all_ipv4_addresses'] | ips_in_ranges(public_network.split(',')) | last | ansible.utils.ipwrap }}" will be empty. -# As a consequence, this prevent from deploying dashboard with iSCSI node when it reside in a subnet different than `public_network`. -# Using `igw_network` make it possible, set it with the subnet used by your iSCSI node. -#igw_network: "{{ public_network }}" - - -################################## -# DEPRECIATED iSCSI TARGET SETUP # -################################## - -# WARNING # - -# The following values are depreciated. To setup targets, gateways, LUNs, and -# clients you should use gwcli or dashboard. If the following values are set, -# the old ceph-iscsi-config/ceph-iscsi-cli packages will be used. - -# Specify the iqn for ALL gateways. This iqn is shared across the gateways, so an iscsi -# client sees the gateway group as a single storage subsystem. -#gateway_iqn: "" - -# gateway_ip_list provides a list of the IP Addrresses - one per gateway - that will be used -# as an iscsi target portal ip. The list must be comma separated - and the order determines -# the sequence of TPG's within the iscsi target across each gateway. Once set, additional -# gateways can be added, but the order must *not* be changed. -#gateway_ip_list: 0.0.0.0 - -# rbd_devices defines the images that should be created and exported from the iscsi gateways. -# If the rbd does not exist, it will be created for you. In addition you may increase the -# size of rbd's by changing the size parameter and rerunning the playbook. A size value lower -# than the current size of the rbd is ignored. -# -# the 'host' parameter defines which of the gateway nodes should handle the physical -# allocation/expansion or removal of the rbd -# to remove an image, simply use a state of 'absent'. This will first check the rbd is not allocated -# to any client, and the remove it from LIO and then delete the rbd image -# -# NB. this variable definition can be commented out to bypass LUN management -# -# Example: -# -# rbd_devices: -# - { pool: 'rbd', image: 'ansible1', size: '30G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible2', size: '15G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible3', size: '30G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible4', size: '50G', host: 'ceph-1', state: 'present' } -#rbd_devices: {} - -# client_connections defines the client ACL's to restrict client access to specific LUNs -# The settings are as follows; -# - image_list is a comma separated list of rbd images of the form . -# - chap supplies the user and password the client will use for authentication of the -# form / -# - status shows the intended state of this client definition - 'present' or 'absent' -# -# NB. this definition can be commented out to skip client (nodeACL) management -# -# Example: -# -# client_connections: -# - { client: 'iqn.1994-05.com.redhat:rh7-iscsi-client', image_list: 'rbd.ansible1,rbd.ansible2', chap: 'rh7-iscsi-client/redhat', status: 'present' } -# - { client: 'iqn.1991-05.com.microsoft:w2k12r2', image_list: 'rbd.ansible4', chap: 'w2k12r2/microsoft_w2k12', status: 'absent' } - -#client_connections: {} #no_log_on_ceph_key_tasks: true diff --git a/group_vars/iscsigws.yml.sample b/group_vars/iscsigws.yml.sample deleted file mode 100644 index 59ab5e1917..0000000000 --- a/group_vars/iscsigws.yml.sample +++ /dev/null @@ -1,58 +0,0 @@ ---- -# Variables here are applicable to all host groups NOT roles - -# This sample file generated by generate_group_vars_sample.sh - -# Dummy variable to avoid error because ansible does not recognize the -# file as a good configuration file when no variable in it. -dummy: - -# You can override vars by using host or group vars - -########### -# GENERAL # -########### -# Whether or not to generate secure certificate to iSCSI gateway nodes -#generate_crt: false - -#iscsi_conf_overrides: {} -#iscsi_pool_name: rbd -# iscsi_pool_size: 3 - -#copy_admin_key: true - -################## -# RBD-TARGET-API # -################## -# Optional settings related to the CLI/API service -#api_user: admin -#api_password: admin -#api_port: 5000 -#api_secure: false -#loop_delay: 1 -# set the variable below with a comma separated list of IPs -# in order to restrict the access to the iSCSI API -# trusted_ip_list: 192.168.122.1 - - -########## -# DOCKER # -########## - -# Resource limitation -# For the whole list of limits you can apply see: docs.docker.com/engine/admin/resource_constraints -# Default values are based from: https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/2/html/red_hat_ceph_storage_hardware_guide/minimum_recommendations -# These options can be passed using the 'ceph_mds_docker_extra_env' variable. - -# TCMU_RUNNER resource limitation -#ceph_tcmu_runner_docker_memory_limit: "{{ ansible_facts['memtotal_mb'] }}m" -#ceph_tcmu_runner_docker_cpu_limit: 1 - -# RBD_TARGET_GW resource limitation -#ceph_rbd_target_gw_docker_memory_limit: "{{ ansible_facts['memtotal_mb'] }}m" -#ceph_rbd_target_gw_docker_cpu_limit: 1 - -# RBD_TARGET_API resource limitation -#ceph_rbd_target_api_docker_memory_limit: "{{ ansible_facts['memtotal_mb'] }}m" -#ceph_rbd_target_api_docker_cpu_limit: 1 - diff --git a/group_vars/rhcs.yml.sample b/group_vars/rhcs.yml.sample index 8d18aec6a2..0a002f2620 100644 --- a/group_vars/rhcs.yml.sample +++ b/group_vars/rhcs.yml.sample @@ -54,7 +54,6 @@ dummy: #nfs_group_name: nfss #rbdmirror_group_name: rbdmirrors #client_group_name: clients -#iscsi_gw_group_name: iscsigws #mgr_group_name: mgrs #rgwloadbalancer_group_name: rgwloadbalancers #monitoring_group_name: monitoring @@ -66,7 +65,6 @@ dummy: # - "{{ nfs_group_name }}" # - "{{ rbdmirror_group_name }}" # - "{{ client_group_name }}" -# - "{{ iscsi_gw_group_name }}" # - "{{ mgr_group_name }}" # - "{{ rgwloadbalancer_group_name }}" # - "{{ monitoring_group_name }}" @@ -84,7 +82,6 @@ dummy: #ceph_mds_firewall_zone: public #ceph_nfs_firewall_zone: public #ceph_rbdmirror_firewall_zone: public -#ceph_iscsi_firewall_zone: public #ceph_dashboard_firewall_zone: public #ceph_rgwloadbalancer_firewall_zone: public @@ -218,8 +215,6 @@ ceph_rhcs_version: 5 # flavors so far include: ceph_main, ceph_jewel, ceph_kraken, ceph_luminous #nfs_ganesha_flavor: "ceph_main" -ceph_iscsi_config_dev: false - # REPOSITORY: CUSTOM # @@ -703,75 +698,6 @@ alertmanager_container_image: registry.redhat.io/openshift4/ose-prometheus-alert #alertmanager_cluster_port: 9094 #alertmanager_conf_overrides: {} #alertmanager_dashboard_api_no_ssl_verify: "{{ true if dashboard_protocol == 'https' and not dashboard_crt and not dashboard_key else false }}" -# igw -# -# `igw_network` variable is intended for allowing dashboard deployment with iSCSI node not residing in the same subnet than what is defined in `public_network`. -# For example: -# If the ceph public network is 2a00:8a60:1:c301::/64 and the iSCSI Gateway resides -# at a dedicated gateway network (2a00:8a60:1:c300::/64) (With routing between those networks). -# It means "{{ hostvars[item]['ansible_facts']['all_ipv4_addresses'] | ips_in_ranges(public_network.split(',')) | last | ansible.utils.ipwrap }}" will be empty. -# As a consequence, this prevent from deploying dashboard with iSCSI node when it reside in a subnet different than `public_network`. -# Using `igw_network` make it possible, set it with the subnet used by your iSCSI node. -#igw_network: "{{ public_network }}" - - -################################## -# DEPRECIATED iSCSI TARGET SETUP # -################################## - -# WARNING # - -# The following values are depreciated. To setup targets, gateways, LUNs, and -# clients you should use gwcli or dashboard. If the following values are set, -# the old ceph-iscsi-config/ceph-iscsi-cli packages will be used. - -# Specify the iqn for ALL gateways. This iqn is shared across the gateways, so an iscsi -# client sees the gateway group as a single storage subsystem. -#gateway_iqn: "" - -# gateway_ip_list provides a list of the IP Addrresses - one per gateway - that will be used -# as an iscsi target portal ip. The list must be comma separated - and the order determines -# the sequence of TPG's within the iscsi target across each gateway. Once set, additional -# gateways can be added, but the order must *not* be changed. -#gateway_ip_list: 0.0.0.0 - -# rbd_devices defines the images that should be created and exported from the iscsi gateways. -# If the rbd does not exist, it will be created for you. In addition you may increase the -# size of rbd's by changing the size parameter and rerunning the playbook. A size value lower -# than the current size of the rbd is ignored. -# -# the 'host' parameter defines which of the gateway nodes should handle the physical -# allocation/expansion or removal of the rbd -# to remove an image, simply use a state of 'absent'. This will first check the rbd is not allocated -# to any client, and the remove it from LIO and then delete the rbd image -# -# NB. this variable definition can be commented out to bypass LUN management -# -# Example: -# -# rbd_devices: -# - { pool: 'rbd', image: 'ansible1', size: '30G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible2', size: '15G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible3', size: '30G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible4', size: '50G', host: 'ceph-1', state: 'present' } -#rbd_devices: {} - -# client_connections defines the client ACL's to restrict client access to specific LUNs -# The settings are as follows; -# - image_list is a comma separated list of rbd images of the form . -# - chap supplies the user and password the client will use for authentication of the -# form / -# - status shows the intended state of this client definition - 'present' or 'absent' -# -# NB. this definition can be commented out to skip client (nodeACL) management -# -# Example: -# -# client_connections: -# - { client: 'iqn.1994-05.com.redhat:rh7-iscsi-client', image_list: 'rbd.ansible1,rbd.ansible2', chap: 'rh7-iscsi-client/redhat', status: 'present' } -# - { client: 'iqn.1991-05.com.microsoft:w2k12r2', image_list: 'rbd.ansible4', chap: 'w2k12r2/microsoft_w2k12', status: 'absent' } - -#client_connections: {} #no_log_on_ceph_key_tasks: true diff --git a/infrastructure-playbooks/cephadm-adopt.yml b/infrastructure-playbooks/cephadm-adopt.yml index f28e42444d..1fb2aabeff 100644 --- a/infrastructure-playbooks/cephadm-adopt.yml +++ b/infrastructure-playbooks/cephadm-adopt.yml @@ -42,7 +42,6 @@ - "{{ mgr_group_name|default('mgrs') }}" - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" become: true any_errors_fatal: true @@ -158,7 +157,6 @@ inventory_hostname in groups.get(rgw_group_name, []) or inventory_hostname in groups.get(mgr_group_name, []) or inventory_hostname in groups.get(rbdmirror_group_name, []) or - inventory_hostname in groups.get(iscsi_gw_group_name, []) or inventory_hostname in groups.get(nfs_group_name, []) - name: Configure repository for installing cephadm @@ -448,9 +446,7 @@ inventory_hostname in groups.get(mds_group_name, []) or inventory_hostname in groups.get(rgw_group_name, []) or inventory_hostname in groups.get(mgr_group_name, []) or - inventory_hostname in groups.get(rbdmirror_group_name, []) or - inventory_hostname in groups.get(iscsi_gw_group_name, []) - + inventory_hostname in groups.get(rbdmirror_group_name, []) - name: Store existing rbd mirror peers in monitor config store hosts: "{{ rbdmirror_group_name|default('rbdmirrors') }}" @@ -636,69 +632,6 @@ - /etc/systemd/system/ceph-mgr@.service.d - /etc/systemd/system/ceph-mgr.target - -- name: Stop and remove legacy iscsigw daemons - hosts: "{{ iscsi_gw_group_name|default('iscsigws') }}" - serial: 1 - become: true - gather_facts: false - any_errors_fatal: true - tasks: - - name: Import ceph-defaults role - ansible.builtin.import_role: - name: ceph-defaults - - - name: Stop and disable iscsigw systemd services - ansible.builtin.service: - name: '{{ item }}' - state: stopped - enabled: false - failed_when: false - with_items: - - rbd-target-api - - rbd-target-gw - - tcmu-runner - - - name: Reset failed iscsigw systemd units - ansible.builtin.command: 'systemctl reset-failed {{ item }}' # noqa command-instead-of-module - changed_when: false - failed_when: false - with_items: - - rbd-target-api - - rbd-target-gw - - tcmu-runner - when: containerized_deployment | bool - - - name: Remove iscsigw systemd unit files - ansible.builtin.file: - path: '/etc/systemd/system/{{ item }}.service' - state: absent - with_items: - - rbd-target-api - - rbd-target-gw - - tcmu-runner - when: containerized_deployment | bool - - -- name: Redeploy iscsigw daemons - hosts: "{{ iscsi_gw_group_name|default('iscsigws') }}" - become: true - gather_facts: false - any_errors_fatal: true - tasks: - - name: Import ceph-defaults role - ansible.builtin.import_role: - name: ceph-defaults - - - name: Update the placement of iscsigw hosts - ansible.builtin.command: "{{ cephadm_cmd }} shell -k /etc/ceph/{{ cluster }}.client.admin.keyring --fsid {{ fsid }} -- ceph orch apply iscsi {{ iscsi_pool_name | default('rbd') }} {{ api_user | default('admin') }} {{ api_password | default('admin') }} {{ trusted_ip_list | default('192.168.122.1') }} --placement='{{ groups.get(iscsi_gw_group_name, []) | length }} label:{{ iscsi_gw_group_name }}'" - run_once: true - changed_when: false - delegate_to: '{{ groups[mon_group_name][0] }}' - environment: - CEPHADM_IMAGE: '{{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }}' - - - name: Set osd flags hosts: "{{ osd_group_name|default('osds') }}" become: true @@ -1434,7 +1367,6 @@ - "{{ mgr_group_name|default('mgrs') }}" - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" become: true gather_facts: false diff --git a/infrastructure-playbooks/cephadm.yml b/infrastructure-playbooks/cephadm.yml index 6a8612a615..eae68da436 100644 --- a/infrastructure-playbooks/cephadm.yml +++ b/infrastructure-playbooks/cephadm.yml @@ -8,7 +8,6 @@ - "{{ mgr_group_name|default('mgrs') }}" - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" become: true gather_facts: false @@ -219,7 +218,6 @@ - "{{ mgr_group_name|default('mgrs') }}" - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" become: true gather_facts: false diff --git a/infrastructure-playbooks/docker-to-podman.yml b/infrastructure-playbooks/docker-to-podman.yml index 0367da1403..b40363d503 100644 --- a/infrastructure-playbooks/docker-to-podman.yml +++ b/infrastructure-playbooks/docker-to-podman.yml @@ -14,7 +14,6 @@ - nfss - rbdmirrors - clients - - iscsigws - mgrs - monitoring @@ -63,7 +62,6 @@ - "{{ rgw_group_name | default('rgws') }}" - "{{ nfs_group_name | default('nfss') }}" - "{{ mgr_group_name | default('mgrs') }}" - - "{{ iscsi_gw_group_name | default('iscsigws') }}" - "{{ rbdmirror_group_name | default('rbdmirrors') }}" - "{{ monitoring_group_name | default('monitoring') }}" gather_facts: false @@ -117,7 +115,6 @@ inventory_hostname in groups.get(rgw_group_name, []) or inventory_hostname in groups.get(mgr_group_name, []) or inventory_hostname in groups.get(rbdmirror_group_name, []) or - inventory_hostname in groups.get(iscsi_gw_group_name, []) or inventory_hostname in groups.get(nfs_group_name, []) - name: Pulling alertmanager/grafana/prometheus images from docker daemon @@ -150,12 +147,6 @@ tasks_from: systemd.yml when: inventory_hostname in groups.get(mon_group_name, []) - - name: Import ceph-iscsi-gw role - ansible.builtin.import_role: - name: ceph-iscsi-gw - tasks_from: systemd.yml - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - - name: Import ceph-mds role ansible.builtin.import_role: name: ceph-mds diff --git a/infrastructure-playbooks/gather-ceph-logs.yml b/infrastructure-playbooks/gather-ceph-logs.yml index 9efcf97e87..ede64e5269 100644 --- a/infrastructure-playbooks/gather-ceph-logs.yml +++ b/infrastructure-playbooks/gather-ceph-logs.yml @@ -9,7 +9,6 @@ - rbdmirrors - clients - mgrs - - iscsigws gather_facts: false become: true diff --git a/infrastructure-playbooks/purge-cluster.yml b/infrastructure-playbooks/purge-cluster.yml index 878c2e5a20..6f7a378410 100644 --- a/infrastructure-playbooks/purge-cluster.yml +++ b/infrastructure-playbooks/purge-cluster.yml @@ -149,7 +149,6 @@ - clients - mgrs - monitoring - - iscsigws become: true tasks: - name: Import ceph-defaults role @@ -1065,9 +1064,6 @@ paths: /run patterns: - "ceph-*.service-cid" - - "rbd-target-api.service-cid" - - "rbd-target-gw.service-cid" - - "tcmu-runner.service-cid" - "node_exporter.service-cid" - "prometheus.service-cid" - "grafana-server.service-cid" diff --git a/infrastructure-playbooks/purge-iscsi-gateways.yml b/infrastructure-playbooks/purge-iscsi-gateways.yml deleted file mode 100644 index dd6009cc8a..0000000000 --- a/infrastructure-playbooks/purge-iscsi-gateways.yml +++ /dev/null @@ -1,97 +0,0 @@ ---- -- name: Confirm removal of the iSCSI gateway configuration - hosts: localhost - - vars_prompt: - - name: purge_config # noqa: name[casing] - prompt: Which configuration elements should be purged? (all, lio or abort) - default: 'abort' - private: false - - tasks: - - name: Exit playbook if user aborted the purge - ansible.builtin.fail: - msg: > - "You have aborted the purge of the iSCSI gateway configuration" - when: purge_config == 'abort' - - - name: Set_fact igw_purge_type - ansible.builtin.set_fact: - igw_purge_type: "{{ purge_config }}" - -- name: Stopping the gateways - hosts: - - iscsigws - become: true - tasks: - - name: Stopping and disabling iscsi daemons - ansible.builtin.service: - name: "{{ item }}" - state: stopped - enabled: false - with_items: - - rbd-target-gw - - rbd-target-api - - tcmu-runner - -- name: Removing the gateway configuration - hosts: - - iscsigws - become: true - vars: - igw_purge_type: "{{ hostvars['localhost']['igw_purge_type'] }}" - - tasks: - - name: Igw_purge | deleting configured rbd devices - igw_purge: - mode: "disks" - when: igw_purge_type == 'all' - run_once: true - - - name: Igw_purge | purging the gateway configuration - igw_purge: - mode: "gateway" - run_once: true - - - name: Restart and enable iscsi daemons - when: igw_purge_type == 'lio' - ansible.builtin.service: - name: "{{ item }}" - state: started - enabled: true - with_items: - - tcmu-runner - - rbd-target-api - - rbd-target-gw - -- name: Remove the gateways from the ceph dashboard - hosts: mons - become: true - tasks: - - name: Import ceph-defaults role - ansible.builtin.import_role: - name: ceph-defaults - - - name: Iscsi gateways with ceph dashboard - when: dashboard_enabled | bool - run_once: true - block: - - name: Import ceph-facts role - ansible.builtin.import_role: - name: ceph-facts - tasks_from: container_binary - - - name: Set_fact container_exec_cmd - ansible.builtin.set_fact: - container_exec_cmd: "{{ container_binary }} exec ceph-mon-{{ ansible_facts['hostname'] }}" - when: containerized_deployment | bool - - - name: Get iscsi gateway list - ansible.builtin.command: "{{ container_exec_cmd | default('') }} ceph --cluster {{ cluster }} dashboard iscsi-gateway-list -f json" - changed_when: false - register: gateways - - - name: Remove iscsi gateways - ansible.builtin.command: "{{ container_exec_cmd | default('') }} ceph --cluster {{ cluster }} dashboard iscsi-gateway-rm {{ item }}" - with_items: '{{ (gateways.stdout | from_json)["gateways"] }}' - changed_when: false diff --git a/infrastructure-playbooks/rolling_update.yml b/infrastructure-playbooks/rolling_update.yml index 31ca428a9f..24b51f340e 100644 --- a/infrastructure-playbooks/rolling_update.yml +++ b/infrastructure-playbooks/rolling_update.yml @@ -57,7 +57,6 @@ - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - "{{ client_group_name|default('clients') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" tags: always any_errors_fatal: true @@ -1075,62 +1074,6 @@ ansible.builtin.import_role: name: ceph-nfs - -- name: Upgrade ceph iscsi gateway node - vars: - upgrade_ceph_packages: true - hosts: "{{ iscsi_gw_group_name|default('iscsigws') }}" - tags: iscsigws - serial: 1 - become: true - gather_facts: false - tasks: - # failed_when: false is here so that if we upgrade - # from a version of ceph that does not have iscsi gws - # then this task will not fail - - name: Stop ceph iscsi services - ansible.builtin.systemd: - name: '{{ item }}' - state: stopped - enabled: false - masked: true - failed_when: false - with_items: - - rbd-target-api - - rbd-target-gw - - tcmu-runner - - - name: Import ceph-defaults role - ansible.builtin.import_role: - name: ceph-defaults - - - name: Import ceph-facts role - ansible.builtin.import_role: - name: ceph-facts - - - name: Import ceph-handler role - ansible.builtin.import_role: - name: ceph-handler - - - name: Import ceph-common role - ansible.builtin.import_role: - name: ceph-common - when: not containerized_deployment | bool - - - name: Import ceph-container-common role - ansible.builtin.import_role: - name: ceph-container-common - when: containerized_deployment | bool - - - name: Import ceph-config role - ansible.builtin.import_role: - name: ceph-config - - - name: Import ceph-iscsi-gw role - ansible.builtin.import_role: - name: ceph-iscsi-gw - - - name: Upgrade ceph client node vars: upgrade_ceph_packages: true @@ -1245,7 +1188,6 @@ - "{{ mgr_group_name|default('mgrs') }}" - "{{ rbdmirror_group_name|default('rbdmirrors') }}" - "{{ nfs_group_name|default('nfss') }}" - - "{{ iscsi_gw_group_name|default('iscsigws') }}" - "{{ monitoring_group_name|default('monitoring') }}" tags: monitoring gather_facts: false diff --git a/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml b/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml index e43728186e..ee19b8ba2e 100644 --- a/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml +++ b/infrastructure-playbooks/switch-from-non-containerized-to-containerized-ceph-daemons.yml @@ -718,64 +718,6 @@ ansible.builtin.import_role: name: ceph-nfs -- name: Switching from non-containerized to containerized iscsigws - hosts: "{{ iscsi_gw_group_name|default('iscsigws') }}" - vars: - containerized_deployment: true - iscsi_gw_group_name: iscsigws - become: true - serial: 1 - pre_tasks: - - name: Import ceph-defaults role - ansible.builtin.import_role: - name: ceph-defaults - - - name: Stop iscsigw services - ansible.builtin.service: - name: "{{ item }}" - state: stopped - enabled: false - with_items: - - tcmu-runner - - rbd-target-gw - - rbd-target-api - - - name: Remove old systemd unit files - ansible.builtin.file: - path: "/usr/lib/systemd/system/{{ item }}.service" - state: absent - with_items: - - tcmu-runner - - rbd-target-gw - - rbd-target-api - tasks: - - name: Import ceph-facts role - ansible.builtin.import_role: - name: ceph-facts - - - name: Import ceph-handler role - ansible.builtin.import_role: - name: ceph-handler - - # NOTE: changed from file module to raw find command for performance reasons - # The file module has to run checks on current ownership of all directories and files. This is unnecessary - # as in this case we know we want all owned by ceph user - - name: Set proper ownership on ceph directories - ansible.builtin.command: "find /etc/ceph -not -( -user {{ ceph_uid }} -or -group {{ ceph_uid }} -) -execdir chown -h {{ ceph_uid }}:{{ ceph_uid }} {} +" - changed_when: false - - - name: Import ceph-container-engine role - ansible.builtin.import_role: - name: ceph-container-engine - - - name: Import ceph-container-common role - ansible.builtin.import_role: - name: ceph-container-common - - - name: Import ceph-iscsi-gw role - ansible.builtin.import_role: - name: ceph-iscsi-gw - - name: Switching from non-containerized to containerized ceph-crash hosts: diff --git a/infrastructure-playbooks/take-over-existing-cluster.yml b/infrastructure-playbooks/take-over-existing-cluster.yml index 2b230a41fd..228e86ae36 100644 --- a/infrastructure-playbooks/take-over-existing-cluster.yml +++ b/infrastructure-playbooks/take-over-existing-cluster.yml @@ -33,7 +33,6 @@ - rbdmirrors - clients - mgrs - - iscsi-gw become: true tasks: - name: Import ceph-defaults role diff --git a/library/igw_client.py b/library/igw_client.py deleted file mode 100644 index d4905f69ab..0000000000 --- a/library/igw_client.py +++ /dev/null @@ -1,135 +0,0 @@ -#!/usr/bin/env python - -__author__ = 'pcuzner@redhat.com' - -DOCUMENTATION = """ ---- -module: igw_client -short_description: Manage iscsi gateway client definitions -description: - - This module calls the 'client' configuration management module installed - on the iscsi gateway node to handle the definition of iscsi clients on the - gateway(s). This definition will setup iscsi authentication (e.g. chap), - and mask the required rbd images to the client. - - The 'client' configuration module is provided by ceph-iscsi-config - rpm which is installed on the gateway nodes. - - To support module debugging, this module logs to - /var/log/ansible-module-igw_config.log on the target machine(s). - -option: - client_iqn: - description: - - iqn of the client machine which should be connected or removed from the - iscsi gateway environment - required: true - - image_list: - description: - - comma separated string providing the rbd images that this - client definition should have. The rbd images provided must use the - following format . - e.g. rbd.disk1,rbd.disk2 - required: true - - chap: - description: - - chap credentials for the client to authenticate to the gateways - to gain access to the exported rbds (LUNs). The credentials is a string - value of the form 'username/password'. The iscsi client must then use - these settings to gain access to any LUN resources. - required: true - - state: - description: - - desired state for this client - absent or present - required: true - -requirements: ['ceph-iscsi-config'] - -author: - - 'Paul Cuzner' - -""" - -import os # noqa: E402 -import logging # noqa: E402 -from logging.handlers import RotatingFileHandler # noqa: E402 -from ansible.module_utils.basic import * # noqa: E402,F403 - -from ceph_iscsi_config.client import GWClient # noqa: E402 -import ceph_iscsi_config.settings as settings # noqa: E402 - - -# the main function is called ansible_main to allow the call stack -# to be checked to determine whether the call to the ceph_iscsi_config -# modules is from ansible or not -def ansible_main(): - - fields = { - "client_iqn": {"required": True, "type": "str"}, - "image_list": {"required": True, "type": "str"}, - "chap": {"required": True, "type": "str"}, - "state": { - "required": True, - "choices": ['present', 'absent'], - "type": "str" - }, - } - - module = AnsibleModule(argument_spec=fields, # noqa: F405 - supports_check_mode=False) - - client_iqn = module.params['client_iqn'] - - if module.params['image_list']: - image_list = module.params['image_list'].split(',') - else: - image_list = [] - - chap = module.params['chap'] - desired_state = module.params['state'] - - logger.info("START - Client configuration started : {}".format(client_iqn)) - - # The client is defined using the GWClient class. This class handles - # client attribute updates, rados configuration object updates and LIO - # settings. Since the logic is external to this custom module, clients - # can be created/deleted by other methods in the same manner. - client = GWClient(logger, client_iqn, image_list, chap) - if client.error: - module.fail_json(msg=client.error_msg) - - client.manage(desired_state) - if client.error: - module.fail_json(msg=client.error_msg) - - logger.info("END - Client configuration complete - {} " - "changes made".format(client.change_count)) - - changes_made = True if client.change_count > 0 else False - - module.exit_json(changed=changes_made, - meta={"msg": "Client definition completed {} " - "changes made".format(client.change_count)}) - - -if __name__ == '__main__': - - module_name = os.path.basename(__file__).replace('ansible_module_', '') - logger = logging.getLogger(os.path.basename(module_name)) - logger.setLevel(logging.DEBUG) - handler = RotatingFileHandler('/var/log/ansible-module-igw_config.log', - maxBytes=5242880, - backupCount=7) - log_fmt = logging.Formatter('%(asctime)s %(name)s %(levelname)-8s : ' - '%(message)s') - handler.setFormatter(log_fmt) - logger.addHandler(handler) - - # initialise global variables used by all called modules - # e.g. ceph conffile, keyring etc - settings.init() - - ansible_main() diff --git a/library/igw_gateway.py b/library/igw_gateway.py deleted file mode 100644 index 7ad9aa3304..0000000000 --- a/library/igw_gateway.py +++ /dev/null @@ -1,145 +0,0 @@ -#!/usr/bin/env python -__author__ = 'pcuzner@redhat.com' - - -DOCUMENTATION = """ ---- -module: igw_gateway -short_description: Manage the iscsi gateway definition -description: - - This module calls the 'gateway' configuration management module installed - on the iscsi gateway node(s) to handle the definition of iscsi gateways. - The module will configure; - * the iscsi target and target portal group (TPG) - * rbd maps to the gateway and registration of those rbds as LUNs to the - kernels LIO subsystem - - The actual configuration modules are provided by ceph-iscsi-config rpm - which is installed on the gateway nodes. - - To support module debugging, this module logs to - /var/log/ansible-module-igw_config.log on the target machine(s). - -option: - gateway_iqn: - description: - - iqn that all gateway nodes will use to present a common system image - name to iscsi clients - required: true - - gateway_ip_list: - description: - - comma separated string providing the IP addresses that will be used - as iSCSI portal IPs to accept iscsi client connections. Each IP address - should equate to an IP on a gateway node - typically dedicated to iscsi - traffic. The order of the IP addresses determines the TPG sequence - within the target definition - so once defined, new gateways can be - added but *must* be added to the end of this list to preserve the tpg - sequence - - e.g. 192.168.122.101,192.168.122.103 - required: true - - mode: - description: - - mode in which to run the gateway module. Two modes are supported - target ... define the iscsi target iqn, tpg's and portals - map ...... map luns to the tpg's, and also define the ALUA path setting - for each LUN (activeOptimized/activenonoptimized) - required: true - - -requirements: ['ceph-iscsi-config'] - -author: - - 'Paul Cuzner' - -""" - -import os # noqa: E402 -import logging # noqa: E402 - -from logging.handlers import RotatingFileHandler # noqa: E402 -from ansible.module_utils.basic import * # noqa: E402,F403 - -import ceph_iscsi_config.settings as settings # noqa: E402 -from ceph_iscsi_config.common import Config # noqa: E402 - -from ceph_iscsi_config.gateway import GWTarget # noqa: E402 -from ceph_iscsi_config.utils import valid_ip # noqa: E402 - - -# the main function is called ansible_main to allow the call stack -# to be checked to determine whether the call to the ceph_iscsi_config -# modules is from ansible or not -def ansible_main(): - # Configures the gateway on the host. All images defined are added to - # the default tpg for later allocation to clients - fields = {"gateway_iqn": {"required": True, "type": "str"}, - "gateway_ip_list": {"required": True}, # "type": "list"}, - "mode": { - "required": True, - "choices": ['target', 'map'] - } - } - - module = AnsibleModule(argument_spec=fields, # noqa: F405 - supports_check_mode=False) - - cfg = Config(logger) - if cfg.config['version'] > 3: - module.fail_json(msg="Unsupported iscsigws.yml/iscsi-gws.yml setting " - "detected. Remove depreciated iSCSI target, LUN, " - "client, and gateway settings from " - "iscsigws.yml/iscsi-gws.yml. See " - "iscsigws.yml.sample for list of supported " - "settings") - - gateway_iqn = module.params['gateway_iqn'] - gateway_ip_list = module.params['gateway_ip_list'].split(',') - mode = module.params['mode'] - - if not valid_ip(gateway_ip_list): - module.fail_json(msg="Invalid gateway IP address(es) provided - port " - "22 check failed ({})".format(gateway_ip_list)) - - logger.info("START - GATEWAY configuration started - mode {}".format(mode)) - - gateway = GWTarget(logger, gateway_iqn, gateway_ip_list) - if gateway.error: - logger.critical("(ansible_main) Gateway init failed - " - "{}".format(gateway.error_msg)) - module.fail_json(msg="iSCSI gateway initialisation failed " - "({})".format(gateway.error_msg)) - - gateway.manage(mode) - - if gateway.error: - logger.critical("(main) Gateway creation or load failed, " - "unable to continue") - module.fail_json(msg="iSCSI gateway creation/load failure " - "({})".format(gateway.error_msg)) - - logger.info("END - GATEWAY configuration complete") - module.exit_json(changed=gateway.changes_made, - meta={"msg": "Gateway setup complete"}) - - -if __name__ == '__main__': - - module_name = os.path.basename(__file__).replace('ansible_module_', '') - logger = logging.getLogger(os.path.basename(module_name)) - logger.setLevel(logging.DEBUG) - handler = RotatingFileHandler('/var/log/ansible-module-igw_config.log', - maxBytes=5242880, - backupCount=7) - log_fmt = logging.Formatter('%(asctime)s %(name)s %(levelname)-8s : ' - '%(message)s') - handler.setFormatter(log_fmt) - logger.addHandler(handler) - - # initialise global variables used by all called modules - # e.g. ceph conffile, keyring etc - settings.init() - - ansible_main() diff --git a/library/igw_lun.py b/library/igw_lun.py deleted file mode 100644 index 8fae72cf2f..0000000000 --- a/library/igw_lun.py +++ /dev/null @@ -1,168 +0,0 @@ -#!/usr/bin/env python - -__author__ = 'pcuzner@redhat.com' - -DOCUMENTATION = """ ---- -module: igw_lun -short_description: Manage ceph rbd images to present as iscsi LUNs to clients -description: - - This module calls the 'lun' configuration management module installed - on the iscsi gateway node(s). The lun module handles the creation and resize # noqa: E501 - of rbd images, and then maps these rbd devices to the gateway node(s) to be - exposed through the kernel's LIO target. - - To support module debugging, this module logs to /var/log/ansible-module-igw_config.log # noqa: E501 - on the target machine(s). - -option: - pool: - description: - - The ceph pool where the image should exist or be created in. - - NOTE - The pool *must* exist prior to the Ansible run. - - required: true - - image: - description: - - this is the rbd image name to create/resize - if the rbd does not exist it - is created for you with the settings optimised for exporting over iscsi. - required: true - - size: - description: - - The size of the rbd image to create/resize. The size is numeric suffixed by - G or T (GB or TB). Increasing the size of a LUN is supported, but if a size - is provided that is smaller that the current size, the request is simply ignored. - - e.g. 100G - required: true - - host: - description: - - the host variable defines the name of the gateway node that will be - the allocation host for this rbd image. RBD creation and resize can - only be performed by one gateway, the other gateways in the - configuration will wait for the operation to complete. - required: true - - features: - description: - - placeholder to potentially allow different rbd features to be set at - allocation time by Ansible. NOT CURRENTLY USED - required: false - - state: - description: - - desired state for this LUN - absent or present. For a state='absent' - request, the lun module will verify that the rbd image is not allocated to - a client. As long as the rbd image is not in use, the LUN definition will be - removed from LIO, unmapped from all gateways AND DELETED. - - USE WITH CARE! - required: true - -requirements: ['ceph-iscsi-config'] - -author: - - 'Paul Cuzner' - -""" - -import os # noqa: E402 -import logging # noqa: E402 -from logging.handlers import RotatingFileHandler # noqa: E402 - -from ansible.module_utils.basic import * # noqa: E402,F403 - -from ceph_iscsi_config.lun import LUN # noqa: E402 -from ceph_iscsi_config.utils import valid_size # noqa: E402 -import ceph_iscsi_config.settings as settings # noqa: E402 - - -# the main function is called ansible_main to allow the call stack -# to be checked to determine whether the call to the ceph_iscsi_config -# modules is from ansible or not -def ansible_main(): - - # Define the fields needs to create/map rbd's the the host(s) - # NB. features and state are reserved/unused - fields = { - "pool": {"required": False, "default": "rbd", "type": "str"}, - "image": {"required": True, "type": "str"}, - "size": {"required": True, "type": "str"}, - "host": {"required": True, "type": "str"}, - "features": {"required": False, "type": "str"}, - "state": { - "required": False, - "default": "present", - "choices": ['present', 'absent'], - "type": "str" - }, - } - - # not supporting check mode currently - module = AnsibleModule(argument_spec=fields, # noqa: F405 - supports_check_mode=False) - - pool = module.params["pool"] - image = module.params['image'] - size = module.params['size'] - allocating_host = module.params['host'] - desired_state = module.params['state'] - - ################################################ - # Validate the parameters passed from Ansible # - ################################################ - if not valid_size(size): - logger.critical("image '{}' has an invalid size specification '{}' " - "in the ansible configuration".format(image, - size)) - module.fail_json(msg="(main) Unable to use the size parameter '{}' " - "for image '{}' from the playbook - " - "must be a number suffixed by M,G " - "or T".format(size, - image)) - - # define a lun object and perform some initial parameter validation - lun = LUN(logger, pool, image, size, allocating_host) - if lun.error: - module.fail_json(msg=lun.error_msg) - - logger.info("START - LUN configuration started for {}/{}".format(pool, - image)) - - # attempt to create/allocate the LUN for LIO - lun.manage(desired_state) - if lun.error: - module.fail_json(msg=lun.error_msg) - - if lun.num_changes == 0: - logger.info("END - No changes needed") - else: - logger.info("END - {} configuration changes " - "made".format(lun.num_changes)) - - module.exit_json(changed=(lun.num_changes > 0), - meta={"msg": "Configuration updated"}) - - -if __name__ == '__main__': - - module_name = os.path.basename(__file__).replace('ansible_module_', '') - logger = logging.getLogger(os.path.basename(module_name)) - logger.setLevel(logging.DEBUG) - handler = RotatingFileHandler('/var/log/ansible-module-igw_config.log', - maxBytes=5242880, - backupCount=7) - log_fmt = logging.Formatter('%(asctime)s %(name)s %(levelname)-8s : ' - '%(message)s') - handler.setFormatter(log_fmt) - logger.addHandler(handler) - - # initialise global variables used by all called modules - # e.g. ceph conffile, keyring etc - settings.init() - - ansible_main() diff --git a/library/igw_purge.py b/library/igw_purge.py deleted file mode 100644 index a2a9f8421f..0000000000 --- a/library/igw_purge.py +++ /dev/null @@ -1,161 +0,0 @@ -#!/usr/bin/env python - -DOCUMENTATION = """ ---- -module: igw_purge -short_description: Provide a purge capability to remove an iSCSI gateway -environment -description: - - This module handles the removal of a gateway configuration from a ceph - environment. - The playbook that calls this module prompts the user for the type of purge - to perform. - The purge options are; - all ... purge all LIO configuration *and* delete all defined rbd images - lio ... purge only the LIO configuration (rbd's are left intact) - - USE WITH CAUTION - - To support module debugging, this module logs to - /var/log/ansible-module-igw_config.log on each target machine(s). - -option: - mode: - description: - - the mode defines the type of purge requested - gateway ... remove the LIO configuration only - disks ... remove the rbd disks defined to the gateway - required: true - -requirements: ['ceph-iscsi-config', 'python-rtslib'] - -author: - - 'Paul Cuzner' - -""" - -import os # noqa: E402 -import logging # noqa: E402 -import socket # noqa: E402,F401 -import rados # noqa: E402 -import rbd # noqa: E402 - -from logging.handlers import RotatingFileHandler # noqa: E402 -from ansible.module_utils.basic import * # noqa: E402,F403 - -import ceph_iscsi_config.settings as settings # noqa: E402 -from ceph_iscsi_config.common import Config # noqa: E402 -from ceph_iscsi_config.lun import RBDDev # noqa: E402 - -__author__ = 'pcuzner@redhat.com' - - -def delete_images(cfg): - changes_made = False - - for disk_name, disk in cfg.config['disks'].items(): - image = disk['image'] - - logger.debug("Deleing image {}".format(image)) - - backstore = disk.get('backstore') - if backstore is None: - # ceph iscsi-config based. - rbd_dev = RBDDev(image, 0, disk['pool']) - else: - # ceph-iscsi based. - rbd_dev = RBDDev(image, 0, backstore, disk['pool']) - - try: - rbd_dev.delete() - except rbd.ImageNotFound: - # Just log and ignore. If we crashed while purging we could delete - # the image but not removed it from the config - logger.debug("Image already deleted.") - except rbd.ImageHasSnapshots: - logger.error("Image still has snapshots.") - # Older versions of ceph-iscsi-config do not have a error_msg - # string. - if not rbd_dev.error_msg: - rbd_dev.error_msg = "Image has snapshots." - - if rbd_dev.error: - if rbd_dev.error_msg: - logger.error("Could not remove {}. Error: {}. Manually run the " # noqa: E501 - "rbd command line tool to delete.". - format(image, rbd_dev.error_msg)) - else: - logger.error("Could not remove {}. Manually run the rbd " - "command line tool to delete.".format(image)) - else: - changes_made = True - - return changes_made - - -def delete_gateway_config(cfg, module): - ioctx = cfg._open_ioctx() - try: - size, mtime = ioctx.stat(cfg.config_name) - except rados.ObjectNotFound: - logger.debug("gateway.conf already removed.") - return False - - try: - ioctx.remove_object(cfg.config_name) - except Exception as err: - module.fail_json(msg="Gateway config object failed: {}".format(err)) - - return True - - -def ansible_main(): - - fields = {"mode": {"required": True, - "type": "str", - "choices": ["gateway", "disks"] - } - } - - module = AnsibleModule(argument_spec=fields, # noqa: F405 - supports_check_mode=False) - - run_mode = module.params['mode'] - changes_made = False - - logger.info("START - GATEWAY configuration PURGE started, run mode " - "is {}".format(run_mode)) - cfg = Config(logger) - # - # Purge gateway configuration, if the config has gateways - if run_mode == 'gateway': - changes_made = delete_gateway_config(cfg, module) - elif run_mode == 'disks' and len(cfg.config['disks'].keys()) > 0: - # - # Remove the disks on this host, that have been registered in the - # config object - changes_made = delete_images(cfg) - - logger.info("END - GATEWAY configuration PURGE complete") - - module.exit_json(changed=changes_made, - meta={"msg": "Purge of iSCSI settings ({}) " - "complete".format(run_mode)}) - - -if __name__ == '__main__': - - module_name = os.path.basename(__file__).replace('ansible_module_', '') - logger = logging.getLogger(os.path.basename(module_name)) - logger.setLevel(logging.DEBUG) - handler = RotatingFileHandler('/var/log/ansible-module-igw_config.log', - maxBytes=5242880, - backupCount=7) - log_fmt = logging.Formatter('%(asctime)s %(name)s %(levelname)-8s : ' - '%(message)s') - handler.setFormatter(log_fmt) - logger.addHandler(handler) - - settings.init() - - ansible_main() diff --git a/plugins/callback/installer_checkpoint.py b/plugins/callback/installer_checkpoint.py index eb4d72bf10..976ccefb6f 100644 --- a/plugins/callback/installer_checkpoint.py +++ b/plugins/callback/installer_checkpoint.py @@ -29,7 +29,6 @@ def v2_playbook_on_stats(self, stats): 'installer_phase_ceph_nfs', 'installer_phase_ceph_rbdmirror', 'installer_phase_ceph_client', - 'installer_phase_ceph_iscsi_gw', 'installer_phase_ceph_rgw_loadbalancer', 'installer_phase_ceph_dashboard', 'installer_phase_ceph_grafana', @@ -71,10 +70,6 @@ def v2_playbook_on_stats(self, stats): 'title': 'Install Ceph Client', 'playbook': 'roles/ceph-client/tasks/main.yml' }, - 'installer_phase_ceph_iscsi_gw': { - 'title': 'Install Ceph iSCSI Gateway', - 'playbook': 'roles/ceph-iscsi-gw/tasks/main.yml' - }, 'installer_phase_ceph_rgw_loadbalancer': { 'title': 'Install Ceph RGW LoadBalancer', 'playbook': 'roles/ceph-rgw-loadbalancer/tasks/main.yml' diff --git a/rhcs_edits.txt b/rhcs_edits.txt index b564cd895f..3a974593c9 100644 --- a/rhcs_edits.txt +++ b/rhcs_edits.txt @@ -1,6 +1,5 @@ ceph_repository: rhcs ceph_origin: repository -ceph_iscsi_config_dev: false ceph_rhcs_version: 5 containerized_deployment: true ceph_docker_image: "rhceph/rhceph-5-rhel8" diff --git a/roles/ceph-common/tasks/installs/prerequisite_rhcs_cdn_install.yml b/roles/ceph-common/tasks/installs/prerequisite_rhcs_cdn_install.yml index a1785072bd..368e0b0ba7 100644 --- a/roles/ceph-common/tasks/installs/prerequisite_rhcs_cdn_install.yml +++ b/roles/ceph-common/tasks/installs/prerequisite_rhcs_cdn_install.yml @@ -9,7 +9,6 @@ or rgw_group_name in group_names or mds_group_name in group_names or nfs_group_name in group_names - or iscsi_gw_group_name in group_names or client_group_name in group_names or rbdmirror_group_name in group_names or monitoring_group_name in group_names diff --git a/roles/ceph-config/tasks/main.yml b/roles/ceph-config/tasks/main.yml index 27d16dede3..ea8e170b0e 100644 --- a/roles/ceph-config/tasks/main.yml +++ b/roles/ceph-config/tasks/main.yml @@ -143,4 +143,3 @@ - Restart ceph rgws - Restart ceph mgrs - Restart ceph rbdmirrors - - Restart ceph rbd-target-api-gw diff --git a/roles/ceph-container-common/tasks/fetch_image.yml b/roles/ceph-container-common/tasks/fetch_image.yml index 7f504f91dd..f222e4ba38 100644 --- a/roles/ceph-container-common/tasks/fetch_image.yml +++ b/roles/ceph-container-common/tasks/fetch_image.yml @@ -47,7 +47,6 @@ inventory_hostname in groups.get(mgr_group_name, []) or inventory_hostname in groups.get(rbdmirror_group_name, []) or inventory_hostname in groups.get(nfs_group_name, []) or - inventory_hostname in groups.get(iscsi_gw_group_name, []) or inventory_hostname in groups.get(monitoring_group_name, []) environment: HTTP_PROXY: "{{ ceph_docker_http_proxy | default('') }}" diff --git a/roles/ceph-dashboard/tasks/configure_dashboard.yml b/roles/ceph-dashboard/tasks/configure_dashboard.yml index a3fec0c0df..bc96e1782b 100644 --- a/roles/ceph-dashboard/tasks/configure_dashboard.yml +++ b/roles/ceph-dashboard/tasks/configure_dashboard.yml @@ -308,38 +308,6 @@ - dashboard_rgw_api_no_ssl_verify | bool - radosgw_frontend_ssl_certificate | length > 0 -- name: Dashboard iscsi management - when: groups.get(iscsi_gw_group_name, []) | length > 0 - run_once: true - block: - - name: Disable iscsi api ssl verification - ansible.builtin.command: "{{ container_exec_cmd }} ceph --cluster {{ cluster }} dashboard set-iscsi-api-ssl-verification false" - changed_when: false - delegate_to: "{{ groups[mon_group_name][0] }}" - when: - - api_secure | default(false) | bool - - generate_crt | default(false) | bool - - - name: Add iscsi gateways - ipv4 - ansible.builtin.command: "{{ ceph_cmd }} --cluster {{ cluster }} dashboard iscsi-gateway-add -i -" - args: - stdin: "{{ 'https' if hostvars[item]['api_secure'] | default(false) | bool else 'http' }}://{{ hostvars[item]['api_user'] | default('admin') }}:{{ hostvars[item]['api_password'] | default('admin') }}@{{ hostvars[item]['ansible_facts']['all_ipv4_addresses'] | ips_in_ranges(igw_network.split(',')) | first }}:{{ hostvars[item]['api_port'] | default(5000) }}" - stdin_add_newline: false - changed_when: false - delegate_to: "{{ groups[mon_group_name][0] }}" - with_items: "{{ groups[iscsi_gw_group_name] }}" - when: ip_version == 'ipv4' - - - name: Add iscsi gateways - ipv6 - ansible.builtin.command: "{{ ceph_cmd }} --cluster {{ cluster }} dashboard iscsi-gateway-add -i -" - args: - stdin: "{{ 'https' if hostvars[item]['api_secure'] | default(false) | bool else 'http' }}://{{ hostvars[item]['api_user'] | default('admin') }}:{{ hostvars[item]['api_password'] | default('admin') }}@{{ hostvars[item]['ansible_facts']['all_ipv6_addresses'] | ips_in_ranges(igw_network.split(',')) | last | ansible.utils.ipwrap }}:{{ hostvars[item]['api_port'] | default(5000) }}" - stdin_add_newline: false - changed_when: false - delegate_to: "{{ groups[mon_group_name][0] }}" - with_items: "{{ groups[iscsi_gw_group_name] }}" - when: ip_version == 'ipv6' - - name: Disable mgr dashboard module (restart) ceph_mgr_module: name: dashboard diff --git a/roles/ceph-defaults/defaults/main.yml b/roles/ceph-defaults/defaults/main.yml index 7d6be078c7..1752df93a2 100644 --- a/roles/ceph-defaults/defaults/main.yml +++ b/roles/ceph-defaults/defaults/main.yml @@ -46,7 +46,6 @@ mds_group_name: mdss nfs_group_name: nfss rbdmirror_group_name: rbdmirrors client_group_name: clients -iscsi_gw_group_name: iscsigws mgr_group_name: mgrs rgwloadbalancer_group_name: rgwloadbalancers monitoring_group_name: monitoring @@ -58,7 +57,6 @@ adopt_label_group_names: - "{{ nfs_group_name }}" - "{{ rbdmirror_group_name }}" - "{{ client_group_name }}" - - "{{ iscsi_gw_group_name }}" - "{{ mgr_group_name }}" - "{{ rgwloadbalancer_group_name }}" - "{{ monitoring_group_name }}" @@ -76,7 +74,6 @@ ceph_rgw_firewall_zone: public ceph_mds_firewall_zone: public ceph_nfs_firewall_zone: public ceph_rbdmirror_firewall_zone: public -ceph_iscsi_firewall_zone: public ceph_dashboard_firewall_zone: public ceph_rgwloadbalancer_firewall_zone: public @@ -210,8 +207,6 @@ nfs_ganesha_dev: false # use development repos for nfs-ganesha # flavors so far include: ceph_main, ceph_jewel, ceph_kraken, ceph_luminous nfs_ganesha_flavor: "ceph_main" -ceph_iscsi_config_dev: true # special repo for deploying iSCSI gateways - # REPOSITORY: CUSTOM # @@ -695,75 +690,6 @@ alertmanager_port: 9093 alertmanager_cluster_port: 9094 alertmanager_conf_overrides: {} alertmanager_dashboard_api_no_ssl_verify: "{{ true if dashboard_protocol == 'https' and not dashboard_crt and not dashboard_key else false }}" -# igw -# -# `igw_network` variable is intended for allowing dashboard deployment with iSCSI node not residing in the same subnet than what is defined in `public_network`. -# For example: -# If the ceph public network is 2a00:8a60:1:c301::/64 and the iSCSI Gateway resides -# at a dedicated gateway network (2a00:8a60:1:c300::/64) (With routing between those networks). -# It means "{{ hostvars[item]['ansible_facts']['all_ipv4_addresses'] | ips_in_ranges(public_network.split(',')) | last | ansible.utils.ipwrap }}" will be empty. -# As a consequence, this prevent from deploying dashboard with iSCSI node when it reside in a subnet different than `public_network`. -# Using `igw_network` make it possible, set it with the subnet used by your iSCSI node. -igw_network: "{{ public_network }}" - - -################################## -# DEPRECIATED iSCSI TARGET SETUP # -################################## - -# WARNING # - -# The following values are depreciated. To setup targets, gateways, LUNs, and -# clients you should use gwcli or dashboard. If the following values are set, -# the old ceph-iscsi-config/ceph-iscsi-cli packages will be used. - -# Specify the iqn for ALL gateways. This iqn is shared across the gateways, so an iscsi -# client sees the gateway group as a single storage subsystem. -gateway_iqn: "" - -# gateway_ip_list provides a list of the IP Addrresses - one per gateway - that will be used -# as an iscsi target portal ip. The list must be comma separated - and the order determines -# the sequence of TPG's within the iscsi target across each gateway. Once set, additional -# gateways can be added, but the order must *not* be changed. -gateway_ip_list: 0.0.0.0 - -# rbd_devices defines the images that should be created and exported from the iscsi gateways. -# If the rbd does not exist, it will be created for you. In addition you may increase the -# size of rbd's by changing the size parameter and rerunning the playbook. A size value lower -# than the current size of the rbd is ignored. -# -# the 'host' parameter defines which of the gateway nodes should handle the physical -# allocation/expansion or removal of the rbd -# to remove an image, simply use a state of 'absent'. This will first check the rbd is not allocated -# to any client, and the remove it from LIO and then delete the rbd image -# -# NB. this variable definition can be commented out to bypass LUN management -# -# Example: -# -# rbd_devices: -# - { pool: 'rbd', image: 'ansible1', size: '30G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible2', size: '15G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible3', size: '30G', host: 'ceph-1', state: 'present' } -# - { pool: 'rbd', image: 'ansible4', size: '50G', host: 'ceph-1', state: 'present' } -rbd_devices: {} - -# client_connections defines the client ACL's to restrict client access to specific LUNs -# The settings are as follows; -# - image_list is a comma separated list of rbd images of the form . -# - chap supplies the user and password the client will use for authentication of the -# form / -# - status shows the intended state of this client definition - 'present' or 'absent' -# -# NB. this definition can be commented out to skip client (nodeACL) management -# -# Example: -# -# client_connections: -# - { client: 'iqn.1994-05.com.redhat:rh7-iscsi-client', image_list: 'rbd.ansible1,rbd.ansible2', chap: 'rh7-iscsi-client/redhat', status: 'present' } -# - { client: 'iqn.1991-05.com.microsoft:w2k12r2', image_list: 'rbd.ansible4', chap: 'w2k12r2/microsoft_w2k12', status: 'absent' } - -client_connections: {} no_log_on_ceph_key_tasks: true diff --git a/roles/ceph-facts/tasks/facts.yml b/roles/ceph-facts/tasks/facts.yml index 26f2f97875..d65e493158 100644 --- a/roles/ceph-facts/tasks/facts.yml +++ b/roles/ceph-facts/tasks/facts.yml @@ -225,11 +225,6 @@ ansible.builtin.include_tasks: set_radosgw_address.yml when: inventory_hostname in groups.get(rgw_group_name, []) -- name: Set_fact use_new_ceph_iscsi package or old ceph-iscsi-config/cli - ansible.builtin.set_fact: - use_new_ceph_iscsi: "{{ (gateway_ip_list == '0.0.0.0' and gateway_iqn | length == 0 and client_connections | length == 0 and rbd_devices | length == 0) | bool | ternary(true, false) }}" - when: iscsi_gw_group_name in group_names - - name: Set_fact ceph_run_cmd ansible.builtin.set_fact: ceph_run_cmd: "{{ container_binary + ' run --rm --net=host -v /etc/ceph:/etc/ceph:z -v /var/lib/ceph/:/var/lib/ceph/:z -v /var/log/ceph/:/var/log/ceph/:z --entrypoint=ceph ' + ceph_docker_registry + '/' + ceph_docker_image + ':' + ceph_docker_image_tag if containerized_deployment | bool else 'ceph' }}" diff --git a/roles/ceph-handler/handlers/main.yml b/roles/ceph-handler/handlers/main.yml index b49276ead5..a806235eba 100644 --- a/roles/ceph-handler/handlers/main.yml +++ b/roles/ceph-handler/handlers/main.yml @@ -54,16 +54,6 @@ when: mgr_group_name in group_names listen: "Restart ceph mgrs" - - name: Tcmu-runner handler - ansible.builtin.include_tasks: handler_tcmu_runner.yml - when: iscsi_gw_group_name in group_names - listen: "Restart ceph tcmu-runner" - - - name: Rbd-target-api and rbd-target-gw handler - ansible.builtin.include_tasks: handler_rbd_target_api_gw.yml - when: iscsi_gw_group_name in group_names - listen: "Restart ceph rbd-target-api-gw" - - name: Ceph crash handler ansible.builtin.include_tasks: handler_crash.yml listen: "Restart ceph crash" diff --git a/roles/ceph-handler/tasks/check_running_containers.yml b/roles/ceph-handler/tasks/check_running_containers.yml index 1775120e2a..82f7c5c135 100644 --- a/roles/ceph-handler/tasks/check_running_containers.yml +++ b/roles/ceph-handler/tasks/check_running_containers.yml @@ -55,30 +55,6 @@ check_mode: false when: inventory_hostname in groups.get(nfs_group_name, []) -- name: Check for a tcmu-runner container - ansible.builtin.command: "{{ container_binary }} ps -q --filter='name=tcmu-runner'" - register: ceph_tcmu_runner_stat - changed_when: false - failed_when: false - check_mode: false - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - -- name: Check for a rbd-target-api container - ansible.builtin.command: "{{ container_binary }} ps -q --filter='name=rbd-target-api'" - register: ceph_rbd_target_api_stat - changed_when: false - failed_when: false - check_mode: false - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - -- name: Check for a rbd-target-gw container - ansible.builtin.command: "{{ container_binary }} ps -q --filter='name=rbd-target-gw'" - register: ceph_rbd_target_gw_stat - changed_when: false - failed_when: false - check_mode: false - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - - name: Check for a ceph-crash container ansible.builtin.command: "{{ container_binary }} ps -q --filter='name=ceph-crash-{{ ansible_facts['hostname'] }}'" register: ceph_crash_container_stat diff --git a/roles/ceph-handler/tasks/check_socket_non_container.yml b/roles/ceph-handler/tasks/check_socket_non_container.yml index 79f2219826..37e1b0f959 100644 --- a/roles/ceph-handler/tasks/check_socket_non_container.yml +++ b/roles/ceph-handler/tasks/check_socket_non_container.yml @@ -205,30 +205,6 @@ check_mode: false when: inventory_hostname in groups.get(nfs_group_name, []) -- name: Check for a tcmu-runner - ansible.builtin.command: "pgrep tcmu-runner" - register: ceph_tcmu_runner_stat - changed_when: false - failed_when: false - check_mode: false - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - -- name: Check for a rbd-target-api - ansible.builtin.command: "pgrep rbd-target-api" - register: ceph_rbd_target_api_stat - changed_when: false - failed_when: false - check_mode: false - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - -- name: Check for a rbd-target-gw - ansible.builtin.command: "pgrep name=rbd-target-gw" - register: ceph_rbd_target_gw_stat - changed_when: false - failed_when: false - check_mode: false - when: inventory_hostname in groups.get(iscsi_gw_group_name, []) - - name: Check for a ceph-crash process ansible.builtin.command: pgrep ceph-crash changed_when: false diff --git a/roles/ceph-handler/tasks/handler_rbd_target_api_gw.yml b/roles/ceph-handler/tasks/handler_rbd_target_api_gw.yml deleted file mode 100644 index ff7c107ed9..0000000000 --- a/roles/ceph-handler/tasks/handler_rbd_target_api_gw.yml +++ /dev/null @@ -1,40 +0,0 @@ ---- -- name: Set _rbd_target_api_handler_called before restart - ansible.builtin.set_fact: - _rbd_target_api_handler_called: true - -- name: Restart rbd-target-api - ansible.builtin.service: - name: rbd-target-api - state: restarted - when: - - ceph_rbd_target_api_stat.get('rc') == 0 - - hostvars[item]['_rbd_target_api_handler_called'] | default(False) | bool - - ceph_rbd_target_api_stat.get('stdout_lines', [])|length != 0 - with_items: "{{ groups[iscsi_gw_group_name] }}" - delegate_to: "{{ item }}" - run_once: true - -- name: Set _rbd_target_api_handler_called after restart - ansible.builtin.set_fact: - _rbd_target_api_handler_called: false - -- name: Set _rbd_target_gw_handler_called before restart - ansible.builtin.set_fact: - _rbd_target_gw_handler_called: true - -- name: Restart rbd-target-gw - ansible.builtin.service: - name: rbd-target-gw - state: restarted - when: - - ceph_rbd_target_gw_stat.get('rc') == 0 - - hostvars[item]['_rbd_target_gw_handler_called'] | default(False) | bool - - ceph_rbd_target_gw_stat.get('stdout_lines', [])|length != 0 - with_items: "{{ groups[iscsi_gw_group_name] }}" - delegate_to: "{{ item }}" - run_once: true - -- name: Set _rbd_target_gw_handler_called after restart - ansible.builtin.set_fact: - _rbd_target_gw_handler_called: false diff --git a/roles/ceph-handler/tasks/handler_tcmu_runner.yml b/roles/ceph-handler/tasks/handler_tcmu_runner.yml deleted file mode 100644 index 77a4b19515..0000000000 --- a/roles/ceph-handler/tasks/handler_tcmu_runner.yml +++ /dev/null @@ -1,20 +0,0 @@ ---- -- name: Set _tcmu_runner_handler_called before restart - ansible.builtin.set_fact: - _tcmu_runner_handler_called: true - -- name: Restart tcmu-runner - ansible.builtin.service: - name: tcmu-runner - state: restarted - when: - - ceph_tcmu_runner_stat.get('rc') == 0 - - hostvars[item]['_tcmu_runner_handler_called'] | default(False) | bool - - ceph_tcmu_runner_stat.get('stdout_lines', [])|length != 0 - with_items: "{{ groups[iscsi_gw_group_name] }}" - delegate_to: "{{ item }}" - run_once: true - -- name: Set _tcmu_runner_handler_called after restart - ansible.builtin.set_fact: - _tcmu_runner_handler_called: false diff --git a/roles/ceph-infra/tasks/configure_firewall.yml b/roles/ceph-infra/tasks/configure_firewall.yml index b62bb936e7..a47986bd57 100644 --- a/roles/ceph-infra/tasks/configure_firewall.yml +++ b/roles/ceph-infra/tasks/configure_firewall.yml @@ -219,51 +219,6 @@ - rbdmirror_group_name is defined - rbdmirror_group_name in group_names - - name: Open ceph networks on iscsi - ansible.posix.firewalld: - zone: "{{ ceph_iscsi_firewall_zone }}" - source: "{{ item }}" - permanent: true - immediate: true - state: enabled - with_items: "{{ public_network.split(',') }}" - when: - - iscsi_gw_group_name is defined - - iscsi_gw_group_name in group_names - - - name: Open iscsi target ports - ansible.posix.firewalld: - port: "3260/tcp" - zone: "{{ ceph_iscsi_firewall_zone }}" - permanent: true - immediate: true - state: enabled - when: - - iscsi_gw_group_name is defined - - iscsi_gw_group_name in group_names - - - name: Open iscsi api ports - ansible.posix.firewalld: - port: "{{ api_port | default(5000) }}/tcp" - zone: "{{ ceph_iscsi_firewall_zone }}" - permanent: true - immediate: true - state: enabled - when: - - iscsi_gw_group_name is defined - - iscsi_gw_group_name in group_names - - - name: Open iscsi/prometheus port - ansible.posix.firewalld: - port: "9287/tcp" - zone: "{{ ceph_iscsi_firewall_zone }}" - permanent: true - immediate: true - state: enabled - when: - - iscsi_gw_group_name is defined - - iscsi_gw_group_name in group_names - - name: Open dashboard ports ansible.builtin.include_tasks: dashboard_firewall.yml when: dashboard_enabled | bool diff --git a/roles/ceph-infra/tasks/main.yml b/roles/ceph-infra/tasks/main.yml index c44acd9e6f..407beec526 100644 --- a/roles/ceph-infra/tasks/main.yml +++ b/roles/ceph-infra/tasks/main.yml @@ -34,8 +34,7 @@ inventory_hostname in groups.get(mds_group_name, []) or inventory_hostname in groups.get(rgw_group_name, []) or inventory_hostname in groups.get(mgr_group_name, []) or - inventory_hostname in groups.get(rbdmirror_group_name, []) or - inventory_hostname in groups.get(iscsi_gw_group_name, []) + inventory_hostname in groups.get(rbdmirror_group_name, []) - name: Add logrotate configuration ansible.builtin.template: @@ -51,5 +50,4 @@ inventory_hostname in groups.get(mds_group_name, []) or inventory_hostname in groups.get(rgw_group_name, []) or inventory_hostname in groups.get(mgr_group_name, []) or - inventory_hostname in groups.get(rbdmirror_group_name, []) or - inventory_hostname in groups.get(iscsi_gw_group_name, []) + inventory_hostname in groups.get(rbdmirror_group_name, []) diff --git a/roles/ceph-infra/templates/logrotate.conf.j2 b/roles/ceph-infra/templates/logrotate.conf.j2 index e8be47396e..c64d4e03dd 100644 --- a/roles/ceph-infra/templates/logrotate.conf.j2 +++ b/roles/ceph-infra/templates/logrotate.conf.j2 @@ -10,16 +10,3 @@ notifempty su root root } - -/var/log/tcmu-runner/*.log { - rotate 7 - daily - compress - sharedscripts - postrotate - killall -q -1 tcmu-runner || pkill -1 -x "tcmu-runner" || true - endscript - missingok - notifempty - su root root -} diff --git a/roles/ceph-iscsi-gw/LICENSE b/roles/ceph-iscsi-gw/LICENSE deleted file mode 100644 index ff84f66fd4..0000000000 --- a/roles/ceph-iscsi-gw/LICENSE +++ /dev/null @@ -1,13 +0,0 @@ -Copyright 2016 Paul Cuzner pcuzner at redhat dot com - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. diff --git a/roles/ceph-iscsi-gw/README.md b/roles/ceph-iscsi-gw/README.md deleted file mode 100644 index 891dbabed9..0000000000 --- a/roles/ceph-iscsi-gw/README.md +++ /dev/null @@ -1,3 +0,0 @@ -# Ansible role: ceph-iscsi - -Documentation is available at http://docs.ceph.com/ceph-ansible/. diff --git a/roles/ceph-iscsi-gw/defaults/main.yml b/roles/ceph-iscsi-gw/defaults/main.yml deleted file mode 100644 index 972c23a4bd..0000000000 --- a/roles/ceph-iscsi-gw/defaults/main.yml +++ /dev/null @@ -1,49 +0,0 @@ ---- -# You can override vars by using host or group vars - -########### -# GENERAL # -########### -# Whether or not to generate secure certificate to iSCSI gateway nodes -generate_crt: false - -iscsi_conf_overrides: {} -iscsi_pool_name: rbd -# iscsi_pool_size: 3 - -copy_admin_key: true - -################## -# RBD-TARGET-API # -################## -# Optional settings related to the CLI/API service -api_user: admin -api_password: admin -api_port: 5000 -api_secure: false -loop_delay: 1 -# set the variable below with a comma separated list of IPs -# in order to restrict the access to the iSCSI API -# trusted_ip_list: 192.168.122.1 - - -########## -# DOCKER # -########## - -# Resource limitation -# For the whole list of limits you can apply see: docs.docker.com/engine/admin/resource_constraints -# Default values are based from: https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/2/html/red_hat_ceph_storage_hardware_guide/minimum_recommendations -# These options can be passed using the 'ceph_mds_docker_extra_env' variable. - -# TCMU_RUNNER resource limitation -ceph_tcmu_runner_docker_memory_limit: "{{ ansible_facts['memtotal_mb'] }}m" -ceph_tcmu_runner_docker_cpu_limit: 1 - -# RBD_TARGET_GW resource limitation -ceph_rbd_target_gw_docker_memory_limit: "{{ ansible_facts['memtotal_mb'] }}m" -ceph_rbd_target_gw_docker_cpu_limit: 1 - -# RBD_TARGET_API resource limitation -ceph_rbd_target_api_docker_memory_limit: "{{ ansible_facts['memtotal_mb'] }}m" -ceph_rbd_target_api_docker_cpu_limit: 1 diff --git a/roles/ceph-iscsi-gw/meta/main.yml b/roles/ceph-iscsi-gw/meta/main.yml deleted file mode 100644 index b7c8f39afa..0000000000 --- a/roles/ceph-iscsi-gw/meta/main.yml +++ /dev/null @@ -1,14 +0,0 @@ ---- -galaxy_info: - company: Red Hat - author: Paul Cuzner - description: Installs Ceph iSCSI Gateways - license: Apache - min_ansible_version: '2.7' - platforms: - - name: EL - versions: - - 'all' - galaxy_tags: - - system -dependencies: [] diff --git a/roles/ceph-iscsi-gw/tasks/common.yml b/roles/ceph-iscsi-gw/tasks/common.yml deleted file mode 100644 index 0a6a2d8d8f..0000000000 --- a/roles/ceph-iscsi-gw/tasks/common.yml +++ /dev/null @@ -1,72 +0,0 @@ ---- -- name: Get keys from monitors - ceph_key: - name: client.admin - cluster: "{{ cluster }}" - output_format: plain - state: info - environment: - CEPH_CONTAINER_IMAGE: "{{ ceph_docker_registry + '/' + ceph_docker_image + ':' + ceph_docker_image_tag if containerized_deployment | bool else None }}" - CEPH_CONTAINER_BINARY: "{{ container_binary }}" - register: _admin_key - delegate_to: "{{ groups.get(mon_group_name)[0] }}" - run_once: true - when: - - cephx | bool - - copy_admin_key | bool - no_log: "{{ no_log_on_ceph_key_tasks }}" - -- name: Copy ceph key(s) if needed - ansible.builtin.copy: - dest: "/etc/ceph/{{ cluster }}.client.admin.keyring" - content: "{{ _admin_key.stdout + '\n' }}" - owner: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" - group: "{{ ceph_uid if containerized_deployment | bool else 'ceph' }}" - mode: "{{ ceph_keyring_permissions }}" - when: - - cephx | bool - - copy_admin_key | bool - no_log: "{{ no_log_on_ceph_key_tasks }}" - -- name: Add mgr ip address to trusted list with dashboard - ipv4 - ansible.builtin.set_fact: - trusted_ip_list: '{{ trusted_ip_list | default("") }}{{ "," if trusted_ip_list is defined else "" }}{{ hostvars[item]["ansible_facts"]["all_ipv4_addresses"] | ips_in_ranges(public_network.split(",")) | first }}' - with_items: '{{ groups[mgr_group_name] | default(groups[mon_group_name]) }}' - when: - - dashboard_enabled | bool - - ip_version == 'ipv4' - -- name: Add mgr ip address to trusted list with dashboard - ipv6 - ansible.builtin.set_fact: - trusted_ip_list: '{{ trusted_ip_list | default("") }}{{ "," if trusted_ip_list is defined else "" }}{{ hostvars[item]["ansible_facts"]["all_ipv6_addresses"] | ips_in_ranges(public_network.split(",")) | last }}' - with_items: '{{ groups[mgr_group_name] | default(groups[mon_group_name]) }}' - when: - - dashboard_enabled | bool - - ip_version == 'ipv6' - -- name: Deploy gateway settings, used by the ceph_iscsi_config modules - openstack.config_template.config_template: - src: "{{ role_path }}/templates/iscsi-gateway.cfg.j2" - dest: /etc/ceph/iscsi-gateway.cfg - config_type: ini - config_overrides: '{{ iscsi_conf_overrides }}' - mode: "0600" - notify: Restart ceph rbd-target-api-gw - -- name: Set_fact container_exec_cmd - ansible.builtin.set_fact: - container_exec_cmd: "{{ container_binary }} exec ceph-mon-{{ hostvars[groups[mon_group_name][0]]['ansible_facts']['hostname'] }}" - delegate_to: "{{ groups[mon_group_name][0] }}" - when: containerized_deployment | bool - -- name: Create iscsi pool - ceph_pool: - name: "{{ iscsi_pool_name }}" - cluster: "{{ cluster }}" - size: "{{ iscsi_pool_size | default(omit) }}" - application: "rbd" - run_once: true - delegate_to: "{{ groups[mon_group_name][0] }}" - environment: - CEPH_CONTAINER_IMAGE: "{{ ceph_docker_registry + '/' + ceph_docker_image + ':' + ceph_docker_image_tag if containerized_deployment | bool else None }}" - CEPH_CONTAINER_BINARY: "{{ container_binary }}" diff --git a/roles/ceph-iscsi-gw/tasks/containerized.yml b/roles/ceph-iscsi-gw/tasks/containerized.yml deleted file mode 100644 index c1fb992a74..0000000000 --- a/roles/ceph-iscsi-gw/tasks/containerized.yml +++ /dev/null @@ -1,33 +0,0 @@ ---- -- name: Create /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} - ansible.builtin.file: - path: "/var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}" - state: directory - owner: "{{ ceph_uid }}" - group: "{{ ceph_uid }}" - mode: "{{ ceph_directories_mode }}" - -- name: Create rbd target log directories - ansible.builtin.file: - path: '/var/log/{{ item }}' - state: directory - mode: "0755" - with_items: - - rbd-target-api - - rbd-target-gw - - tcmu-runner - -- name: Include_tasks systemd.yml - ansible.builtin.include_tasks: systemd.yml - -- name: Systemd start tcmu-runner, rbd-target-api and rbd-target-gw containers - ansible.builtin.systemd: - name: "{{ item }}" - state: started - enabled: true - masked: false - daemon_reload: true - with_items: - - tcmu-runner - - rbd-target-gw - - rbd-target-api diff --git a/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml b/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml deleted file mode 100644 index 7bb04882a7..0000000000 --- a/roles/ceph-iscsi-gw/tasks/deploy_ssl_keys.yml +++ /dev/null @@ -1,90 +0,0 @@ ---- -- name: Create a temporary directory - ansible.builtin.tempfile: - state: directory - register: iscsi_ssl_tmp_dir - delegate_to: localhost - run_once: true - -- name: Set_fact crt_files - ansible.builtin.set_fact: - crt_files: - - "iscsi-gateway.crt" - - "iscsi-gateway.key" - - "iscsi-gateway.pem" - - "iscsi-gateway-pub.key" - -- name: Check for existing crt file(s) in monitor key/value store - ansible.builtin.command: "{{ container_exec_cmd }} ceph --cluster {{ cluster }} config get iscsi/ssl/{{ item }}" - with_items: "{{ crt_files }}" - changed_when: false - failed_when: crt_files_exist.rc not in [0, 22] - run_once: true - delegate_to: "{{ groups.get(mon_group_name)[0] }}" - register: crt_files_exist - -- name: Set_fact crt_files_missing - ansible.builtin.set_fact: - crt_files_missing: "{{ crt_files_exist.results | selectattr('rc', 'equalto', 0) | map(attribute='rc') | list | length != crt_files | length }}" - -- name: Generate ssl crt/key files - when: crt_files_missing - block: - - name: Create ssl crt/key files - ansible.builtin.command: > - openssl req -newkey rsa:2048 -nodes -keyout {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway.key - -x509 -days 365 -out {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway.crt - -subj "/C=US/ST=./L=./O=RedHat/OU=Linux/CN={{ ansible_facts['hostname'] }}" - delegate_to: localhost - run_once: true - changed_when: false - with_items: "{{ crt_files_exist.results }}" - - - name: Create pem # noqa: no-changed-when - ansible.builtin.shell: > - cat {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway.crt - {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway.key > {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway.pem - delegate_to: localhost - run_once: true - register: pem - with_items: "{{ crt_files_exist.results }}" - - - name: Create public key from pem - ansible.builtin.shell: > - openssl x509 -inform pem -in {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway.pem - -pubkey -noout > {{ iscsi_ssl_tmp_dir.path }}/iscsi-gateway-pub.key - delegate_to: localhost - run_once: true - when: pem.changed - tags: skip_ansible_lint - - - name: Slurp ssl crt/key files - ansible.builtin.slurp: - src: "{{ iscsi_ssl_tmp_dir.path }}/{{ item }}" - register: iscsi_ssl_files_content - with_items: "{{ crt_files }}" - run_once: true - delegate_to: localhost - - - name: Store ssl crt/key files - ansible.builtin.command: "{{ container_exec_cmd }} ceph --cluster {{ cluster }} config-key put iscsi/ssl/{{ item.item }} {{ item.content }}" - run_once: true - delegate_to: "{{ groups.get(mon_group_name)[0] }}" - with_items: "{{ iscsi_ssl_files_content.results }}" - changed_when: false - -- name: Copy crt file(s) to gateway nodes - ansible.builtin.copy: - content: "{{ item.stdout | b64decode }}" - dest: "/etc/ceph/{{ item.item }}" - owner: root - group: root - mode: "0400" - changed_when: false - with_items: "{{ crt_files_exist.results if not crt_files_missing else iscsi_ssl_files_content.results }}" - when: not crt_files_missing - -- name: Clean temporary directory - ansible.builtin.file: - path: "{{ iscsi_ssl_tmp_dir.path }}" - state: absent diff --git a/roles/ceph-iscsi-gw/tasks/main.yml b/roles/ceph-iscsi-gw/tasks/main.yml deleted file mode 100644 index 0709a95f1d..0000000000 --- a/roles/ceph-iscsi-gw/tasks/main.yml +++ /dev/null @@ -1,28 +0,0 @@ ---- -- name: Include common.yml - ansible.builtin.include_tasks: common.yml - -- name: Include non-container/prerequisites.yml - ansible.builtin.include_tasks: non-container/prerequisites.yml - when: not containerized_deployment | bool - -# deploy_ssl_keys used the ansible controller to create self-signed crt/key/pub files -# and transfers them to /etc/ceph directory on each controller. SSL certs are used by -# the API for https support. -- name: Include deploy_ssl_keys.yml - ansible.builtin.include_tasks: deploy_ssl_keys.yml - when: generate_crt | bool - -- name: Include non-container/configure_iscsi.yml - ansible.builtin.include_tasks: non-container/configure_iscsi.yml - when: - - not containerized_deployment | bool - - not use_new_ceph_iscsi | bool - -- name: Include non-container/postrequisites.yml - ansible.builtin.include_tasks: non-container/postrequisites.yml - when: not containerized_deployment | bool - -- name: Include containerized.yml - ansible.builtin.include_tasks: containerized.yml - when: containerized_deployment | bool diff --git a/roles/ceph-iscsi-gw/tasks/non-container/configure_iscsi.yml b/roles/ceph-iscsi-gw/tasks/non-container/configure_iscsi.yml deleted file mode 100644 index e4c4fa19ea..0000000000 --- a/roles/ceph-iscsi-gw/tasks/non-container/configure_iscsi.yml +++ /dev/null @@ -1,33 +0,0 @@ ---- -- name: Igw_gateway (tgt) | configure iscsi target (gateway) - igw_gateway: - mode: "target" - gateway_iqn: "{{ gateway_iqn }}" - gateway_ip_list: "{{ gateway_ip_list }}" - register: target - -- name: Igw_lun | configure luns (create/map rbds and add to lio) - igw_lun: - pool: "{{ item.pool }}" - image: "{{ item.image }}" - size: "{{ item.size }}" - host: "{{ item.host }}" - state: "{{ item.state }}" - with_items: "{{ rbd_devices }}" - register: images - -- name: Igw_gateway (map) | map luns to the iscsi target - igw_gateway: - mode: "map" - gateway_iqn: "{{ gateway_iqn }}" - gateway_ip_list: "{{ gateway_ip_list }}" - register: luns - -- name: Igw_client | configure client connectivity - igw_client: - client_iqn: "{{ item.client }}" - image_list: "{{ item.image_list }}" - chap: "{{ item.chap }}" - state: "{{ item.status }}" - with_items: "{{ client_connections }}" - register: clients diff --git a/roles/ceph-iscsi-gw/tasks/non-container/postrequisites.yml b/roles/ceph-iscsi-gw/tasks/non-container/postrequisites.yml deleted file mode 100644 index e405165fe7..0000000000 --- a/roles/ceph-iscsi-gw/tasks/non-container/postrequisites.yml +++ /dev/null @@ -1,9 +0,0 @@ -- name: Start rbd-target-api and rbd-target-gw - ansible.builtin.systemd: - name: "{{ item }}" - state: started - enabled: true - masked: false - with_items: - - rbd-target-api - - rbd-target-gw diff --git a/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml b/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml deleted file mode 100644 index fce541729a..0000000000 --- a/roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml +++ /dev/null @@ -1,90 +0,0 @@ ---- -- name: Red hat based systems tasks - when: ansible_facts['os_family'] == 'RedHat' - block: - - name: Set_fact common_pkgs - ansible.builtin.set_fact: - common_pkgs: - - tcmu-runner - - targetcli - - - name: Set_fact base iscsi pkgs if new style ceph-iscsi - ansible.builtin.set_fact: - iscsi_base: - - ceph-iscsi - when: use_new_ceph_iscsi | bool - - - name: Set_fact base iscsi pkgs if using older ceph-iscsi-config - ansible.builtin.set_fact: - iscsi_base: - - ceph-iscsi-cli - - ceph-iscsi-config - when: not use_new_ceph_iscsi | bool - - - name: When ceph_iscsi_config_dev is true - when: - - ceph_origin == 'repository' - - ceph_repository in ['dev', 'community'] - - ceph_iscsi_config_dev | bool - block: - - name: Ceph-iscsi dependency repositories - ansible.builtin.get_url: - url: "https://shaman.ceph.com/api/repos/tcmu-runner/main/latest/{{ ansible_facts['distribution'] | lower }}/{{ ansible_facts['distribution_major_version'] }}/repo?arch={{ ansible_facts['architecture'] }}" - dest: '/etc/yum.repos.d/tcmu-runner-dev.repo' - force: true - mode: "0644" - register: result - until: result is succeeded - - - name: Ceph-iscsi development repository - ansible.builtin.get_url: - url: "https://shaman.ceph.com/api/repos/{{ item }}/main/latest/{{ ansible_facts['distribution'] | lower }}/{{ ansible_facts['distribution_major_version'] }}/repo" - dest: '/etc/yum.repos.d/{{ item }}-dev.repo' - force: true - mode: "0644" - register: result - until: result is succeeded - with_items: '{{ iscsi_base }}' - when: ceph_repository == 'dev' - - - name: Ceph-iscsi stable repository - ansible.builtin.get_url: - url: "https://download.ceph.com/ceph-iscsi/{{ '3' if use_new_ceph_iscsi | bool else '2' }}/rpm/el{{ ansible_facts['distribution_major_version'] }}/ceph-iscsi.repo" - dest: /etc/yum.repos.d/ceph-iscsi.repo - force: true - mode: "0644" - register: result - until: result is succeeded - when: ceph_repository == 'community' - - - name: Install ceph iscsi package - ansible.builtin.package: - name: "{{ common_pkgs + iscsi_base }}" - state: "{{ (upgrade_ceph_packages | bool) | ternary('latest', 'present') }}" - register: result - until: result is succeeded - -- name: Check the status of the target.service override - ansible.builtin.stat: - path: /etc/systemd/system/target.service - register: target - -- name: Mask the target service - preventing manual start - ansible.builtin.systemd: - name: target - masked: true - enabled: false - when: - - target.stat.exists - - not target.stat.islnk - -# Only start tcmu-runner, so configure_iscsi.yml can create disks. -# We must start rbd-target-gw/api after configure_iscsi.yml to avoid -# races where they are both trying to setup the same object during -# a rolling update. -- name: Start tcmu-runner - ansible.builtin.systemd: - name: tcmu-runner - state: started - enabled: true - masked: false diff --git a/roles/ceph-iscsi-gw/tasks/systemd.yml b/roles/ceph-iscsi-gw/tasks/systemd.yml deleted file mode 100644 index 2fc75f6ea8..0000000000 --- a/roles/ceph-iscsi-gw/tasks/systemd.yml +++ /dev/null @@ -1,15 +0,0 @@ ---- -- name: Generate systemd unit files for tcmu-runner, rbd-target-api and rbd-target-gw - ansible.builtin.template: - src: "{{ role_path }}/templates/{{ item }}.service.j2" - dest: /etc/systemd/system/{{ item }}.service - owner: "root" - group: "root" - mode: "0644" - with_items: - - tcmu-runner - - rbd-target-gw - - rbd-target-api - notify: - - Restart ceph tcmu-runner - - Restart ceph rbd-target-api-gw diff --git a/roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2 b/roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2 deleted file mode 100644 index 82c564d0a0..0000000000 --- a/roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2 +++ /dev/null @@ -1,30 +0,0 @@ -# This is seed configuration used by the ceph_iscsi_config modules -# when handling configuration tasks for iscsi gateway(s) -# -# {{ ansible_managed }} - -[config] -cluster_name = {{ cluster }} - -pool = {{ iscsi_pool_name }} - -# API settings. -# The API supports a number of options that allow you to tailor it to your -# local environment. If you want to run the API under https, you will need to -# create cert/key files that are compatible for each iSCSI gateway node, that is -# not locked to a specific node. SSL cert and key files *must* be called -# 'iscsi-gateway.crt' and 'iscsi-gateway.key' and placed in the '/etc/ceph/' directory -# on *each* gateway node. With the SSL files in place, you can use 'api_secure = true' -# to switch to https mode. - -# To support the API, the bear minimum settings are: -api_secure = {{ api_secure }} - -# Optional settings related to the CLI/API service -api_user = {{ api_user }} -api_password = {{ api_password }} -api_port = {{ api_port }} -loop_delay = {{ loop_delay }} -{% if trusted_ip_list is defined %} -trusted_ip_list = {{ trusted_ip_list }} -{% endif %} \ No newline at end of file diff --git a/roles/ceph-iscsi-gw/templates/rbd-target-api.service.j2 b/roles/ceph-iscsi-gw/templates/rbd-target-api.service.j2 deleted file mode 100644 index 5683a0402a..0000000000 --- a/roles/ceph-iscsi-gw/templates/rbd-target-api.service.j2 +++ /dev/null @@ -1,58 +0,0 @@ -[Unit] -Description=RBD Target API Service -{% if container_binary == 'docker' %} -After=docker.service network-online.target local-fs.target time-sync.target -Requires=docker.service -{% else %} -After=network-online.target local-fs.target time-sync.target -{% endif %} -Wants=network-online.target local-fs.target time-sync.target - -[Service] -EnvironmentFile=-/etc/environment -{% if container_binary == 'podman' %} -ExecStartPre=-/usr/bin/rm -f /%t/%n-pid /%t/%n-cid -ExecStartPre=-/usr/bin/{{ container_binary }} rm --storage rbd-target-api -ExecStartPre=-/usr/bin/mkdir -p /var/log/rbd-target-api -{% else %} -ExecStartPre=-/usr/bin/{{ container_binary }} stop rbd-target-api -{% endif %} -ExecStartPre=-/usr/bin/{{ container_binary }} rm rbd-target-api -ExecStartPre=-/usr/bin/sh -c "if ! grep -qs /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} /proc/mounts; then mount -t configfs none /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}; fi" -ExecStart=/usr/bin/{{ container_binary }} run --rm \ -{% if container_binary == 'podman' %} - -d --log-driver journald --conmon-pidfile /%t/%n-pid --cidfile /%t/%n-cid \ -{% endif %} - --pids-limit={{ 0 if container_binary == 'podman' else -1 }} \ - --memory={{ ceph_rbd_target_api_docker_memory_limit }} \ - --cpus={{ ceph_rbd_target_api_docker_cpu_limit }} \ - -v /etc/localtime:/etc/localtime:ro \ - --privileged \ - --net=host \ - -v /dev:/dev \ - -v /dev/log:/dev/log \ - -v /lib/modules:/lib/modules \ - -v /etc/ceph:/etc/ceph \ - -v /var/log/rbd-target-api:/var/log/rbd-target-api:z \ - -v /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}:/sys/kernel/config \ - --name=rbd-target-api \ - --entrypoint=/usr/bin/rbd-target-api \ - {{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }} -{% if container_binary == 'podman' %} -ExecStop=-/usr/bin/sh -c "/usr/bin/{{ container_binary }} rm -f `cat /%t/%n-cid`" -{% else %} -ExecStopPost=-/usr/bin/{{ container_binary }} stop rbd-target-api -{% endif %} -ExecStopPost=-/usr/bin/sh -c "if grep -qs /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} /proc/mounts; then umount /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}; fi" -KillMode=none -Restart=always -RestartSec=10s -TimeoutStartSec=120 -TimeoutStopSec=15 -{% if container_binary == 'podman' %} -Type=forking -PIDFile=/%t/%n-pid -{% endif %} - -[Install] -WantedBy=multi-user.target diff --git a/roles/ceph-iscsi-gw/templates/rbd-target-gw.service.j2 b/roles/ceph-iscsi-gw/templates/rbd-target-gw.service.j2 deleted file mode 100644 index 1d3a386a50..0000000000 --- a/roles/ceph-iscsi-gw/templates/rbd-target-gw.service.j2 +++ /dev/null @@ -1,58 +0,0 @@ -[Unit] -Description=RBD Target Gateway Service -{% if container_binary == 'docker' %} -After=docker.service network-online.target local-fs.target time-sync.target -Requires=docker.service -{% else %} -After=network-online.target local-fs.target time-sync.target -{% endif %} -Wants=network-online.target local-fs.target time-sync.target - -[Service] -EnvironmentFile=-/etc/environment -{% if container_binary == 'podman' %} -ExecStartPre=-/usr/bin/rm -f /%t/%n-pid /%t/%n-cid -ExecStartPre=-/usr/bin/{{ container_binary }} rm --storage rbd-target-gw -ExecStartPre=-/usr/bin/mkdir -p /var/log/rbd-target-gw -{% else %} -ExecStartPre=-/usr/bin/{{ container_binary }} stop rbd-target-gw -{% endif %} -ExecStartPre=-/usr/bin/{{ container_binary }} rm rbd-target-gw -ExecStartPre=-/usr/bin/sh -c "if ! grep -qs /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} /proc/mounts; then mount -t configfs none /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}; fi" -ExecStart=/usr/bin/{{ container_binary }} run --rm \ -{% if container_binary == 'podman' %} - -d --log-driver journald --conmon-pidfile /%t/%n-pid --cidfile /%t/%n-cid \ -{% endif %} - --pids-limit={{ 0 if container_binary == 'podman' else -1 }} \ - --memory={{ ceph_rbd_target_gw_docker_memory_limit }} \ - --cpus={{ ceph_rbd_target_gw_docker_cpu_limit }} \ - -v /etc/localtime:/etc/localtime:ro \ - --privileged \ - --net=host \ - -v /dev:/dev \ - -v /dev/log:/dev/log \ - -v /lib/modules:/lib/modules \ - -v /etc/ceph:/etc/ceph \ - -v /var/log/rbd-target-gw:/var/log/rbd-target-gw:z \ - -v /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}:/sys/kernel/config \ - --name=rbd-target-gw \ - --entrypoint=/usr/bin/rbd-target-gw \ - {{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }} -{% if container_binary == 'podman' %} -ExecStop=-/usr/bin/sh -c "/usr/bin/{{ container_binary }} rm -f `cat /%t/%n-cid`" -{% else %} -ExecStopPost=-/usr/bin/{{ container_binary }} stop rbd-target-gw -{% endif %} -ExecStopPost=-/usr/bin/sh -c "if grep -qs /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} /proc/mounts; then umount /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}; fi" -KillMode=none -Restart=always -RestartSec=10s -TimeoutStartSec=120 -TimeoutStopSec=15 -{% if container_binary == 'podman' %} -Type=forking -PIDFile=/%t/%n-pid -{% endif %} - -[Install] -WantedBy=multi-user.target diff --git a/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2 b/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2 deleted file mode 100644 index 6391021bb3..0000000000 --- a/roles/ceph-iscsi-gw/templates/tcmu-runner.service.j2 +++ /dev/null @@ -1,58 +0,0 @@ -[Unit] -Description=TCMU Runner -{% if container_binary == 'docker' %} -After=docker.service network-online.target local-fs.target time-sync.target -Requires=docker.service -{% else %} -After=network-online.target local-fs.target time-sync.target -{% endif %} -Wants=network-online.target local-fs.target time-sync.target - -[Service] -EnvironmentFile=-/etc/environment -{% if container_binary == 'podman' %} -ExecStartPre=-/usr/bin/rm -f /%t/%n-pid /%t/%n-cid -ExecStartPre=-/usr/bin/{{ container_binary }} rm --storage tcmu-runner -ExecStartPre=-/usr/bin/mkdir -p /var/log/tcmu-runner -{% else %} -ExecStartPre=-/usr/bin/{{ container_binary }} stop tcmu-runner -{% endif %} -ExecStartPre=-/usr/bin/{{ container_binary }} rm tcmu-runner -ExecStartPre=-/usr/bin/sh -c "if ! grep -qs /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} /proc/mounts; then mount -t configfs none /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}; fi" -ExecStart=/usr/bin/{{ container_binary }} run --rm \ -{% if container_binary == 'podman' %} - -d --log-driver journald --conmon-pidfile /%t/%n-pid --cidfile /%t/%n-cid \ -{% endif %} - --pids-limit={{ 0 if container_binary == 'podman' else -1 }} \ - --memory={{ ceph_tcmu_runner_docker_memory_limit }} \ - --cpus={{ ceph_tcmu_runner_docker_cpu_limit }} \ - -v /etc/localtime:/etc/localtime:ro \ - --privileged \ - --net=host \ - -v /dev:/dev \ - -v /lib/modules:/lib/modules \ - -v /etc/ceph:/etc/ceph \ - -v /var/log/tcmu-runner:/var/log/tcmu-runner:z \ - -v /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}:/sys/kernel/config \ - --name=tcmu-runner \ - --entrypoint=tcmu-runner \ - {{ ceph_docker_registry }}/{{ ceph_docker_image }}:{{ ceph_docker_image_tag }} \ - --tcmu-log-dir /var/log/tcmu-runner -{% if container_binary == 'podman' %} -ExecStop=-/usr/bin/sh -c "/usr/bin/{{ container_binary }} rm -f `cat /%t/%n-cid`" -{% else %} -ExecStopPost=-/usr/bin/{{ container_binary }} stop tcmu-runner -{% endif %} -ExecStopPost=-/usr/bin/sh -c "if grep -qs /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }} /proc/mounts; then umount /var/lib/ceph/iscsi.{{ ansible_facts['hostname'] }}; fi" -KillMode=none -Restart=always -RestartSec=10s -TimeoutStartSec=120 -TimeoutStopSec=15 -{% if container_binary == 'podman' %} -Type=forking -PIDFile=/%t/%n-pid -{% endif %} - -[Install] -WantedBy=multi-user.target diff --git a/roles/ceph-prometheus/templates/prometheus.yml.j2 b/roles/ceph-prometheus/templates/prometheus.yml.j2 index 6181dc13b0..2476495bb5 100644 --- a/roles/ceph-prometheus/templates/prometheus.yml.j2 +++ b/roles/ceph-prometheus/templates/prometheus.yml.j2 @@ -31,15 +31,6 @@ scrape_configs: labels: instance: "{{ hostvars[host]['ansible_facts']['nodename'] }}" {% endfor %} -{% if iscsi_gw_group_name in groups %} - - job_name: 'iscsi-gws' - static_configs: -{% for host in groups[iscsi_gw_group_name] %} - - targets: ['{{ host }}:9287'] - labels: - instance: "{{ hostvars[host]['ansible_facts']['nodename'] }}" -{% endfor %} -{% endif %} alerting: alertmanagers: - scheme: http diff --git a/roles/ceph-validate/tasks/check_iscsi.yml b/roles/ceph-validate/tasks/check_iscsi.yml deleted file mode 100644 index 25673ebcf2..0000000000 --- a/roles/ceph-validate/tasks/check_iscsi.yml +++ /dev/null @@ -1,42 +0,0 @@ ---- -- name: Fail on unsupported distribution for iscsi gateways - ansible.builtin.fail: - msg: "iSCSI gateways can only be deployed on Red Hat Enterprise Linux, CentOS or Fedora" - when: ansible_facts['distribution'] not in ['RedHat', 'CentOS', 'Fedora', 'AlmaLinux', 'Rocky'] - -- name: Make sure gateway_ip_list is configured - ansible.builtin.fail: - msg: "you must set a list of IPs (comma separated) for gateway_ip_list" - when: - - gateway_ip_list == '0.0.0.0' - - not containerized_deployment | bool - - not use_new_ceph_iscsi | bool - -- name: Make sure gateway_iqn is configured - ansible.builtin.fail: - msg: "you must set a iqn for the iSCSI target" - when: - - gateway_iqn | length == 0 - - not containerized_deployment | bool - - not use_new_ceph_iscsi | bool - -- name: Fail if unsupported chap configuration - ansible.builtin.fail: - msg: "Mixing clients with CHAP enabled and disabled is not supported." - with_items: "{{ client_connections }}" - when: - - item.status is defined - - item.status == "present" - - item.chap - - " '' in client_connections | selectattr('status', 'match', 'present') | map(attribute='chap') | list" - -- name: Fail on unsupported distribution version for iscsi gateways - ansible.builtin.command: "grep -q {{ item }}=m {% if is_atomic | bool %}/usr/lib/ostree-boot{% else %}/boot{% endif %}/config-{{ ansible_facts['kernel'] }}" - register: iscsi_kernel - changed_when: false - failed_when: iscsi_kernel.rc != 0 - loop: - - CONFIG_TARGET_CORE - - CONFIG_TCM_USER2 - - CONFIG_ISCSI_TARGET - when: ansible_facts['distribution'] in ['RedHat', 'CentOS'] diff --git a/roles/ceph-validate/tasks/main.yml b/roles/ceph-validate/tasks/main.yml index 8b4ad48b54..f0caab90f2 100644 --- a/roles/ceph-validate/tasks/main.yml +++ b/roles/ceph-validate/tasks/main.yml @@ -137,10 +137,6 @@ - inventory_hostname in groups.get(rgw_group_name, []) - rgw_create_pools is defined -- name: Include check_iscsi.yml - ansible.builtin.include_tasks: check_iscsi.yml - when: iscsi_gw_group_name in group_names - - name: Include check_nfs.yml ansible.builtin.include_tasks: check_nfs.yml when: inventory_hostname in groups.get(nfs_group_name, []) diff --git a/site-container.yml.sample b/site-container.yml.sample index b100262634..a50c079a21 100644 --- a/site-container.yml.sample +++ b/site-container.yml.sample @@ -18,7 +18,6 @@ - nfss - rbdmirrors - clients - - iscsigws - mgrs - monitoring @@ -457,46 +456,6 @@ status: "Complete" end: "{{ lookup('pipe', 'date +%Y%m%d%H%M%SZ') }}" -- hosts: - - iscsigws - gather_facts: false - any_errors_fatal: true - become: True - tasks: - # pre-tasks for following imports - - - name: set ceph iscsi gateway install 'In Progress' - run_once: true - set_stats: - data: - installer_phase_ceph_iscsi_gw: - status: "In Progress" - start: "{{ lookup('pipe', 'date +%Y%m%d%H%M%SZ') }}" - - - import_role: - name: ceph-defaults - tags: ['ceph_update_config'] - - import_role: - name: ceph-facts - tags: ['ceph_update_config'] - - import_role: - name: ceph-handler - tags: ['ceph_update_config'] - - import_role: - name: ceph-config - tags: ['ceph_update_config'] - - import_role: - name: ceph-iscsi-gw - - # post-tasks for preceding imports - - post_tasks: - - name: set ceph iscsi gw install 'Complete' - run_once: true - set_stats: - data: - installer_phase_ceph_iscsi_gw: - status: "Complete" - end: "{{ lookup('pipe', 'date +%Y%m%d%H%M%SZ') }}" - - import_playbook: dashboard.yml when: - dashboard_enabled | bool diff --git a/site.yml.sample b/site.yml.sample index a5c2fdd225..8dd7d76e51 100644 --- a/site.yml.sample +++ b/site.yml.sample @@ -20,7 +20,6 @@ - rbdmirrors - clients - mgrs - - iscsigws - monitoring - rgwloadbalancers @@ -440,45 +439,6 @@ status: "Complete" end: "{{ lookup('pipe', 'date +%Y%m%d%H%M%SZ') }}" -- hosts: - - iscsigws - gather_facts: false - become: True - any_errors_fatal: true - pre_tasks: - - name: set ceph iscsi gateway install 'In Progress' - run_once: true - set_stats: - data: - installer_phase_ceph_iscsi_gw: - status: "In Progress" - start: "{{ lookup('pipe', 'date +%Y%m%d%H%M%SZ') }}" - - tasks: - - import_role: - name: ceph-defaults - tags: ['ceph_update_config'] - - import_role: - name: ceph-facts - tags: ['ceph_update_config'] - - import_role: - name: ceph-handler - tags: ['ceph_update_config'] - - import_role: - name: ceph-config - tags: ['ceph_update_config'] - - import_role: - name: ceph-iscsi-gw - - post_tasks: - - name: set ceph iscsi gw install 'Complete' - run_once: true - set_stats: - data: - installer_phase_ceph_iscsi_gw: - status: "Complete" - end: "{{ lookup('pipe', 'date +%Y%m%d%H%M%SZ') }}" - - hosts: - rgwloadbalancers gather_facts: false diff --git a/tests/conftest.py b/tests/conftest.py index 3831b4563d..abed775c5c 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -167,8 +167,8 @@ def node(host, request): if request.node.get_closest_marker('rbdmirror_secondary') and not ceph_rbd_mirror_remote_user: # noqa E501 pytest.skip('Not a valid test for a non-secondary rbd-mirror node') - if request.node.get_closest_marker('ceph_crash') and sanitized_group_names in [['nfss'], ['iscsigws'], ['clients'], ['monitoring']]: - pytest.skip('Not a valid test for nfs, client or iscsigw nodes') + if request.node.get_closest_marker('ceph_crash') and sanitized_group_names in [['nfss'], ['clients'], ['monitoring']]: + pytest.skip('Not a valid test for nfs or client nodes') if request.node.get_closest_marker("no_docker") and docker: pytest.skip( @@ -213,8 +213,6 @@ def pytest_collection_modifyitems(session, config, items): item.add_marker(pytest.mark.rgws) elif "nfs" in test_path: item.add_marker(pytest.mark.nfss) - elif "iscsi" in test_path: - item.add_marker(pytest.mark.iscsigws) elif "grafana" in test_path: item.add_marker(pytest.mark.grafanas) else: diff --git a/tests/functional/add-mdss/container/vagrant_variables.yml b/tests/functional/add-mdss/container/vagrant_variables.yml index a3d6f91936..3b0f83df62 100644 --- a/tests/functional/add-mdss/container/vagrant_variables.yml +++ b/tests/functional/add-mdss/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-mdss/vagrant_variables.yml b/tests/functional/add-mdss/vagrant_variables.yml index 76cf45e0d3..ba9c217849 100644 --- a/tests/functional/add-mdss/vagrant_variables.yml +++ b/tests/functional/add-mdss/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-mgrs/container/vagrant_variables.yml b/tests/functional/add-mgrs/container/vagrant_variables.yml index 13fefabc32..7c5bfe8d05 100644 --- a/tests/functional/add-mgrs/container/vagrant_variables.yml +++ b/tests/functional/add-mgrs/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 1 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-mgrs/vagrant_variables.yml b/tests/functional/add-mgrs/vagrant_variables.yml index f918a063cd..5c0cf696ba 100644 --- a/tests/functional/add-mgrs/vagrant_variables.yml +++ b/tests/functional/add-mgrs/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 1 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-mons/container/vagrant_variables.yml b/tests/functional/add-mons/container/vagrant_variables.yml index 099a4080ee..9f97f3c781 100644 --- a/tests/functional/add-mons/container/vagrant_variables.yml +++ b/tests/functional/add-mons/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-mons/vagrant_variables.yml b/tests/functional/add-mons/vagrant_variables.yml index ce43e35d1b..d9b2582153 100644 --- a/tests/functional/add-mons/vagrant_variables.yml +++ b/tests/functional/add-mons/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-osds/container/vagrant_variables.yml b/tests/functional/add-osds/container/vagrant_variables.yml index 443babdc53..8321f852e3 100644 --- a/tests/functional/add-osds/container/vagrant_variables.yml +++ b/tests/functional/add-osds/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-osds/vagrant_variables.yml b/tests/functional/add-osds/vagrant_variables.yml index f6d232fce4..0a9b76f8ec 100644 --- a/tests/functional/add-osds/vagrant_variables.yml +++ b/tests/functional/add-osds/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-rbdmirrors/container/vagrant_variables.yml b/tests/functional/add-rbdmirrors/container/vagrant_variables.yml index 311d03763f..4d6507affd 100644 --- a/tests/functional/add-rbdmirrors/container/vagrant_variables.yml +++ b/tests/functional/add-rbdmirrors/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-rbdmirrors/vagrant_variables.yml b/tests/functional/add-rbdmirrors/vagrant_variables.yml index 88f3d3bfa1..8866b1a5da 100644 --- a/tests/functional/add-rbdmirrors/vagrant_variables.yml +++ b/tests/functional/add-rbdmirrors/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-rgws/container/vagrant_variables.yml b/tests/functional/add-rgws/container/vagrant_variables.yml index 01b75ea071..6592d0c034 100644 --- a/tests/functional/add-rgws/container/vagrant_variables.yml +++ b/tests/functional/add-rgws/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/add-rgws/vagrant_variables.yml b/tests/functional/add-rgws/vagrant_variables.yml index 50e8f44606..8f4ce54605 100644 --- a/tests/functional/add-rgws/vagrant_variables.yml +++ b/tests/functional/add-rgws/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/all-in-one/container/vagrant_variables.yml b/tests/functional/all-in-one/container/vagrant_variables.yml index 7f48c415f4..ee312ec6f3 100644 --- a/tests/functional/all-in-one/container/vagrant_variables.yml +++ b/tests/functional/all-in-one/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/all-in-one/vagrant_variables.yml b/tests/functional/all-in-one/vagrant_variables.yml index c773ffac91..9f8c447494 100644 --- a/tests/functional/all-in-one/vagrant_variables.yml +++ b/tests/functional/all-in-one/vagrant_variables.yml @@ -8,7 +8,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/all_daemons/container/hosts b/tests/functional/all_daemons/container/hosts index c0c2dd8627..fa75c7d795 100644 --- a/tests/functional/all_daemons/container/hosts +++ b/tests/functional/all_daemons/container/hosts @@ -29,8 +29,5 @@ client1 [rbdmirrors] rbd-mirror0 -[iscsigws] -iscsi-gw0 - [monitoring] mon0 diff --git a/tests/functional/all_daemons/container/vagrant_variables.yml b/tests/functional/all_daemons/container/vagrant_variables.yml index aacdb5eaf1..8e08daa9e1 100644 --- a/tests/functional/all_daemons/container/vagrant_variables.yml +++ b/tests/functional/all_daemons/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 2 -iscsi_gw_vms: 1 mgr_vms: 1 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/all_daemons/hosts b/tests/functional/all_daemons/hosts index d40e5a7d27..aeb10eed6f 100644 --- a/tests/functional/all_daemons/hosts +++ b/tests/functional/all_daemons/hosts @@ -29,8 +29,5 @@ client1 [rbdmirrors] rbd-mirror0 -[iscsigws] -iscsi-gw0 - [ceph_monitoring] mon0 diff --git a/tests/functional/all_daemons/vagrant_variables.yml b/tests/functional/all_daemons/vagrant_variables.yml index 5dcb513b4d..48653bbbb9 100644 --- a/tests/functional/all_daemons/vagrant_variables.yml +++ b/tests/functional/all_daemons/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 2 -iscsi_gw_vms: 1 mgr_vms: 1 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/all_daemons_ipv6/container/hosts b/tests/functional/all_daemons_ipv6/container/hosts index 572b62e2e2..81cf5c2dc0 100644 --- a/tests/functional/all_daemons_ipv6/container/hosts +++ b/tests/functional/all_daemons_ipv6/container/hosts @@ -29,8 +29,5 @@ client1 [rbdmirrors] rbd-mirror0 -[iscsigws] -iscsi-gw0 - [monitoring] mon0 diff --git a/tests/functional/all_daemons_ipv6/container/vagrant_variables.yml b/tests/functional/all_daemons_ipv6/container/vagrant_variables.yml index 46045eab34..de2cccc3bb 100644 --- a/tests/functional/all_daemons_ipv6/container/vagrant_variables.yml +++ b/tests/functional/all_daemons_ipv6/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 2 -iscsi_gw_vms: 1 mgr_vms: 1 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/all_daemons_ipv6/hosts b/tests/functional/all_daemons_ipv6/hosts index e625b8b97a..78b212478e 100644 --- a/tests/functional/all_daemons_ipv6/hosts +++ b/tests/functional/all_daemons_ipv6/hosts @@ -29,8 +29,5 @@ client1 [rbdmirrors] rbd-mirror0 -[iscsigws] -iscsi-gw0 - [ceph_monitoring] mon0 diff --git a/tests/functional/all_daemons_ipv6/vagrant_variables.yml b/tests/functional/all_daemons_ipv6/vagrant_variables.yml index a8e0085fd2..b512776aff 100644 --- a/tests/functional/all_daemons_ipv6/vagrant_variables.yml +++ b/tests/functional/all_daemons_ipv6/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 2 -iscsi_gw_vms: 1 mgr_vms: 1 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/cephadm/hosts b/tests/functional/cephadm/hosts index d338d085ad..28a105b30c 100644 --- a/tests/functional/cephadm/hosts +++ b/tests/functional/cephadm/hosts @@ -24,8 +24,5 @@ nfs0 [rbdmirrors] rbd-mirror0 -[iscsigws] -iscsi-gw0 - [monitoring] mon0 diff --git a/tests/functional/cephadm/vagrant_variables.yml b/tests/functional/cephadm/vagrant_variables.yml index d3d2324648..433e319657 100644 --- a/tests/functional/cephadm/vagrant_variables.yml +++ b/tests/functional/cephadm/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 1 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 0 -iscsi_gw_vms: 1 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/collocation/container/vagrant_variables.yml b/tests/functional/collocation/container/vagrant_variables.yml index fa3af879d4..fb5059e96a 100644 --- a/tests/functional/collocation/container/vagrant_variables.yml +++ b/tests/functional/collocation/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/collocation/vagrant_variables.yml b/tests/functional/collocation/vagrant_variables.yml index bde0433268..a53450e6fe 100644 --- a/tests/functional/collocation/vagrant_variables.yml +++ b/tests/functional/collocation/vagrant_variables.yml @@ -8,7 +8,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/docker2podman/vagrant_variables.yml b/tests/functional/docker2podman/vagrant_variables.yml index b53fa2c8f2..921077308a 100644 --- a/tests/functional/docker2podman/vagrant_variables.yml +++ b/tests/functional/docker2podman/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/external_clients/container/vagrant_variables.yml b/tests/functional/external_clients/container/vagrant_variables.yml index 75da987078..4892f0d089 100644 --- a/tests/functional/external_clients/container/vagrant_variables.yml +++ b/tests/functional/external_clients/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 2 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/external_clients/vagrant_variables.yml b/tests/functional/external_clients/vagrant_variables.yml index f5e2c53af8..827dcc928d 100644 --- a/tests/functional/external_clients/vagrant_variables.yml +++ b/tests/functional/external_clients/vagrant_variables.yml @@ -8,7 +8,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 2 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/infra_lv_create/vagrant_variables.yml b/tests/functional/infra_lv_create/vagrant_variables.yml index 317f215dea..85e074d790 100644 --- a/tests/functional/infra_lv_create/vagrant_variables.yml +++ b/tests/functional/infra_lv_create/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/lvm-auto-discovery/container/vagrant_variables.yml b/tests/functional/lvm-auto-discovery/container/vagrant_variables.yml index fe2e314bc5..516e14c0a0 100644 --- a/tests/functional/lvm-auto-discovery/container/vagrant_variables.yml +++ b/tests/functional/lvm-auto-discovery/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/lvm-auto-discovery/vagrant_variables.yml b/tests/functional/lvm-auto-discovery/vagrant_variables.yml index 0a0a86b9db..5bdaadfa01 100644 --- a/tests/functional/lvm-auto-discovery/vagrant_variables.yml +++ b/tests/functional/lvm-auto-discovery/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/lvm-batch/container/vagrant_variables.yml b/tests/functional/lvm-batch/container/vagrant_variables.yml index f5d63d592b..f53ba8280d 100644 --- a/tests/functional/lvm-batch/container/vagrant_variables.yml +++ b/tests/functional/lvm-batch/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/lvm-batch/vagrant_variables.yml b/tests/functional/lvm-batch/vagrant_variables.yml index 0a0a86b9db..5bdaadfa01 100644 --- a/tests/functional/lvm-batch/vagrant_variables.yml +++ b/tests/functional/lvm-batch/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/lvm-osds/container/vagrant_variables.yml b/tests/functional/lvm-osds/container/vagrant_variables.yml index a0c4d60bfa..d4418d89bd 100644 --- a/tests/functional/lvm-osds/container/vagrant_variables.yml +++ b/tests/functional/lvm-osds/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/lvm-osds/vagrant_variables.yml b/tests/functional/lvm-osds/vagrant_variables.yml index 3c3360d328..b5d3089f28 100644 --- a/tests/functional/lvm-osds/vagrant_variables.yml +++ b/tests/functional/lvm-osds/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/migrate_ceph_disk_to_ceph_volume/vagrant_variables.yml b/tests/functional/migrate_ceph_disk_to_ceph_volume/vagrant_variables.yml index dba68f14d2..2603e244fa 100644 --- a/tests/functional/migrate_ceph_disk_to_ceph_volume/vagrant_variables.yml +++ b/tests/functional/migrate_ceph_disk_to_ceph_volume/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 diff --git a/tests/functional/ooo-collocation/vagrant_variables.yml b/tests/functional/ooo-collocation/vagrant_variables.yml index c9f246ef43..847591200d 100644 --- a/tests/functional/ooo-collocation/vagrant_variables.yml +++ b/tests/functional/ooo-collocation/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 3 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/podman/hosts b/tests/functional/podman/hosts index 5696037c5a..dea6a9e55f 100644 --- a/tests/functional/podman/hosts +++ b/tests/functional/podman/hosts @@ -23,9 +23,6 @@ client1 [rbdmirrors] rbd-mirror0 -[iscsigws] -iscsi-gw0 - [monitoring] mon0 diff --git a/tests/functional/podman/vagrant_variables.yml b/tests/functional/podman/vagrant_variables.yml index fc6b42c03b..a4ff599bdd 100644 --- a/tests/functional/podman/vagrant_variables.yml +++ b/tests/functional/podman/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 2 -iscsi_gw_vms: 1 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/rbdmirror/container/secondary/vagrant_variables.yml b/tests/functional/rbdmirror/container/secondary/vagrant_variables.yml index 36687acd72..2b0423c3b1 100644 --- a/tests/functional/rbdmirror/container/secondary/vagrant_variables.yml +++ b/tests/functional/rbdmirror/container/secondary/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/rbdmirror/container/vagrant_variables.yml b/tests/functional/rbdmirror/container/vagrant_variables.yml index 4528b3629a..eee5c310e3 100644 --- a/tests/functional/rbdmirror/container/vagrant_variables.yml +++ b/tests/functional/rbdmirror/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/rbdmirror/secondary/vagrant_variables.yml b/tests/functional/rbdmirror/secondary/vagrant_variables.yml index 64e5ecbc80..2b8351686e 100644 --- a/tests/functional/rbdmirror/secondary/vagrant_variables.yml +++ b/tests/functional/rbdmirror/secondary/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/rbdmirror/vagrant_variables.yml b/tests/functional/rbdmirror/vagrant_variables.yml index ec7b83dc68..105cad593c 100644 --- a/tests/functional/rbdmirror/vagrant_variables.yml +++ b/tests/functional/rbdmirror/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/shrink_mds/container/vagrant_variables.yml b/tests/functional/shrink_mds/container/vagrant_variables.yml index 31f731a5ab..4bcf2c529c 100644 --- a/tests/functional/shrink_mds/container/vagrant_variables.yml +++ b/tests/functional/shrink_mds/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_mds/vagrant_variables.yml b/tests/functional/shrink_mds/vagrant_variables.yml index c1b8f35ee1..e0a7cf1a88 100644 --- a/tests/functional/shrink_mds/vagrant_variables.yml +++ b/tests/functional/shrink_mds/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_mgr/container/vagrant_variables.yml b/tests/functional/shrink_mgr/container/vagrant_variables.yml index a36398cd53..a26e726692 100644 --- a/tests/functional/shrink_mgr/container/vagrant_variables.yml +++ b/tests/functional/shrink_mgr/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 2 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_mgr/vagrant_variables.yml b/tests/functional/shrink_mgr/vagrant_variables.yml index 09866acced..90c50d27f0 100644 --- a/tests/functional/shrink_mgr/vagrant_variables.yml +++ b/tests/functional/shrink_mgr/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 2 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/shrink_mon/container/vagrant_variables.yml b/tests/functional/shrink_mon/container/vagrant_variables.yml index ae9dd468d7..d63a95a8dc 100644 --- a/tests/functional/shrink_mon/container/vagrant_variables.yml +++ b/tests/functional/shrink_mon/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_mon/vagrant_variables.yml b/tests/functional/shrink_mon/vagrant_variables.yml index b7341e1904..bf0038ad0b 100644 --- a/tests/functional/shrink_mon/vagrant_variables.yml +++ b/tests/functional/shrink_mon/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/shrink_osd/container/vagrant_variables.yml b/tests/functional/shrink_osd/container/vagrant_variables.yml index 29c36eed86..b69ecb35e3 100644 --- a/tests/functional/shrink_osd/container/vagrant_variables.yml +++ b/tests/functional/shrink_osd/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_osd/vagrant_variables.yml b/tests/functional/shrink_osd/vagrant_variables.yml index 584c063e7d..7d7da7a99f 100644 --- a/tests/functional/shrink_osd/vagrant_variables.yml +++ b/tests/functional/shrink_osd/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/shrink_rbdmirror/container/vagrant_variables.yml b/tests/functional/shrink_rbdmirror/container/vagrant_variables.yml index 861fd39fd3..2f16c370f8 100644 --- a/tests/functional/shrink_rbdmirror/container/vagrant_variables.yml +++ b/tests/functional/shrink_rbdmirror/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_rbdmirror/vagrant_variables.yml b/tests/functional/shrink_rbdmirror/vagrant_variables.yml index 7490626ccd..85f92045c6 100644 --- a/tests/functional/shrink_rbdmirror/vagrant_variables.yml +++ b/tests/functional/shrink_rbdmirror/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 1 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/shrink_rgw/container/vagrant_variables.yml b/tests/functional/shrink_rgw/container/vagrant_variables.yml index 05dcd3d4ee..b701d05b49 100644 --- a/tests/functional/shrink_rgw/container/vagrant_variables.yml +++ b/tests/functional/shrink_rgw/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/shrink_rgw/vagrant_variables.yml b/tests/functional/shrink_rgw/vagrant_variables.yml index 5f50c2b59b..41fb2f3462 100644 --- a/tests/functional/shrink_rgw/vagrant_variables.yml +++ b/tests/functional/shrink_rgw/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/subset_update/container/vagrant_variables.yml b/tests/functional/subset_update/container/vagrant_variables.yml index 24f64fa23c..3419fc4e15 100644 --- a/tests/functional/subset_update/container/vagrant_variables.yml +++ b/tests/functional/subset_update/container/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS diff --git a/tests/functional/subset_update/vagrant_variables.yml b/tests/functional/subset_update/vagrant_variables.yml index d1e2cff608..c9105ddf37 100644 --- a/tests/functional/subset_update/vagrant_variables.yml +++ b/tests/functional/subset_update/vagrant_variables.yml @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # INSTALL SOURCE OF CEPH diff --git a/tests/functional/tests/iscsi/__init__.py b/tests/functional/tests/iscsi/__init__.py deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/tests/functional/tests/iscsi/test_iscsi.py b/tests/functional/tests/iscsi/test_iscsi.py deleted file mode 100644 index ec546fbd7e..0000000000 --- a/tests/functional/tests/iscsi/test_iscsi.py +++ /dev/null @@ -1,23 +0,0 @@ -import pytest - - -class TestiSCSIs(object): - - @pytest.mark.no_docker - @pytest.mark.parametrize('pkg', [ - 'ceph-iscsi', - 'targetcli', - 'tcmu-runner' - ]) - def test_iscsi_package_is_installed(self, node, host, pkg): - assert host.package(pkg).is_installed - - @pytest.mark.parametrize('svc', [ - 'rbd-target-api', - 'rbd-target-gw', - 'tcmu-runner' - ]) - def test_iscsi_service_enabled_and_running(self, node, host, svc): - s = host.service(svc) - assert s.is_enabled - assert s.is_running diff --git a/tests/pytest.ini b/tests/pytest.ini index 136a805047..61620b9ebd 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -7,7 +7,6 @@ markers = no_docker: environment without containers docker: environment with containers all: for all nodes - iscsigws: for iscsigw nodes mdss: for mds nodes mgrs: for mgr nodes mons: for mon nodes diff --git a/vagrant_variables.yml.sample b/vagrant_variables.yml.sample index 7fb67acafc..376f3a5825 100644 --- a/vagrant_variables.yml.sample +++ b/vagrant_variables.yml.sample @@ -12,7 +12,6 @@ nfs_vms: 0 grafana_server_vms: 0 rbd_mirror_vms: 0 client_vms: 0 -iscsi_gw_vms: 0 mgr_vms: 0 # SUBNETS TO USE FOR THE VMS