-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode colour assessment #467
Comments
The first area that we can address is to understand the different combinations of content that we expect in the Asides.
Preview: https://feature-dark-mode-a11y.nucleus-docs.pages.dev/components/ns-test/#asides |
In this morning's team catch-up, we ascertained that the following items should be considered: Aim for simple solutions to accelerate completion
|
Set up an area in Figma for assessing (WIP)... |
Asides PR and colours assessed.My suggestions for changes and reasons here: FINE AS IT IS:
REQUIRES CHANGE + SUGGESTIONS:
All pass WCAG contrast then... |
Looking at the tabs - it would be ideal if they used the proposed colours from the palette. This provides a better contrast between a highlight and the track and also is more consistent with the use of Accent colour. |
Form elements currently being reviewed and changes being suggested at https://www.figma.com/file/wyuLUEt3qm01mR8E6Wm2Pf/Nucleus-Docs-exploration---engaging-and-interactive?type=design&node-id=633%3A27629&mode=design&t=wJatGc2xRvcCsvP0-1 |
Added further example visuals and values to form elements. |
Putting on hold temporarily whilst prioritising other work on the docs. |
It was discussed yesterday that the order of the main 4 signposts read order on the home page does not match the read order of the same groups in the LHS nav menu. This should be aligned so that it is familiar to the user. |
Explored and defined more specifics of the backticks design with Drew and agreed on best approach to implement that includes a subtle border and variable background colour dependent on mode. |
I've updated the PR to reflect these updated colours
In order to release this we will raise another ticket related to bringing the dark mode into the Configurator. |
Outcome
A refined and full set of Dark mode colours and directions that work across all applications of it. Tested and ready for launch. Currently, there are some clashes between different astro components for eg. Mastheads and Asides share colours but have different requirements.
Scope
Notes
The text was updated successfully, but these errors were encountered: