Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode colour assessment #467

Closed
4 tasks done
Tracked by #473
RobTobias123 opened this issue Feb 28, 2024 · 12 comments
Closed
4 tasks done
Tracked by #473

Dark mode colour assessment #467

RobTobias123 opened this issue Feb 28, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Documentation Improvements or additions to documentation

Comments

@RobTobias123
Copy link
Contributor

RobTobias123 commented Feb 28, 2024

Outcome

A refined and full set of Dark mode colours and directions that work across all applications of it. Tested and ready for launch. Currently, there are some clashes between different astro components for eg. Mastheads and Asides share colours but have different requirements.

Scope

  • Consider new saturation and Lightness values based on the given Hues
  • Assess impact
  • Test for WCAG contrast compliance
  • Adjust values as required

Notes

  • Switch light/dark toggle back on for this branch/work
  • Assess current set-up - use test.mdx for visual ref.
@RobTobias123 RobTobias123 self-assigned this Feb 28, 2024
@RobTobias123 RobTobias123 added Type: Documentation Improvements or additions to documentation enhancement New feature or request labels Feb 28, 2024
@RobTobias123 RobTobias123 added this to the Internal tools milestone Feb 28, 2024
@andij
Copy link
Contributor

andij commented Mar 6, 2024

The first area that we can address is to understand the different combinations of content that we expect in the Asides.

Preview: https://feature-dark-mode-a11y.nucleus-docs.pages.dev/components/ns-test/#asides

@RobTobias123
Copy link
Contributor Author

RobTobias123 commented Mar 6, 2024

In this morning's team catch-up, we ascertained that the following items should be considered:

Aim for simple solutions to accelerate completion

  • Check the ns-test page for Asides PR and assess current colour usage/behaviour, any additional content (links, backticks etc.) review and suggest.
  • Home page signposts /Masthead consistencies - eg. use dark text for both in dark mode? etc. Review and suggest.
  • Form elements (eg. border strength) review and suggest
  • Example Tabs selected and unselected states review and suggest
  • Pill/Badge - review and suggest - start with the default set but is possible to have standalone values assigned to each type if required (currently connected with Asides colours). Default set = Note, Tip, Danger, Caution, Success.
  • Pill/Badge applied to each of the guideline pages as example to assess all in one place.

@RobTobias123
Copy link
Contributor Author

@RobTobias123
Copy link
Contributor Author

RobTobias123 commented Mar 6, 2024

Asides PR and colours assessed.

My suggestions for changes and reasons here:

https://www.figma.com/file/wyuLUEt3qm01mR8E6Wm2Pf/Nucleus-Docs-exploration---engaging-and-interactive?type=design&node-id=0%3A1&mode=design&t=NUg9tVpTJ3mO1Jtp-1

FINE AS IT IS:

  • Paragraph style Hyperlinks are inheriting heading colours

- Checked for contrast compliance - all ok on aside backgrounds in both light and dark themes. 
- Happy with this behaviour
  • Paragraph text and Backtick text is not as originally specified (using Starlight text values?) but is is close and conforming. 

- Happy to leave as is or change to Navy.

REQUIRES CHANGE + SUGGESTIONS:

  • Backtick style Hyperlinks are inheriting heading colours
- Not conforming as background is too tonally similar IN DARK MODE ONLY.

  • Suggestion: Keep text and hyperlink colours the same but change background-colour to :
    TEAL-800
    HSL 202/40/16

All pass WCAG contrast then...

Image

@RobTobias123
Copy link
Contributor Author

Looking at the tabs - it would be ideal if they used the proposed colours from the palette. This provides a better contrast between a highlight and the track and also is more consistent with the use of Accent colour.

https://www.figma.com/file/wyuLUEt3qm01mR8E6Wm2Pf/Nucleus-Docs-exploration---engaging-and-interactive?type=design&node-id=619%3A27575&mode=design&t=pb3ElDChD7M5gneK-1

Image

@RobTobias123 RobTobias123 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 18, 2024
@RobTobias123
Copy link
Contributor Author

@RobTobias123
Copy link
Contributor Author

@RobTobias123 RobTobias123 added the Status: On Hold Awaiting for clarification or another issue to be resolved label Mar 26, 2024
@RobTobias123
Copy link
Contributor Author

Putting on hold temporarily whilst prioritising other work on the docs.

@RobTobias123
Copy link
Contributor Author

It was discussed yesterday that the order of the main 4 signposts read order on the home page does not match the read order of the same groups in the LHS nav menu. This should be aligned so that it is familiar to the user.

@RobTobias123
Copy link
Contributor Author

Explored and defined more specifics of the backticks design with Drew and agreed on best approach to implement that includes a subtle border and variable background colour dependent on mode.

@RobTobias123
Copy link
Contributor Author

Also included nsx blue values as this affects the Mastheads in the same way too.

Image

@andij
Copy link
Contributor

andij commented Apr 2, 2024

I've updated the PR to reflect these updated colours

In order to release this we will raise another ticket related to bringing the dark mode into the Configurator.

@andij andij removed the Status: On Hold Awaiting for clarification or another issue to be resolved label Apr 2, 2024
@andij andij closed this as completed Apr 2, 2024
@andij andij added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants