Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs content] guidance images #263

Closed
3 tasks done
Tracked by #243
RobTobias123 opened this issue Nov 28, 2023 · 3 comments
Closed
3 tasks done
Tracked by #243

[Docs content] guidance images #263

RobTobias123 opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Documentation Improvements or additions to documentation

Comments

@RobTobias123
Copy link
Contributor

RobTobias123 commented Nov 28, 2023

Outcome

All content-guidance images for components transferred to Astro Docs:
/src/assets/components/ns-xxxx/guidance[-type][-state].webp

Scope

  • Add existing optimised webps to relevant images folder
  • Check and update any that require it
  • Check naming convention is applicable
@RobTobias123 RobTobias123 mentioned this issue Nov 28, 2023
26 tasks
@RobTobias123 RobTobias123 self-assigned this Nov 28, 2023
@RobTobias123 RobTobias123 added this to the Internal tools milestone Nov 28, 2023
@RobTobias123 RobTobias123 added the Type: Documentation Improvements or additions to documentation label Nov 28, 2023
@RobTobias123
Copy link
Contributor Author

Relative to #245

@andij andij changed the title Adding supporting images to components Content guidance images Jan 4, 2024
@RobTobias123 RobTobias123 changed the title Content guidance images [Docs content] guidance images Jan 5, 2024
@andij
Copy link
Contributor

andij commented Jan 8, 2024

At this point time we are going keep the component guidance as simple to 'bring over' as possible.

There have been a number of ideas related to improving the guidance for each component type, most of which are captured in ticket #253.

Additionally there are a few mock-ups noted here: #280#issuecomment-1870112833

@RobTobias123
Copy link
Contributor Author

All current guidance images have been added to PR #317, including experiences (nsx) and deprecated components. Note that there are no current images for a couple of the components such as ns-tab and ns-header (although there is one for nsx-header), and some were not uploaded as not required due to being replaced with sufficient HTML examples such as ns-inputter. I consider these to be up to date with the changes made to components for Nucleus v3.0 (eg. some ns-landmark size and spacing changed) and I have also added the new component of ns-action-link.

@RobTobias123 RobTobias123 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants