-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other assets (image templates for lockup/landmark/etc..) #254
Comments
@andij @MekalaNagarajan-Centrica With reference to yesterday's conversation regarding location of images I've explored a few options this morning... Image location optionsWhat would be the right structure? Github:An image hosted on GitHub full path (example): In the assets folder:Assets located image. This seems a long way away and needs untidy and prone to typos 4 x ../ on the link. Closer together in components/images/ns-accordion folder:This location is similar to the existing docs. components/images/ns-accordion located image. In the same folder components/ns-accordion/images:Third possible way could be to include even closer in the components/ns-accordion folder alongside the .md files. I was concerned this might then appear in the right hand side links for ‘On this page’ but it doesn’t. So this would be my preferred option I think as it’s right next to the doc md files using this image. components/ns-accordion/images located image @andij - I know you mentioned that it needed to work in GitHub too. Do you have an example path? I put the one in first, above but not sure if that’s what you meant? It would make sense to me if the images are stored in docs alongside the mds. |
There is some guidance in the Astro docs related to the location of assets. https://docs.astro.build/en/guides/images/#overview |
Point to be aware of: The width of the main content panel in Astro is smaller than the current docs, making images smaller. Images may require re-scaling if things look too small, if that's the case we would need to revise the agreed consistent size and scale with which we display. |
Is there any difference between this favicon and the one that exists for the current Docs? |
Visually, no. Format, yes. Following the existing format (SVG) used on the default starlight favicon, I replaced it with a Nucleus SVG. I did initially try a .ico but didn't appear to work. |
Identified asset types:Template:Ns-image placeholders (JPGs) Video:Foundations/typography Drew re Modular Scale Emojis:Foundations/viewports Components images (webp):
Foundations images (webp):
Patterns images (webp)
|
As suspected, the image formats work as follows: Supported formats tried and that work: WEBP, JPG, PNG, GIF Image formats that do not work: PSD |
Outcome
Discovery piece: Understand where document images, templates etc. should be located in the most logical and optimal place for required usage.
Scope
The text was updated successfully, but these errors were encountered: