Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change helpText from prop to slot in NameAndDescInputModalForm #1903

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

KAIMonmoy
Copy link
Contributor

Fixes #1858

This PR chnages helpText from prop to named slot in NameAndDescInputModalForm. It also modifies AddEditSchemaModal to pass the helpText as a named slot to NameAndDescInputModalForm instead of a prop.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

- Use a div instead of a span so that we can compose flow content.
- Don't name the slot since there's only one slot.
- Simplify references to <Alert>, removing unnecessary code.
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @KAIMonmoy. I added a couple small commits, cleaning some things up. Take a look at them to see what I did and let me know if you have any questions.

Thanks for this PR! We welcome more contributions!

@seancolsen seancolsen enabled auto-merge November 7, 2022 14:31
@seancolsen seancolsen merged commit 527482e into mathesar-foundation:master Nov 7, 2022
@KAIMonmoy
Copy link
Contributor Author

Looks good, @KAIMonmoy. I added a couple small commits, cleaning some things up. Take a look at them to see what I did and let me know if you have any questions.

Thanks for this PR! We welcome more contributions!

Hey @seancolsen , thanks for all the help. I should have taken care of the clean-ups, my bad! I understood what you did in the commits you made.
It felt really great working with you. I would definitely like to contribute more to this project. You can point me to an issue that you need help with or you think is suitable for me, and I'll be happy to work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Change helpText from prop to slot in NameAndDescInputModalForm
3 participants