Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Drop negative bucket bounds and negative values in record API #963

Closed
mayurkale22 opened this issue Oct 31, 2018 · 0 comments
Closed

Drop negative bucket bounds and negative values in record API #963

mayurkale22 opened this issue Oct 31, 2018 · 0 comments
Assignees

Comments

@mayurkale22
Copy link
Member

Negative values are currently not supported by any of the backends that we support and have histograms (Stackdriver and Prometheus). We have decided to implement a backwards incompatible change and drop negative values in the Record API (We will start with logging an error for few versions then throw an exception).

This could be a breaking change if users are recording negative value for any measure. We planned to implement this change asap in all the libraries and explain this behaviour to the current users very clearly.

Counterpart in Java: census-instrumentation/opencensus-java#1499 and census-instrumentation/opencensus-java#1525

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants