This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Adds an exported function to flush interval reader #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
reviewed
Jan 12, 2021
quentin-cha
changed the title
quentin-cha
force-pushed
the
add_flush_to_internal_reader
branch
from
51c2164
to
f2ed150
Compare
dashpole
approved these changes
Jan 22, 2021
dashpole
reviewed
Jan 22, 2021
|
whoops. one more comment, then i'll merge |
quentin-cha
force-pushed
the
add_flush_to_internal_reader
branch
from
f2ed150
to
17f0714
Compare
|
Thank you so much your help! |
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix (bit hacky) to get me closer to fixing census-ecosystem/opencensus-go-exporter-stackdriver#43,
by providing an exported function on
IntervalReaderto flush its content.It doesn't change any existing behavior of
IntervalReader, it only adds a way for the owner ofIntervalReaderto flush its content when needed.