Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Runmetrics: Expand to Include GC Stats #1188

Open
dm03514 opened this issue Dec 13, 2019 · 7 comments
Open

Runmetrics: Expand to Include GC Stats #1188

dm03514 opened this issue Dec 13, 2019 · 7 comments

Comments

@dm03514
Copy link

dm03514 commented Dec 13, 2019

Is your feature request related to a problem? Please describe.
Greetings! I just started using opencensus in go. The quality and framework was super easy to use, the primitives are intuitive and there are great docs! One thing I noticed was that runtime (runmetrics) metrics didn't include GC information. I'm wondering if runmetrics are a good place to include these metrics?

Describe the solution you'd like
If runmetrics is a good place to include these metrics, I was hoping to have gc stats included in the runtime metrics exported.

Describe alternatives you've considered
I could pretty easily instrument these in my own application, even package it as a library so all my go apps could easily get these metrics.

Additional context

This request is based on the runtime metrics that prometheus go client ships with.

Can see the prometheus metrics in action on their grafana dashboard:

go_processes


Thank you!!!

@dm03514
Copy link
Author

dm03514 commented Dec 13, 2019

If you're open to this, I'd be happy to contribute it

@dm03514 dm03514 changed the title Runmetrics: Expand to Include Goroutine & GC Stats Runmetrics: Expand to Include GC Stats Dec 13, 2019
@rghetia
Copy link
Contributor

rghetia commented Dec 17, 2019

If you're open to this, I'd be happy to contribute it (will try and tackle it next week)

sure.

@hougaardj
Copy link

Any idea when/if the pull request will be merged? The GC metrics are very useful to have.

@punya
Copy link
Contributor

punya commented Feb 12, 2021

@hougaardj I just merged the PR. Are you able to test it out from the master branch, or do you need a tagged RC?

@hougaardj
Copy link

hougaardj commented Feb 15, 2021

Thank you for the quick turn around :)

I have tested it from master branch and i got the additional metrics. I do need a tagged release to start using it proper.

@hougaardj
Copy link

@punya Can we create a release?

@punya
Copy link
Contributor

punya commented Feb 24, 2021

@hougaardj we just published v0.23.0 (release notes).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants