This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 327
Runmetrics: Expand to Include GC Stats #1188
Labels
Comments
If you're open to this, I'd be happy to contribute it |
dm03514
changed the title
Runmetrics: Expand to Include Goroutine & GC Stats
Runmetrics: Expand to Include GC Stats
Dec 13, 2019
sure. |
Any idea when/if the pull request will be merged? The GC metrics are very useful to have. |
@hougaardj I just merged the PR. Are you able to test it out from the master branch, or do you need a tagged RC? |
Thank you for the quick turn around :) I have tested it from master branch and i got the additional metrics. I do need a tagged release to start using it proper. |
@punya Can we create a release? |
@hougaardj we just published v0.23.0 (release notes). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
Greetings! I just started using opencensus in go. The quality and framework was super easy to use, the primitives are intuitive and there are great docs! One thing I noticed was that runtime (
runmetrics
) metrics didn't include GC information. I'm wondering ifrunmetrics
are a good place to include these metrics?Describe the solution you'd like
If
runmetrics
is a good place to include these metrics, I was hoping to have gc stats included in the runtime metrics exported.Describe alternatives you've considered
I could pretty easily instrument these in my own application, even package it as a library so all my go apps could easily get these metrics.
Additional context
This request is based on the runtime metrics that prometheus go client ships with.
Can see the prometheus metrics in action on their grafana dashboard:
Thank you!!!
The text was updated successfully, but these errors were encountered: