This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Upgrade deps, add tools to code to pin version, change to use golangci #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
fixdeps
branch
3 times, most recently
from
9a67446 to
5035c62
Compare
bogdandrutu
commented
Mar 8, 2021
| @@ -3,7 +3,7 @@ language: go | |||
| go_import_path: contrib.go.opencensus.io | |||
|
|
|||
| go: | |||
| - 1.11.x | |||
| - 1.15.x | |||
There was a problem hiding this comment.
go 1.15 is required only for lint, so the go.mod is still not changed
punya
reviewed
Mar 9, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
|
@punya I pushed a second commit which splits internal/tools in its own module so tools are not polluting the main go mod/sum |
Signed-off-by: Bogdan Drutu <[email protected]>
punya
approved these changes
Mar 9, 2021
This was referenced Mar 10, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]