Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate withdrawable funds #57

Open
m-chrzan opened this issue Aug 31, 2022 · 0 comments
Open

Aggregate withdrawable funds #57

m-chrzan opened this issue Aug 31, 2022 · 0 comments
Labels

Comments

@m-chrzan
Copy link
Contributor

Currently, when completing a withdrawal, funds are immediately sent to the user as soon as they're available (so a potential immediate withdrawal at Manager.withdraw time, then once per each Account.finishPendingWithdrawal). This is fine for direct interactions with the smart contracts, but can lead wallet users to confusion when they see their withdrawn CELO appear in their wallet across multiple transactions spread over time.

Instead, we could keep an account of how much CELO is withdrawable by each address, and allow funds to be sent to the beneficiary at their request, e.g. after an entire withdrawal finishes.

@m-chrzan m-chrzan changed the title Collect withdrawable funds Aggregate withdrawable funds Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant