Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move away from web3 EPIC #64

Open
3 of 6 tasks
aaronmgdr opened this issue Jan 12, 2024 · 5 comments
Open
3 of 6 tasks

move away from web3 EPIC #64

aaronmgdr opened this issue Jan 12, 2024 · 5 comments

Comments

@aaronmgdr
Copy link
Member

aaronmgdr commented Jan 12, 2024

Currently on web3 1.10.3 (final version for 1.x) we need to move away for security

There are api changes which nessessaitate some design thinking on how we re build on top of the new version

https://docs.web3js.org/guides/web3_upgrade_guide/x/

#361 is technically in this but is its own epic

@aaronmgdr
Copy link
Member Author

this is a mega big upgrade

@aaronmgdr aaronmgdr self-assigned this Apr 2, 2024
@aaronmgdr
Copy link
Member Author

aaronmgdr commented Apr 2, 2024

reading over the upgrade guide and guide to create transaction plugins for web3 v4. i think the signing that happens in wallet-base would become a web3 plugin @celo/web3-plugin-gas-tokens if wallet-base was the only wallet-*** package i would say thats all there was to it however...

the celo/wallet- system of packages is a bit hard to move as it doesnt really correspond as far as i see with uses of the term wallet in web3 (or ethers or viem) they are kinds like signers in the sense that the signTransaction is in them. maybe they can go away? but will need to make sure hsm signers and ledger signing and all that still work. which will be tricky to test

@aaronmgdr
Copy link
Member Author

aaronmgdr commented Apr 4, 2024

potentially blocked by #220

although we could possibly get around it by

  1. doing the upgrades in dt repo
  2. releasing beta
  3. using beta in socialconnect repo
  4. upgrading web3 in sc repo
  5. releasing updated identity package as a beta
  6. using that identity beta in dt repo for cli
  7. releasing full prod releases from dt repo.

@aaronmgdr aaronmgdr changed the title chore(deps): update dependency web3 to v4 EPIC update dependency web3 to v4 Apr 16, 2024
@aaronmgdr
Copy link
Member Author

pausing for now

@aaronmgdr aaronmgdr removed their assignment Jul 17, 2024
@aaronmgdr aaronmgdr added the epic label Jul 22, 2024
@aaronmgdr aaronmgdr self-assigned this Jul 22, 2024
@nicolasbrugneaux nicolasbrugneaux changed the title EPIC update dependency web3 to v4 update dependency web3 to v4 Jul 22, 2024
@aaronmgdr aaronmgdr changed the title update dependency web3 to v4 move away from web3 v1. (requires refactor) Jul 23, 2024
@aaronmgdr
Copy link
Member Author

obvious move is to web3 v1. however given the complexity at this point its likely not more difficult to move to contractkit / cli being powered by viem,

@aaronmgdr aaronmgdr changed the title move away from web3 v1. (requires refactor) move away from web3 EPIC Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants