From 1e4f79d3602117e7576ca6df6cbf9b01dac6f929 Mon Sep 17 00:00:00 2001 From: Karl Bartel Date: Tue, 28 Feb 2023 14:41:48 +0100 Subject: [PATCH] Remove minimum client version test --- .../blockchain_parameters_test.go | 21 ------------------- contracts/testutil/blockchain_parameters.go | 3 --- 2 files changed, 24 deletions(-) diff --git a/contracts/blockchain_parameters/blockchain_parameters_test.go b/contracts/blockchain_parameters/blockchain_parameters_test.go index 52ccd8d5de..1a22687d5d 100644 --- a/contracts/blockchain_parameters/blockchain_parameters_test.go +++ b/contracts/blockchain_parameters/blockchain_parameters_test.go @@ -10,27 +10,6 @@ import ( . "github.com/onsi/gomega" ) -func TestGetMinimumVersion(t *testing.T) { - testutil.TestFailOnFailingRunner(t, getMinimumVersion) - testutil.TestFailsWhenContractNotDeployed(t, contracts.ErrSmartContractNotDeployed, getMinimumVersion) - - t.Run("should return minimum version", func(t *testing.T) { - g := NewGomegaWithT(t) - - runner := testutil.NewSingleMethodRunner( - params.BlockchainParametersRegistryId, - "getMinimumClientVersion", - func() (*big.Int, *big.Int, *big.Int) { - return big.NewInt(5), big.NewInt(4), big.NewInt(3) - }, - ) - - version, err := getMinimumVersion(runner) - g.Expect(err).ToNot(HaveOccurred()) - g.Expect(version).To(Equal(¶ms.VersionInfo{Major: 5, Minor: 4, Patch: 3})) - }) -} - func TestGetIntrinsicGasForAlternativeFeeCurrency(t *testing.T) { testutil.TestFailOnFailingRunner(t, getIntrinsicGasForAlternativeFeeCurrency) testutil.TestFailsWhenContractNotDeployed(t, contracts.ErrSmartContractNotDeployed, getIntrinsicGasForAlternativeFeeCurrency) diff --git a/contracts/testutil/blockchain_parameters.go b/contracts/testutil/blockchain_parameters.go index fef8c1eb0e..df43c4bd67 100644 --- a/contracts/testutil/blockchain_parameters.go +++ b/contracts/testutil/blockchain_parameters.go @@ -29,9 +29,6 @@ func NewBlockchainParametersMock() *BlockchainParametersMock { return mock } -func (bp *BlockchainParametersMock) GetMinimumClientVersion() (*big.Int, *big.Int, *big.Int) { - return big.NewInt(int64(bp.MinimumVersion.Major)), big.NewInt(int64(bp.MinimumVersion.Minor)), big.NewInt(int64(bp.MinimumVersion.Patch)) -} func (bp *BlockchainParametersMock) BlockGasLimit() *big.Int { return bp.BlockGasLimitValue }