Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: use struct for our private implementations rather than class #1288

Open
agarny opened this issue Oct 30, 2024 · 0 comments
Open

C++: use struct for our private implementations rather than class #1288

agarny opened this issue Oct 30, 2024 · 0 comments

Comments

@agarny
Copy link
Contributor

agarny commented Oct 30, 2024

Component::ComponentImpl, for instance, is declared using the class keyword. Yet, we only use public access. So, we could use struct instead of class (and thus not have to specify public access), as we do for Generator::GeneratorImpl for instance.

So, here, we want to replace all of our occurrences of class with struct when it comes to the private implementation of our various classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant