Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from FIFO to prioritized mempool #161

Closed
rootulp opened this issue Nov 10, 2022 · 5 comments
Closed

Switch from FIFO to prioritized mempool #161

rootulp opened this issue Nov 10, 2022 · 5 comments

Comments

@rootulp
Copy link
Collaborator

rootulp commented Nov 10, 2022

Context

We'd like validators to use the prioritized mempool see celestiaorg/celestia-app#590 (comment)

Problem

Arabica (and potentially most validators on Mamaki) use the default FIFO mempool.

Proposal

We'd like our testnets to be representative of the parameters used on mainnet so we should update the Arabica validator to use the prioritized mempool (i.e. version: "v1"). If possible, we should also update any default configuration so that as many validators as possible on Mamaki update to using the prioritized mempool.

@evan-forbes
Copy link
Member

@rootulp should we move this to a different repo given that the defaults are not picked here? or is this issue indicating something else?

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 15, 2022

This issue was intended to override the default config on validators for networks like Arabica / Mamaki. If we still want this, which other repo? It doesn't look like https://github.com/celestiaorg/celestia-sre contains configs for validators either.

If we don't want this, we can close this issue and update the default config in celestia-app and wait until the networks upgrade to versions of celestia-app cut with the default changed.

@evan-forbes
Copy link
Member

evan-forbes commented Nov 15, 2022

imo we can close since we have celestiaorg/celestia-app#1008

@evan-forbes
Copy link
Member

oh I see, we'd close this issue after we update the arabica validator

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 15, 2022

Yea, I'm okay with closing this given we already merged celestiaorg/celestia-app#1008
Since this issue isn't in a repo we maintain, feel free to re-open and transfer if you want to track it.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants