Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the func (s *Service) Included() method after migration from heights to hashes #3919

Open
rach-id opened this issue Nov 5, 2024 · 0 comments
Open

deprecate the func (s *Service) Included() method after migration from heights to hashes #3919

rach-id opened this issue Nov 5, 2024 · 0 comments
Labels
area:blob enhancement New feature or request

Comments

@rach-id
Copy link
Member

rach-id commented Nov 5, 2024 

          Since our API operates with header's height, deprecating this method requires users to download the header to get the hash.

So, I agree that we can deprecate this method in favour of proof public validate methods but only after migration from heights to hashes.

Originally posted by @vgonkivs in #3821 (comment)
@rach-id rach-id mentioned this issue Nov 5, 2024
Open
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Nov 5, 2024
@vgonkivs vgonkivs added area:blob enhancement New feature or request and removed needs:triage external Issues created by non node team members labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:blob enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rach-id @vgonkivs