Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter version in v0.34 branch and fix typos #678

Closed
adlerjohn opened this issue Apr 11, 2022 · 2 comments
Closed

Update linter version in v0.34 branch and fix typos #678

adlerjohn opened this issue Apr 11, 2022 · 2 comments
Labels
C:CI Continuous integration and automation related issues

Comments

@adlerjohn
Copy link
Member

3517804
@adlerjohn adlerjohn added the C:CI Continuous integration and automation related issues label Apr 11, 2022
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 11, 2022
@adlerjohn
Copy link
Member Author

Is this still needed @evan-forbes, or can we close since v0.34 is no longer in use?

@rootulp
Copy link
Collaborator

rootulp commented Apr 20, 2023

https://github.com/celestiaorg/celestia-core/tree/v0.34.x-celestia will be used for mainnet. Versions of go and golangci-lint in this repo match upstream. We do still need to fix lint issues which can be tracked in #1000

Ref:

  1. https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/.github/workflows/lint.yml
  2. https://github.com/cometbft/cometbft/blob/v0.34.27/.github/workflows/lint.yml

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Apr 20, 2023
@rootulp rootulp removed this from Celestia Node Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CI Continuous integration and automation related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adlerjohn @rootulp @evan-forbes