Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override upgrade height delay for local devnets #4053

Open
rootulp opened this issue Nov 25, 2024 · 3 comments · May be fixed by #4065
Open

Override upgrade height delay for local devnets #4053

rootulp opened this issue Nov 25, 2024 · 3 comments · May be fixed by #4065
Assignees
Labels
good first issue Good for newcomers priority:low optional label to track the relative priority of planned items proposal item is not yet actionable and is suggesting a change that must first be agreed upon

Comments

@rootulp
Copy link
Collaborator

rootulp commented Nov 25, 2024

Context

After the signal module receives a successful MsgTryUpgrade, there is an upgrade height delay of N blocks before the state machine upgrades from v2 -> v3

Problem

The upgrade height delay is too long for testing and local development purposes.

Proposal

For local devnets (i.e. one started via ./single-node.sh) consider overriding the upgrade height delay to something like 1 block.

@rootulp rootulp added good first issue Good for newcomers proposal item is not yet actionable and is suggesting a change that must first be agreed upon priority:low optional label to track the relative priority of planned items labels Nov 25, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 25, 2024

Related: #3979

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 27, 2024

Looks like we can do this in two ways:

  1. Via OverrideUpgradeHeightDelayStr
  2. Via special casing the upgrade height for blockchains with the chain-id "test" in here

@rootulp rootulp self-assigned this Nov 27, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 27, 2024

It's a bit confusing that we have multiple ways to override this field. In a call right after I got back from vacation, I recall discussing this with @evan-forbes @cmwaters and pretty sure we agreed to use the chain-id to override configs so I plan on removing the ability to override the upgrade height via OverrideUpgradeHeightDelayStr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:low optional label to track the relative priority of planned items proposal item is not yet actionable and is suggesting a change that must first be agreed upon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant