Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedicated feature branch for e2e benchmark tests with main branch sync #3371

Closed
staheri14 opened this issue Apr 23, 2024 · 3 comments · Fixed by #3612
Closed

Dedicated feature branch for e2e benchmark tests with main branch sync #3371

staheri14 opened this issue Apr 23, 2024 · 3 comments · Fixed by #3612
Assignees
@staheri14
Labels
priority:high optional label to track the relative priority of planned items WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@staheri14
Copy link
Contributor

In the Knuu e2e benchmark tests, we sometimes encounter the need to use versions of celestia-core that include unreleased breaking changes or features not fully integrated into celestia-app. This situation becomes a barrier to developing and merging benchmark tests into the celestia-app main branch. To address this issue, a decision has been made to establish a feature branch specifically for benchmark tests. Future PRs will be directed to this branch, facilitating seamless integrations without affecting the main branch of celestia-app.

Additionally, it would be useful to have an automated way to backport features from the main branch to this new feature branch, ensuring it remains up-to-date with the latest developments in the main.
@evan-forbes evan-forbes added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label Apr 25, 2024
@staheri14 staheri14 self-assigned this May 6, 2024
@evan-forbes evan-forbes added priority:high optional label to track the relative priority of planned items and removed needs:priority labels May 6, 2024
@evan-forbes
Copy link
Member

the goal is to merge this feature branch after v2

@evan-forbes
Copy link
Member

we can unblock with #3370

@staheri14
Copy link
Contributor Author

we can unblock with #3370

And celestiaorg/celestia-core#1363

@staheri14 staheri14 mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
priority:high optional label to track the relative priority of planned items WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: adding big block tests to the main branch celestiaorg/celestia-app
2 participants
@staheri14 @evan-forbes