feat: not check cognito User Pool Authorizers for OPTIONS method #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vumdao
changed the title
dontirun
requested changes
Nov 8, 2024
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
|
@dontirun any more comments? |
dontirun
approved these changes
Nov 12, 2024
|
@vumdao Can you run
|
|
@dontirun Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPTIONS requests should be allowed without authentication.
OPTIONS is the HTTP method used for CORS-preflight requests and the CORS specification confirms as follows:
a CORS-preflight request never includes credentials.