Chart.apiObjects doesn't include Helm, Include generated resources.

[shinebayar-g]

Description of the bug:

I noticed that my code was buggy because Chart.apiObjects didn't include Helm and Include resources.

Reproduction Steps:

import { App, Chart, Helm, Include } from 'cdk8s';
import { KubeNamespace } from './imports/k8s';

async function main() {
    const app = new App();
    const chart = new Chart(app, 'foo');

    new KubeNamespace(chart, 'ns', {
        metadata: {
            name: 'foo',
        },
    });

    const helm = new Helm(chart, 'chart', {
        repo: 'https://grafana.github.io/helm-charts',
        chart: 'alloy',
        releaseName: 'alloy',
        version: '0.10.0',
        namespace: 'foo',
    });

    const i = new Include(chart, 'include', {
        url: 'https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/refs/heads/main/example/prometheus-operator-crd/monitoring.coreos.com_alertmanagerconfigs.yaml',
    });

    // apiObjects only works when used as a direct reference.
    i.apiObjects.forEach((apiObject) => {
        console.warn('include kind:', apiObject.kind);
    });

    // apiObjects only works when used as a direct reference.
    helm.apiObjects.forEach((apiObject) => {
        console.warn('helm kind:', apiObject.kind);
    });

    // Only prints
    // chart kind: Namespace
    //  - foo/foo.k8s.yaml
    chart.apiObjects.forEach((apiObject) => {
        console.warn('chart kind:', apiObject.kind);
    });

    app.synth();
}

main();

Error Log:

Environment:

• Framework Version:
• OS:

Other:

---

This is 🐛 Bug Report

[shinebayar-g]

I think it kind of makes sense that apiObjects wouldn't return Helm, Include types because they're not ApiObject type..

I could use something like this, but it doesn't work.

chart.node.children.forEach((child) => {
  // But I can't do
  child.node.apiObjects
});

Fortunately I found out about this property exists child.node.host and it actually contains what I needed. But it's not defined in the typescript.

So it's turning out to be more like a feature request: How to iterate through all of the children's apiObjects recursively?

[iliapolo]

How about:

chart.node.findAll().filter(c => ApiObject.isApiObject(c)).forEach((apiObject) => {
    console.warn('chart kind:', apiObject.kind);
});

include kind: CustomResourceDefinition
helm kind: ServiceAccount
helm kind: ConfigMap
helm kind: ClusterRole
helm kind: ClusterRoleBinding
helm kind: Service
helm kind: DaemonSet
chart kind: ServiceAccount
chart kind: ConfigMap
chart kind: ClusterRole
chart kind: ClusterRoleBinding
chart kind: Service
chart kind: DaemonSet
chart kind: CustomResourceDefinition