Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default blue color lighter #177

Open
cdepillabout opened this issue Jan 3, 2021 · 4 comments
Open

make default blue color lighter #177

cdepillabout opened this issue Jan 3, 2021 · 4 comments
Labels
beginner-friendly Good for newcomers enhancement New feature or request help wanted Extra attention is needed

Comments

@cdepillabout
Copy link
Owner

The default blue color in Termonad is quite dark. If you have text in the default blue color, it is quite hard to read on a terminal with a dark background.

Termonad just provides the default colors from VTE, but it would be nice to deviate from the default VTE colors and provide a blue that is lighter, since the background color in Termonad is dark by default.

I explain a little more about this in #176 (comment).

Implementing this would basically require changing the following two functions to set a different blue color:

-- | A 'Vec' of standard colors. Default value for 'BasicPalette'.
--
-- >>> showColourVec defaultStandardColours
-- ["#000000ff","#c00000ff","#00c000ff","#c0c000ff","#0000c0ff","#c000c0ff","#00c0c0ff","#c0c0c0ff"]
defaultStandardColours :: (Ord b, Floating b) => List8 (AlphaColour b)
defaultStandardColours = coloursFromBits 192 0
-- | A 'Vec' of extended (light) colors. Default value for 'ExtendedPalette'.
--
-- >>> showColourVec defaultLightColours
-- ["#3f3f3fff","#ff3f3fff","#3fff3fff","#ffff3fff","#3f3fffff","#ff3fffff","#3fffffff","#ffffffff"]
defaultLightColours :: (Ord b, Floating b) => List8 (AlphaColour b)
defaultLightColours = coloursFromBits 192 63

@cdepillabout cdepillabout added enhancement New feature or request help wanted Extra attention is needed beginner-friendly Good for newcomers labels Jan 3, 2021
@M0M097
Copy link

M0M097 commented Jan 3, 2021

As mentioned in the other issue I would be careful with that since it can lead to ugly tui application. So if you try to change the default colors check if for example nmtui looks ok.

Since all cli programs I'm aware of only use blue text in combination with bold fonts I still think it would be easier to enable BoldIsBright by default to solve the problem with unreadable blue text.

@cdepillabout
Copy link
Owner Author

Here are what the standard and light blue colors look like with the current Termonad defaults (taken from #178 (comment)):

image

You can see that they are a little too dark for a black background.

@juhp
Copy link

juhp commented Jan 8, 2021

Just wondering (not that it should stop termonad), has there been any attempt to address this upstream in libvte itself?

@cdepillabout
Copy link
Owner Author

@juhp That's a good point.

I took a quick look at the VTE issue tracker, but I didn't see any issues about it: https://gitlab.gnome.org/GNOME/vte/-/issues

It is possible that upstream VTE defaults to a white background, so they don't see this problem. It is also possible that Termonad is just using a different color of blue than VTE defaults to (although I'm pretty sure this is not the case). If someone wanted to create an issue upstream, it would probably be a good idea just to double check these two things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly Good for newcomers enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants