Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the Simulator Hierarchy #201

Open
hillmich opened this issue Mar 8, 2023 · 0 comments
Open

Clean up the Simulator Hierarchy #201

hillmich opened this issue Mar 8, 2023 · 0 comments
Milestone
DDSIM 2.0

Comments

@hillmich
Copy link
Contributor

hillmich commented Mar 8, 2023

Currently, the simulator hierarchy reflects it organic/chaotic growth. There are a few things to clean up:

  • Check where the inheretence line could be improved (e.g. StochasticNoiseSimulator)
  • Remove unnecessary members of Simulator (e.g. rootEdge and maybe the dd package (multipe simulators have to create their own packages anyway)
@hillmich hillmich mentioned this issue Mar 8, 2023
Merged
@burgholzer burgholzer added this to the DDSIM 2.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DDSIM 2.0
Development

No branches or pull requests
2 participants
@burgholzer @hillmich