Add useCapture capability #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@ccampbell any news here? |
|
I would like to see this behaviour implemented as well, what is required to get this merged? Perhaps I could help out. |
nbelzer
added a commit
to nbelzer/vimari
that referenced
this pull request
Mar 26, 2020
To be able to stop the propagation of events to the website but still capture them in Vimary we need to listen to the keyEvents using the onCapture flag. Something that has not yet been implemented in Mousetrap (see ccampbell/mousetrap#400).
|
@ccampbell friendly ping :) |
nbelzer
added a commit
to televator-apps/vimari
that referenced
this pull request
Jul 27, 2020
To be able to stop the propagation of events to the website but still capture them in Vimari we need to listen to the keyEvents using the onCapture flag. Something that has not yet been implemented in Mousetrap (see ccampbell/mousetrap#400).
|
@ccampbell any chance you can get this merged? |
|
@ccampbell friendly ping again, would really love to stop using a fork :) |
|
@ccampbell any chance of a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be convenient to intercept keyEvents on capturing phase and not bubbling one. (I need it for Hyper to capture and flag key events BEFORE they reach embedded Terminal).
If you are ok with this feature, I can add documentation.