Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDROBOT-3415 Encode/Decode Shaka-Packager Comment #14

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

broganross
Copy link

This PR adds parsing and writing of a comment preceding the XML root element.
Shaka-packager adds a comment before the XML root element, and whisk would like to keep an updated version of this comment.
This adds a simple layer to the MPD encoding/decoding to collect and write the comment.

…ml prolog and before the root element of the XML.
@broganross broganross requested a review from vish91 August 28, 2023 17:07
@vish91 vish91 merged commit 76ad024 into master Aug 31, 2023
1 check passed
@vish91 vish91 deleted the VIDROBOT-3415-add-comment-handling branch August 31, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants