Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a custom password input component #1702

Open
RodriSanchez1 opened this issue May 27, 2024 · 9 comments · May be fixed by #1709
Open

Create a custom password input component #1702

RodriSanchez1 opened this issue May 27, 2024 · 9 comments · May be fixed by #1709

Comments

@RodriSanchez1
Copy link
Collaborator

Recently, we implemented the toggle password visibility feature on the password input in PR #1700. This was just for the Login form. I believe we need to use the same feature on the Sign Up form as well.

To achieve this, we can create a new functional component and use it on both forms.

@bosiljkatodic00
Copy link

Hi! I am interested in working on this issue. Could you please assign it to me? Thanks!

@RodriSanchez1
Copy link
Collaborator Author

Yeah! For sure! @bosiljkatodic00 welcomee

@KirtiKamal
Copy link

hey @RodriSanchez1 I want to work on this issue can you please elaborate what kind of change you actually want to be done

@RodriSanchez1
Copy link
Collaborator Author

RodriSanchez1 commented Jun 13, 2024

@bosiljkatodic00 are you working on this? If not let me know and I will assign @KirtiKamal

A new PasswordTextField (or some descriptive name) component needs to be created as a funtional component and use it on Login and Sign Up forms.

We will wait until tomorrow to get the bosil response

@KirtiKamal
Copy link

Okay got it. You want me to create a PasswordTextField as a functional component that can be used in multiple file. And the pasword field only have one filed that is password correct me if i am wrong

@RodriSanchez1
Copy link
Collaborator Author

Yes! See the changes on the PR mencioned on this issue description

@KirtiKamal
Copy link

@RodriSanchez1 I have added PasswordTextField and given a PR kindly check

@bosiljkatodic00
Copy link

Hi @RodriSanchez1,

I apologize for the delay in my response. Please feel free to assign this issue to him, as I haven't had the opportunity to start working on it yet.

Thank you for your understanding.

@RodriSanchez1
Copy link
Collaborator Author

@bosiljkatodic00 that's okay! No problem at all. If you want to collaborate in other thing when you have free time, let me know.

@KirtiKamal cool! I will check it later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants