Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please use placeholders in sql queries #11

Open
danmarsden opened this issue Nov 8, 2022 · 1 comment
Open

please use placeholders in sql queries #11

danmarsden opened this issue Nov 8, 2022 · 1 comment

Comments

@danmarsden
Copy link

WHERE cm_s.id = $cmid AND cm_a.deletioninprogress = 0 AND cm_s.module = (SELECT id FROM {modules} WHERE name = 'scorm')",

Please do not inject variables into inline sql - use placeholders to prevent sql injection vulnerabilities and to follow moodle codiing guidelines - more info see:
https://moodledev.io/docs/apis/core/dml

@Lhannecart
Copy link
Contributor

I have checked all the requests and added a placeholder for each of them in the plugin where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants