Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to skip certain HTML tags? #27

Open
emielvangoor opened this issue Feb 12, 2016 · 5 comments
Open

Is it possible to skip certain HTML tags? #27

emielvangoor opened this issue Feb 12, 2016 · 5 comments
Labels
Feature

Comments

@emielvangoor
Copy link

When I diff a new text with <!DOCTYPE html ...>, bodyor head tag and the old text doesn't include these the HtmlDiffwill add a class="diffmod" to the tag, is there anyway to avoid/skip these kind of tags?
@jschroed91
Copy link
Member

Hi Emiel, there is currently no way to skip them.

I will be working on updates for table diffing over the next week, so I will be sure to make some time to include a feature that allows you to skip/ignore certain tags.

A workaround for now might be to preprocess the text before sending it into HtmlDiff to remove those tags.

@emielvangoor
Copy link
Author

OK, thanks for the reply Josh!

@jschroed91
Copy link
Member

@emielvangoor Just an update - have not gotten to this yet but it's on my radar. I will aim to get this feature included in the next release - probably 1-2 weeks.

@jschroed91 jschroed91 added this to the v0.1.1 milestone Mar 14, 2016
@jschroed91 jschroed91 self-assigned this Mar 14, 2016
@emielvangoor
Copy link
Author

@jschroed91 Thanks for the update..! For now I created a simple preprocessor to remove the tags as you suggested. Would be great if you implement this feature in the library.. 👍

@jschroed91 jschroed91 removed this from the v0.1.1 milestone Mar 16, 2016
@jschroed91 jschroed91 removed their assignment Aug 26, 2016
@jschroed91
Copy link
Member

This has been de-prioritized, and currently not sure if I have plans to implement this in the near future, since the focus of this library is on HTML snippets. However, I'm not against handling this so that it's compatible with full html documents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emielvangoor @jschroed91