Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Terraform Provider 4 #461

Closed
npalm opened this issue Mar 7, 2022 · 4 comments · Fixed by #460
Closed

Supporting Terraform Provider 4 #461

npalm opened this issue Mar 7, 2022 · 4 comments · Fixed by #460

Comments

@npalm
Copy link
Collaborator

npalm commented Mar 7, 2022

Thanks to @meMuszr in #444 the initial work is done to provide support for AWS Terraform provider 4. I have merged the PR in #460 to test and fix some minors. All the work is still under test. But would like to gather feedback from the community.

  • Feel free to comment on PR feat: Support AWS provider 4 #460 and provide suggestions
  • Look for people that can run a test on the PR?
  • Look for feedback should we already bump the module to Terraform 4.x? You always have the option to use multiple providers if really need. Please comment on the issue.
@npalm npalm linked a pull request Mar 7, 2022 that will close this issue
@npalm npalm pinned this issue Mar 7, 2022
@photosojourn
Copy link

Hey @npalm hope your well. Do you have an eta for this PR being merged? No major rush, but it would allow us to avoid a work around. Thanks for the great work!

@npalm
Copy link
Collaborator Author

npalm commented Mar 10, 2022

Since upgrade have major impact, I have crated this issue. To give the community a bit of time to give feedback. If it helps I can tag this branch so you can already start using it.

@kayman-mk
Copy link
Collaborator

I constantly get a warning in Security Hub that I should use IMDSv2 for EC2 instances. May be it is worth to integrate this as well? Especially as all my executers failed after switching to AWS 4.x provider (see #445)

Security Hub issue: EC2.8 EC2 instances should use Instance Metadata Service Version 2 (IMDSv2)

IMDSv2 for EC2 in Terraform

@npalm
Copy link
Collaborator Author

npalm commented May 19, 2022

I constantly get a warning in Security Hub that I should use IMDSv2 for EC2 instances. May be it is worth to integrate this as well? Especially as all my executers failed after switching to AWS 4.x provider (see #445)

Security Hub issue: EC2.8 EC2 instances should use Instance Metadata Service Version 2 (IMDSv2)

IMDSv2 for EC2 in Terraform

Added a solution based on your PR #445 see #490

@npalm npalm unpinned this issue Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants