Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with transparent background and kitty after new update #791

Closed
manangulati9 opened this issue Oct 27, 2024 · 2 comments · Fixed by #794
Closed

Issues with transparent background and kitty after new update #791

manangulati9 opened this issue Oct 27, 2024 · 2 comments · Fixed by #794
Labels
bug Something isn't working

Comments

@manangulati9
Copy link

manangulati9 commented Oct 27, 2024

Description

I was using kitty opacity 0.75 and nvim didn't follow this opacity which was fine for me. After #786 if I want to revert to the old behavior, the option for that seems to be missing. I tried using transparent_background=false but that only reverts colors for plugins and not the main editor itself. Also, I'd appreciate some help on how to set LSP hover info box border with transparent_background enabled as it's not present atm. The black color for LSP info is also not ideal. I'd like to shift to this new transparent theme but the two issues above preventing me for doing so right now.

transparent_background enabled
241027_18h11m04s_screenshot
241027_18h11m35s_screenshot

transparent_background disabled
241027_18h12m27s_screenshot

Neovim version

NVIM v0.10.2
Build type: RelWithDebInfo
LuaJIT 2.1.1727870382

Terminal and multiplexer

kitty 0.36.4 with tmux 3.5a

Catppuccin version / branch / rev

cf021eb

Steps to reproduce

nvim -u repro.lua

Expected behavior

Setting transparent_background = false should prevent catppuccin from following kitty's opacity

Actual behavior

Setting transparent_background = false only resets colors for plugins, not the main editor itself.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "catppuccin/nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("catppuccin")
-- add anything else here
@manangulati9 manangulati9 added the bug Something isn't working label Oct 27, 2024
@manangulati9
Copy link
Author

manangulati9 commented Oct 27, 2024

As suggested in the discord server, I also tried setting kitty = false but that also doesn't do anything. Also, I encountered a weird bug when opening oil.nvim during the landing page. Somehow there's some new weird lines appearing. It maybe an issue with oil.nvim I'm not entirely sure.

241027_19h29m06s_screenshot
Kooha-2024-10-27-19-16-40.webm

@sgoudham
Copy link
Contributor

sgoudham commented Oct 28, 2024

Hey 👋,

Ignore my comments below, I believe our PR should be reverted. I'll get around to this in the morning, sorry for the hassle!

If I'm understanding this correctly, we merged #786 to only adjust the colour channels (and therefore workaround the kitty issue documented in the source code) if kitty is true and if transparent_background is true.

Could you try setting both those to true in your configuration and see what results you get?

Please let me know if I'm still misunderstanding your issue and what you want to achieve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants