Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document modules that need Allow From Derivation #172

Closed
vdbe opened this issue May 14, 2024 · 8 comments
Closed

Document modules that need Allow From Derivation #172

vdbe opened this issue May 14, 2024 · 8 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@vdbe
Copy link
Contributor

vdbe commented May 14, 2024

An extra readme segment that specifies which modules require Allow From Derivation
or/and an option to exclude those modules from the global enable option.

@vdbe
Copy link
Contributor Author

vdbe commented May 14, 2024

Willing to implement it myself, just let me know.

@getchoo
Copy link
Member

getchoo commented May 21, 2024

documenting what modules contain it would be nice. feel free to PR it to our FAQ

regarding excluding them from the global enable option: i can see why this might be a requested feature, but i feel would overcomplicate how we actually implement catppuccin.enable for what's a pretty niche feature. giving a neat list of modules should be good enough for most i'd imagine

@vdbe
Copy link
Contributor Author

vdbe commented May 21, 2024

For the option my idea was to have 1 place (2 nixos and home manager) where you use mkOverride with priority over MkOptionDefault.

This way you don't need to touch mkCatppuccinOpt and can possibly generate the description for documentation instead of a Readme/FAQ segment.

Don't know yet how you would test it so that it is not a best effort option.

Would this implementation be overcomplicated?

@getchoo getchoo added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jun 23, 2024
@vdbe
Copy link
Contributor Author

vdbe commented Jun 25, 2024

All the IFD's at the time of writing

    # IFD's
    programs = {
      cava.catppuccin.enable = false;
      foot.catppuccin.enable = false;
      gh-dash.catppuccin.enable = false;
      imv.catppuccin.enable = false;
      kitty.catppuccin.enable = false; # IFD is inside HM
      lazygit.catppuccin.enable = false;
      mpv.catppuccin.enable = false;
      swaylock.catppuccin.enable = false;
      tofi.catppuccin.enable = false;
      zathura.catppuccin.enable = false;
    };
    services = {
      dunst.catppuccin.enable = false;
      mako.catppuccin.enable = false;
    };

@vdbe vdbe mentioned this issue Jun 25, 2024
@mightyiam
Copy link

From my experience, nix flake show can fail due to these. Perhaps that could impact how niche we perceive this issue to be.

@alejandro-angulo
Copy link
Contributor

I just wanted to chime in and mention that the kitty IFD shouldn't be required in upstream anymore. We'll have to switch to setting themeFile instead of theme now though.

nix-community/home-manager#5750

@vdbe
Copy link
Contributor Author

vdbe commented Sep 20, 2024

Someone is already working on this, see #337.

@getchoo
Copy link
Member

getchoo commented Sep 21, 2024

This was meant to be closed by #246. Thanks for all the work done here!

@getchoo getchoo closed this as completed Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants