Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom domains (GitHub Enterprise, self-hosted Gitea/Forgejo) #41

Closed
miloth opened this issue May 9, 2024 · 4 comments · Fixed by #90
Closed

Add support for custom domains (GitHub Enterprise, self-hosted Gitea/Forgejo) #41

miloth opened this issue May 9, 2024 · 4 comments · Fixed by #90
Labels
enhancement New feature or request

Comments

@miloth
Copy link

miloth commented May 9, 2024

What feature are you envisioning?

Allow the extension to be enabled for custom GHE domains. It could use a similar strategy to Better Pull Resquests for GitHub, implemented in this PR.

PS: I might give it a go when I find some time.

@miloth miloth added the enhancement New feature or request label May 9, 2024
@uncenter
Copy link
Member

Hmm, I would love to add this but I think with MV3 it is no longer possible. I tried following https://github.com/fregante/webext-dynamic-content-scripts/blob/main/how-to-add-github-enterprise-support-to-web-extensions.md but was unable to make it work due to permissions errors, see https://groups.google.com/a/chromium.org/g/chromium-extensions/c/EnUmtHWOI9o?pli=1.

@uncenter uncenter changed the title Add GitHub Enterprise support Add support for custom domains (GitHub Enterprise, self-hosted Gitea/Forgejo) Jun 16, 2024
@uncenter
Copy link
Member

uncenter commented Jun 16, 2024

Ah,. actually that thread is outdated and optional_host_permissions is now shipped in browsers. I'll look into why it wasn't working again.

@uncenter
Copy link
Member

uncenter commented Jul 3, 2024

@uncenter
Copy link
Member

uncenter commented Jul 3, 2024

Unfortunately it may take a few days for the new version to appear on the store, as it requires additional permissions and therefore may have to go under manual human review before approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants