Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the command catkin config -p 2 add something to the profiles config.yaml file? #423

Open
Levi-Armstrong opened this issue Jan 11, 2017 · 4 comments

Comments

@Levi-Armstrong
Copy link

System Info

Build / Run Issue

When executing the command below I would have expected something in the profile's config.yaml file to change.
catkin config -p 2

Expected Behavior

I would of expected something to be added to the profile config.yaml similar to when using the -j option.

Actual Behavior

Nothing in the profile's config.yaml file changes.

@wjwwood
Copy link
Member

wjwwood commented Jan 11, 2017

Looks like a bug. I would expect -p 2 when passed to catkin config to change the settings, but when passed to catkin build to be a temporary override of that.

@wjwwood wjwwood added the bug label Jan 11, 2017
@wjwwood wjwwood added this to the x.x.x - Untargeted Features milestone Jan 11, 2017
@Levi-Armstrong
Copy link
Author

@wjwwood: What should be added to the config file? Should the list where the -j N option is added be appended with the -p N flag also?

@wjwwood
Copy link
Member

wjwwood commented Jan 27, 2017

I'm not sure exactly what should be added. @jbohren wrote this part of the code IIRC.

@NikolausDemmel
Copy link
Member

What should be added to the config file? Should the list where the -j N option is added be appended with the -p N flag also?

I'm also not sure without looking further into the code, but I would assume that the make_args list ist not the place to -p N, since -p is parallelism by catkin build itself, and is not passed to make. My wild guess is that it should be a separate entry in the config dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants