Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobserver: Jobserver doesn't work on Python3.4 #208

Closed
jbohren opened this issue Jun 1, 2015 · 3 comments
Closed

jobserver: Jobserver doesn't work on Python3.4 #208

jbohren opened this issue Jun 1, 2015 · 3 comments

Comments

@jbohren
Copy link
Contributor

jbohren commented Jun 1, 2015

I noticed it when running the tests for #196, but it appears that it's even an issue in the current branch. However, people probably aren't noticing because in the current version warnings are suppressed unless the package fails.

See here: https://travis-ci.org/catkin/catkin_tools/jobs/61523929#L579

@jbohren jbohren changed the title jobserver: Jobserver appears to not work on Python3.4 / Ubuntu 14.04 jobserver: Jobserver appears to not work on Python3.4 Jun 1, 2015
@jbohren jbohren added the bug label Jun 11, 2015
@jbohren jbohren added this to the 0.4.0 - Beta 2 milestone Jun 11, 2015
@jbohren
Copy link
Contributor Author

jbohren commented Jun 25, 2015

I believe this is the culprit: https://docs.python.org/3.4/library/os.html#fd-inheritance

@jbohren
Copy link
Contributor Author

jbohren commented Jun 25, 2015

This is resolved by the combination of #196 and osrf/osrf_pycommon#10

@jbohren jbohren changed the title jobserver: Jobserver appears to not work on Python3.4 jobserver: Jobserver doesn't work on Python3.4 Jun 25, 2015
@jbohren
Copy link
Contributor Author

jbohren commented Jan 20, 2016

Jobserver works on 3.4 with changes in #249.

@jbohren jbohren closed this as completed Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant